mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Hans Verkuil](/assets/img/avatar_default.png)
Describe the tasks to be done for this driver to be promoted to a non-staging one. [m.chehab@samsung.com: Add a patch description; add a note about the CodingStyle issues and make sure that the README lines are not bigger than 80 cols.] Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
24 lines
1.1 KiB
Text
24 lines
1.1 KiB
Text
TODO:
|
|
|
|
From the initial code review:
|
|
|
|
The main thing you need to do is to implement all the controls using the
|
|
control framework (see Documentation/video4linux/v4l2-controls.txt).
|
|
Most drivers are by now converted to the control framework, so you will
|
|
find many examples of how to do this in drivers/media/radio.
|
|
|
|
The sysfs stuff should be replaced by controls as well. A lot of the RDS
|
|
support is now available as controls (although there may well be some
|
|
missing features, but that is easy enough to add). Since the RDS data is
|
|
actually read() from the device I am not sure whether the RDS
|
|
properties/controls should be there at all.
|
|
|
|
Correct Coding Style, as this driver also violates several Style
|
|
rules, and do evil tricks, like returning from a function inside a
|
|
macro.
|
|
|
|
Finally this driver should probably be split up into two parts: one
|
|
v4l2_subdev-based core driver and one platform driver. See e.g.
|
|
radio-si4713/si4713-i2c.c as a good example. But I would wait with that
|
|
until the rest of the driver is cleaned up. Then I have a better idea of
|
|
whether this is necessary or not.
|