mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
441ccc3512
When compiling the x86 kernel, if X86_LOCAL_APIC is not enabled but
GENERIC_MSI_IRQ is selected in '.config', the following compilation
error will occur:
include/linux/gpio/driver.h:38:19: error:
field 'msiinfo' has incomplete type
kernel/irq/msi.c:752:5: error: invalid use of incomplete typedef
'msi_alloc_info_t' {aka 'struct irq_alloc_info'}
kernel/irq/msi.c:740:1: error: control reaches end of non-void function
This is because file such as 'kernel/irq/msi.c' only depends on
'GENERIC_MSI_IRQ', and uses 'struct msi_alloc_info_t'. However,
this struct depends on 'X86_LOCAL_APIC'.
When enable 'GENERIC_MSI_IRQ' or 'X86_LOCAL_APIC' will select
'IRQ_DOMAIN_HIERARCHY', so exposing this struct using
'IRQ_DOMAIN_HIERARCHY' rather than 'X86_LOCAL_APIC'.
Under the above conditions, if 'HPET_TIMER' is selected, the following
compilation error will occur:
arch/x86/kernel/hpet.c:550:13: error: ‘x86_vector_domain’ undeclared
arch/x86/kernel/hpet.c:600:9: error: implicit declaration of
function ‘init_irq_alloc_info’
This is because 'x86_vector_domain' is defined in 'kernel/apic/vector.c'
which is compiled only when 'X86_LOCAL_APIC' is enabled. Besides,
function 'msi_domain_set_affinity' is defined in 'include/linux/msi.h'
which depends on 'GENERIC_MSI_IRQ'. So use 'X86_LOCAL_APIC' and
'GENERIC_MSI_IRQ' to expose these code.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Lu Yao <yaolu@kylinos.cn>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20231012032659.323251-1-yaolu@kylinos.cn
135 lines
3 KiB
C
135 lines
3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_X86_HW_IRQ_H
|
|
#define _ASM_X86_HW_IRQ_H
|
|
|
|
/*
|
|
* (C) 1992, 1993 Linus Torvalds, (C) 1997 Ingo Molnar
|
|
*
|
|
* moved some of the old arch/i386/kernel/irq.h to here. VY
|
|
*
|
|
* IRQ/IPI changes taken from work by Thomas Radke
|
|
* <tomsoft@informatik.tu-chemnitz.de>
|
|
*
|
|
* hacked by Andi Kleen for x86-64.
|
|
* unified by tglx
|
|
*/
|
|
|
|
#include <asm/irq_vectors.h>
|
|
|
|
#define IRQ_MATRIX_BITS NR_VECTORS
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
#include <linux/percpu.h>
|
|
#include <linux/profile.h>
|
|
#include <linux/smp.h>
|
|
|
|
#include <linux/atomic.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/sections.h>
|
|
|
|
#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
|
|
struct irq_data;
|
|
struct pci_dev;
|
|
struct msi_desc;
|
|
|
|
enum irq_alloc_type {
|
|
X86_IRQ_ALLOC_TYPE_IOAPIC = 1,
|
|
X86_IRQ_ALLOC_TYPE_HPET,
|
|
X86_IRQ_ALLOC_TYPE_PCI_MSI,
|
|
X86_IRQ_ALLOC_TYPE_PCI_MSIX,
|
|
X86_IRQ_ALLOC_TYPE_DMAR,
|
|
X86_IRQ_ALLOC_TYPE_AMDVI,
|
|
X86_IRQ_ALLOC_TYPE_UV,
|
|
};
|
|
|
|
struct ioapic_alloc_info {
|
|
int pin;
|
|
int node;
|
|
u32 is_level : 1;
|
|
u32 active_low : 1;
|
|
u32 valid : 1;
|
|
};
|
|
|
|
struct uv_alloc_info {
|
|
int limit;
|
|
int blade;
|
|
unsigned long offset;
|
|
char *name;
|
|
|
|
};
|
|
|
|
/**
|
|
* irq_alloc_info - X86 specific interrupt allocation info
|
|
* @type: X86 specific allocation type
|
|
* @flags: Flags for allocation tweaks
|
|
* @devid: Device ID for allocations
|
|
* @hwirq: Associated hw interrupt number in the domain
|
|
* @mask: CPU mask for vector allocation
|
|
* @desc: Pointer to msi descriptor
|
|
* @data: Allocation specific data
|
|
*
|
|
* @ioapic: IOAPIC specific allocation data
|
|
* @uv: UV specific allocation data
|
|
*/
|
|
struct irq_alloc_info {
|
|
enum irq_alloc_type type;
|
|
u32 flags;
|
|
u32 devid;
|
|
irq_hw_number_t hwirq;
|
|
const struct cpumask *mask;
|
|
struct msi_desc *desc;
|
|
void *data;
|
|
|
|
union {
|
|
struct ioapic_alloc_info ioapic;
|
|
struct uv_alloc_info uv;
|
|
};
|
|
};
|
|
|
|
struct irq_cfg {
|
|
unsigned int dest_apicid;
|
|
unsigned int vector;
|
|
};
|
|
|
|
extern struct irq_cfg *irq_cfg(unsigned int irq);
|
|
extern struct irq_cfg *irqd_cfg(struct irq_data *irq_data);
|
|
extern void lock_vector_lock(void);
|
|
extern void unlock_vector_lock(void);
|
|
#ifdef CONFIG_SMP
|
|
extern void vector_schedule_cleanup(struct irq_cfg *);
|
|
extern void irq_complete_move(struct irq_cfg *cfg);
|
|
#else
|
|
static inline void vector_schedule_cleanup(struct irq_cfg *c) { }
|
|
static inline void irq_complete_move(struct irq_cfg *c) { }
|
|
#endif
|
|
|
|
extern void apic_ack_edge(struct irq_data *data);
|
|
#else /* CONFIG_IRQ_DOMAIN_HIERARCHY */
|
|
static inline void lock_vector_lock(void) {}
|
|
static inline void unlock_vector_lock(void) {}
|
|
#endif /* CONFIG_IRQ_DOMAIN_HIERARCHY */
|
|
|
|
/* Statistics */
|
|
extern atomic_t irq_err_count;
|
|
extern atomic_t irq_mis_count;
|
|
|
|
extern void elcr_set_level_irq(unsigned int irq);
|
|
|
|
extern char irq_entries_start[];
|
|
#ifdef CONFIG_TRACING
|
|
#define trace_irq_entries_start irq_entries_start
|
|
#endif
|
|
|
|
extern char spurious_entries_start[];
|
|
|
|
#define VECTOR_UNUSED NULL
|
|
#define VECTOR_SHUTDOWN ((void *)-1L)
|
|
#define VECTOR_RETRIGGERED ((void *)-2L)
|
|
|
|
typedef struct irq_desc* vector_irq_t[NR_VECTORS];
|
|
DECLARE_PER_CPU(vector_irq_t, vector_irq);
|
|
|
|
#endif /* !ASSEMBLY_ */
|
|
|
|
#endif /* _ASM_X86_HW_IRQ_H */
|