mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
![Wen Yang](/assets/img/avatar_default.png)
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function. ./arch/arm/mach-bcm/platsmp-brcmstb.c:337:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 329, but without a corresponding object release within this function. ./arch/arm/mach-bcm/platsmp-brcmstb.c:341:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 329, but without a corresponding object release within this functio ./arch/arm/mach-bcm/bcm63xx_smp.c:150:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: Brian Norris <computersforpeace@gmail.com> Cc: Gregory Fong <gregory.0xf0@gmail.com> Acked-by: Ray Jui <ray.jui@broadcom.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
73 lines
1.9 KiB
C
73 lines
1.9 KiB
C
/*
|
|
* Copyright (C) 2012-2014 Broadcom Corporation
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation version 2.
|
|
*
|
|
* This program is distributed "as is" WITHOUT ANY WARRANTY of any
|
|
* kind, whether express or implied; without even the implied warranty
|
|
* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/clocksource.h>
|
|
#include <linux/of_address.h>
|
|
|
|
#include <asm/mach/arch.h>
|
|
|
|
#include "kona_l2_cache.h"
|
|
|
|
#define SECWDOG_OFFSET 0x00000000
|
|
#define SECWDOG_RESERVED_MASK 0xe2000000
|
|
#define SECWDOG_WD_LOAD_FLAG_MASK 0x10000000
|
|
#define SECWDOG_EN_MASK 0x08000000
|
|
#define SECWDOG_SRSTEN_MASK 0x04000000
|
|
#define SECWDOG_CLKS_SHIFT 20
|
|
#define SECWDOG_COUNT_SHIFT 0
|
|
|
|
static void bcm281xx_restart(enum reboot_mode mode, const char *cmd)
|
|
{
|
|
uint32_t val;
|
|
void __iomem *base;
|
|
struct device_node *np_wdog;
|
|
|
|
np_wdog = of_find_compatible_node(NULL, NULL, "brcm,kona-wdt");
|
|
if (!np_wdog) {
|
|
pr_emerg("Couldn't find brcm,kona-wdt\n");
|
|
return;
|
|
}
|
|
base = of_iomap(np_wdog, 0);
|
|
of_node_put(np_wdog);
|
|
if (!base) {
|
|
pr_emerg("Couldn't map brcm,kona-wdt\n");
|
|
return;
|
|
}
|
|
|
|
/* Enable watchdog with short timeout (244us). */
|
|
val = readl(base + SECWDOG_OFFSET);
|
|
val &= SECWDOG_RESERVED_MASK | SECWDOG_WD_LOAD_FLAG_MASK;
|
|
val |= SECWDOG_EN_MASK | SECWDOG_SRSTEN_MASK |
|
|
(0x15 << SECWDOG_CLKS_SHIFT) |
|
|
(0x8 << SECWDOG_COUNT_SHIFT);
|
|
writel(val, base + SECWDOG_OFFSET);
|
|
|
|
/* Wait for reset */
|
|
while (1);
|
|
}
|
|
|
|
static void __init bcm281xx_init(void)
|
|
{
|
|
kona_l2_cache_init();
|
|
}
|
|
|
|
static const char * const bcm281xx_dt_compat[] = {
|
|
"brcm,bcm11351", /* Have to use the first number upstreamed */
|
|
NULL,
|
|
};
|
|
|
|
DT_MACHINE_START(BCM281XX_DT, "BCM281xx Broadcom Application Processor")
|
|
.init_machine = bcm281xx_init,
|
|
.restart = bcm281xx_restart,
|
|
.dt_compat = bcm281xx_dt_compat,
|
|
MACHINE_END
|