mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Arnd Bergmann](/assets/img/avatar_default.png)
Building with the clang integrated assembler produces a couple of
errors for the s3c24xx fiq support:
arch/arm/mach-s3c/irq-s3c24xx-fiq.S:52:2: error: instruction 'subne' can not set flags, but 's' suffix specified
subnes pc, lr, #4 @@ return, still have work to do
arch/arm/mach-s3c/irq-s3c24xx-fiq.S:64:1: error: invalid symbol redefinition
s3c24xx_spi_fiq_txrx:
There are apparently two problems: one with extraneous or duplicate
labels, and one with old-style opcode mnemonics. Stefan Agner has
previously fixed other problems like this, but missed this particular
file.
Fixes: bec0806cfe
("spi_s3c24xx: add FIQ pseudo-DMA support")
Cc: Stefan Agner <stefan@agner.ch>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210204162416.3030114-1-arnd@kernel.org
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
112 lines
2.7 KiB
ArmAsm
112 lines
2.7 KiB
ArmAsm
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/* linux/drivers/spi/spi_s3c24xx_fiq.S
|
|
*
|
|
* Copyright 2009 Simtec Electronics
|
|
* Ben Dooks <ben@simtec.co.uk>
|
|
*
|
|
* S3C24XX SPI - FIQ pseudo-DMA transfer code
|
|
*/
|
|
|
|
#include <linux/linkage.h>
|
|
#include <asm/assembler.h>
|
|
|
|
#include "map.h"
|
|
#include "regs-irq.h"
|
|
|
|
#include <linux/spi/s3c24xx-fiq.h>
|
|
|
|
#define S3C2410_SPTDAT (0x10)
|
|
#define S3C2410_SPRDAT (0x14)
|
|
|
|
.text
|
|
|
|
@ entry to these routines is as follows, with the register names
|
|
@ defined in fiq.h so that they can be shared with the C files which
|
|
@ setup the calling registers.
|
|
@
|
|
@ fiq_rirq The base of the IRQ registers to find S3C2410_SRCPND
|
|
@ fiq_rtmp Temporary register to hold tx/rx data
|
|
@ fiq_rspi The base of the SPI register block
|
|
@ fiq_rtx The tx buffer pointer
|
|
@ fiq_rrx The rx buffer pointer
|
|
@ fiq_rcount The number of bytes to move
|
|
|
|
@ each entry starts with a word entry of how long it is
|
|
@ and an offset to the irq acknowledgment word
|
|
|
|
ENTRY(s3c24xx_spi_fiq_rx)
|
|
.word fiq_rx_end - fiq_rx_start
|
|
.word fiq_rx_irq_ack - fiq_rx_start
|
|
fiq_rx_start:
|
|
ldr fiq_rtmp, fiq_rx_irq_ack
|
|
str fiq_rtmp, [ fiq_rirq, # S3C2410_SRCPND - S3C24XX_VA_IRQ ]
|
|
|
|
ldrb fiq_rtmp, [ fiq_rspi, # S3C2410_SPRDAT ]
|
|
strb fiq_rtmp, [ fiq_rrx ], #1
|
|
|
|
mov fiq_rtmp, #0xff
|
|
strb fiq_rtmp, [ fiq_rspi, # S3C2410_SPTDAT ]
|
|
|
|
subs fiq_rcount, fiq_rcount, #1
|
|
subsne pc, lr, #4 @@ return, still have work to do
|
|
|
|
@@ set IRQ controller so that next op will trigger IRQ
|
|
mov fiq_rtmp, #0
|
|
str fiq_rtmp, [ fiq_rirq, # S3C2410_INTMOD - S3C24XX_VA_IRQ ]
|
|
subs pc, lr, #4
|
|
|
|
fiq_rx_irq_ack:
|
|
.word 0
|
|
fiq_rx_end:
|
|
|
|
ENTRY(s3c24xx_spi_fiq_txrx)
|
|
.word fiq_txrx_end - fiq_txrx_start
|
|
.word fiq_txrx_irq_ack - fiq_txrx_start
|
|
fiq_txrx_start:
|
|
|
|
ldrb fiq_rtmp, [ fiq_rspi, # S3C2410_SPRDAT ]
|
|
strb fiq_rtmp, [ fiq_rrx ], #1
|
|
|
|
ldr fiq_rtmp, fiq_txrx_irq_ack
|
|
str fiq_rtmp, [ fiq_rirq, # S3C2410_SRCPND - S3C24XX_VA_IRQ ]
|
|
|
|
ldrb fiq_rtmp, [ fiq_rtx ], #1
|
|
strb fiq_rtmp, [ fiq_rspi, # S3C2410_SPTDAT ]
|
|
|
|
subs fiq_rcount, fiq_rcount, #1
|
|
subsne pc, lr, #4 @@ return, still have work to do
|
|
|
|
mov fiq_rtmp, #0
|
|
str fiq_rtmp, [ fiq_rirq, # S3C2410_INTMOD - S3C24XX_VA_IRQ ]
|
|
subs pc, lr, #4
|
|
|
|
fiq_txrx_irq_ack:
|
|
.word 0
|
|
|
|
fiq_txrx_end:
|
|
|
|
ENTRY(s3c24xx_spi_fiq_tx)
|
|
.word fiq_tx_end - fiq_tx_start
|
|
.word fiq_tx_irq_ack - fiq_tx_start
|
|
fiq_tx_start:
|
|
ldrb fiq_rtmp, [ fiq_rspi, # S3C2410_SPRDAT ]
|
|
|
|
ldr fiq_rtmp, fiq_tx_irq_ack
|
|
str fiq_rtmp, [ fiq_rirq, # S3C2410_SRCPND - S3C24XX_VA_IRQ ]
|
|
|
|
ldrb fiq_rtmp, [ fiq_rtx ], #1
|
|
strb fiq_rtmp, [ fiq_rspi, # S3C2410_SPTDAT ]
|
|
|
|
subs fiq_rcount, fiq_rcount, #1
|
|
subsne pc, lr, #4 @@ return, still have work to do
|
|
|
|
mov fiq_rtmp, #0
|
|
str fiq_rtmp, [ fiq_rirq, # S3C2410_INTMOD - S3C24XX_VA_IRQ ]
|
|
subs pc, lr, #4
|
|
|
|
fiq_tx_irq_ack:
|
|
.word 0
|
|
|
|
fiq_tx_end:
|
|
|
|
.end
|