mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-14 04:26:45 +00:00
9b174527e7
In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In function `set_type': drivers/media/v4l2-core/tuner-core.c:301: undefined reference to `tea5767_attach' drivers/media/v4l2-core/tuner-core.c:307: undefined reference to `tea5761_attach' drivers/media/v4l2-core/tuner-core.c:349: undefined reference to `tda9887_attach' drivers/media/v4l2-core/tuner-core.c:405: undefined reference to `xc4000_attach' This was working previously, until the IS_ENABLED() macro was used to replace the construct like #if defined(CONFIG_DVB_CX24110) || (defined(CONFIG_DVB_CX24110_MODULE) && defined(MODULE)) with the difference that the new code no longer checks whether it is being built as a loadable module itself. To fix this, this new patch adds an 'IS_REACHABLE' macro, which evaluates true in exactly the condition that was used previously. The downside of this is that this trades an obvious link error for a more subtle runtime failure, but it is clear that the change that introduced the link error was unintentional and it seems better to revert it for now. Also, a similar change was originally created by Trent Piepho and then reverted by teh change to the IS_ENABLED macro. Ideally Kconfig would be used to avoid the case of a broken dependency, or the code restructured in a way to turn around the dependency, but either way would require much larger changes here. Fixes:7b34be71db("[media] use IS_ENABLED() macro") See-also:c5dec9fb24("V4L/DVB (4751): Fix DBV_FE_CUSTOMISE for card drivers compiled into kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
97 lines
2.6 KiB
C
97 lines
2.6 KiB
C
/*
|
|
* altera-ci.c
|
|
*
|
|
* CI driver in conjunction with NetUp Dual DVB-T/C RF CI card
|
|
*
|
|
* Copyright (C) 2010 NetUP Inc.
|
|
* Copyright (C) 2010 Igor M. Liplianin <liplianin@netup.ru>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
*
|
|
* GNU General Public License for more details.
|
|
*/
|
|
#ifndef __ALTERA_CI_H
|
|
#define __ALTERA_CI_H
|
|
|
|
#include <linux/kconfig.h>
|
|
|
|
#define ALT_DATA 0x000000ff
|
|
#define ALT_TDI 0x00008000
|
|
#define ALT_TDO 0x00004000
|
|
#define ALT_TCK 0x00002000
|
|
#define ALT_RDY 0x00001000
|
|
#define ALT_RD 0x00000800
|
|
#define ALT_WR 0x00000400
|
|
#define ALT_AD_RG 0x00000200
|
|
#define ALT_CS 0x00000100
|
|
|
|
struct altera_ci_config {
|
|
void *dev;/* main dev, for example cx23885_dev */
|
|
void *adapter;/* for CI to connect to */
|
|
struct dvb_demux *demux;/* for hardware PID filter to connect to */
|
|
int (*fpga_rw) (void *dev, int ad_rg, int val, int rw);
|
|
};
|
|
|
|
#if IS_REACHABLE(CONFIG_MEDIA_ALTERA_CI)
|
|
|
|
extern int altera_ci_init(struct altera_ci_config *config, int ci_nr);
|
|
extern void altera_ci_release(void *dev, int ci_nr);
|
|
extern int altera_ci_irq(void *dev);
|
|
extern int altera_ci_tuner_reset(void *dev, int ci_nr);
|
|
|
|
#else
|
|
|
|
static inline int altera_ci_init(struct altera_ci_config *config, int ci_nr)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return 0;
|
|
}
|
|
|
|
static inline void altera_ci_release(void *dev, int ci_nr)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
}
|
|
|
|
static inline int altera_ci_irq(void *dev)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return 0;
|
|
}
|
|
|
|
static inline int altera_ci_tuner_reset(void *dev, int ci_nr)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return 0;
|
|
}
|
|
|
|
#endif
|
|
#if 0
|
|
static inline int altera_hw_filt_init(struct altera_ci_config *config,
|
|
int hw_filt_nr)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return 0;
|
|
}
|
|
|
|
static inline void altera_hw_filt_release(void *dev, int filt_nr)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
}
|
|
|
|
static inline int altera_pid_feed_control(void *dev, int filt_nr,
|
|
struct dvb_demux_feed *dvbdmxfeed, int onoff)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return 0;
|
|
}
|
|
|
|
#endif /* CONFIG_MEDIA_ALTERA_CI */
|
|
|
|
#endif /* __ALTERA_CI_H */
|