James Smart 777943cd6c nvme-fc: correct csn initialization and increments on error ... [ Upstream commit 67f471b6ed ] This patch fixes a long-standing bug that initialized the FC-NVME cmnd iu CSN value to 1. Early FC-NVME specs had the connection starting with CSN=1. By the time the spec reached approval, the language had changed to state a connection should start with CSN=0. This patch corrects the initialization value for FC-NVME connections. Additionally, in reviewing the transport, the CSN value is assigned to the new IU early in the start routine. It's possible that a later dma map request may fail, causing the command to never be sent to the controller. Change the location of the assignment so that it is immediately prior to calling the lldd. Add a comment block to explain the impacts if the lldd were to additionally fail sending the command. Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by: James Smart <jsmart2021@gmail.com> Reviewed-by: Ewan D. Milne <emilne@redhat.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-05-10 17:54:09 +02:00
..
host	nvme-fc: correct csn initialization and increments on error	2019-05-10 17:54:09 +02:00
target	nvme-loop: init nvmet_ctrl fatal_err_work when allocate	2019-05-08 07:21:44 +02:00
Kconfig	nvme: use menu Kconfig interface	2017-10-04 09:43:57 +02:00
Makefile	nvmet: add a generic NVMe target	2016-07-05 11:30:33 -06:00