mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
00085f1efa
The dma-mapping core and the implementations do not change the DMA attributes passed by pointer. Thus the pointer can point to const data. However the attributes do not have to be a bitfield. Instead unsigned long will do fine: 1. This is just simpler. Both in terms of reading the code and setting attributes. Instead of initializing local attributes on the stack and passing pointer to it to dma_set_attr(), just set the bits. 2. It brings safeness and checking for const correctness because the attributes are passed by value. Semantic patches for this change (at least most of them): virtual patch virtual context @r@ identifier f, attrs; @@ f(..., - struct dma_attrs *attrs + unsigned long attrs , ...) { ... } @@ identifier r.f; @@ f(..., - NULL + 0 ) and // Options: --all-includes virtual patch virtual context @r@ identifier f, attrs; type t; @@ t f(..., struct dma_attrs *attrs); @@ identifier r.f; @@ f(..., - NULL + 0 ) Link: http://lkml.kernel.org/r/1468399300-5399-2-git-send-email-k.kozlowski@samsung.com Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> Acked-by: Robin Murphy <robin.murphy@arm.com> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> Acked-by: Mark Salter <msalter@redhat.com> [c6x] Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> [cris] Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> [drm] Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Fabien Dessenne <fabien.dessenne@st.com> [bdisp] Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> [vb2-core] Acked-by: David Vrabel <david.vrabel@citrix.com> [xen] Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> [xen swiotlb] Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Richard Kuo <rkuo@codeaurora.org> [hexagon] Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> [m68k] Acked-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> [s390] Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> [avr32] Acked-by: Vineet Gupta <vgupta@synopsys.com> [arc] Acked-by: Robin Murphy <robin.murphy@arm.com> [arm64 and dma-iommu] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
268 lines
6.3 KiB
C
268 lines
6.3 KiB
C
/*
|
|
* Copyright (c) 2015 MediaTek Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_gem.h>
|
|
#include <linux/dma-buf.h>
|
|
|
|
#include "mtk_drm_drv.h"
|
|
#include "mtk_drm_gem.h"
|
|
|
|
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
|
|
unsigned long size)
|
|
{
|
|
struct mtk_drm_gem_obj *mtk_gem_obj;
|
|
int ret;
|
|
|
|
size = round_up(size, PAGE_SIZE);
|
|
|
|
mtk_gem_obj = kzalloc(sizeof(*mtk_gem_obj), GFP_KERNEL);
|
|
if (!mtk_gem_obj)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
|
|
if (ret < 0) {
|
|
DRM_ERROR("failed to initialize gem object\n");
|
|
kfree(mtk_gem_obj);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
return mtk_gem_obj;
|
|
}
|
|
|
|
struct mtk_drm_gem_obj *mtk_drm_gem_create(struct drm_device *dev,
|
|
size_t size, bool alloc_kmap)
|
|
{
|
|
struct mtk_drm_private *priv = dev->dev_private;
|
|
struct mtk_drm_gem_obj *mtk_gem;
|
|
struct drm_gem_object *obj;
|
|
int ret;
|
|
|
|
mtk_gem = mtk_drm_gem_init(dev, size);
|
|
if (IS_ERR(mtk_gem))
|
|
return ERR_CAST(mtk_gem);
|
|
|
|
obj = &mtk_gem->base;
|
|
|
|
mtk_gem->dma_attrs = DMA_ATTR_WRITE_COMBINE;
|
|
|
|
if (!alloc_kmap)
|
|
mtk_gem->dma_attrs |= DMA_ATTR_NO_KERNEL_MAPPING;
|
|
|
|
mtk_gem->cookie = dma_alloc_attrs(priv->dma_dev, obj->size,
|
|
&mtk_gem->dma_addr, GFP_KERNEL,
|
|
mtk_gem->dma_attrs);
|
|
if (!mtk_gem->cookie) {
|
|
DRM_ERROR("failed to allocate %zx byte dma buffer", obj->size);
|
|
ret = -ENOMEM;
|
|
goto err_gem_free;
|
|
}
|
|
|
|
if (alloc_kmap)
|
|
mtk_gem->kvaddr = mtk_gem->cookie;
|
|
|
|
DRM_DEBUG_DRIVER("cookie = %p dma_addr = %pad size = %zu\n",
|
|
mtk_gem->cookie, &mtk_gem->dma_addr,
|
|
size);
|
|
|
|
return mtk_gem;
|
|
|
|
err_gem_free:
|
|
drm_gem_object_release(obj);
|
|
kfree(mtk_gem);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
void mtk_drm_gem_free_object(struct drm_gem_object *obj)
|
|
{
|
|
struct mtk_drm_gem_obj *mtk_gem = to_mtk_gem_obj(obj);
|
|
struct mtk_drm_private *priv = obj->dev->dev_private;
|
|
|
|
if (mtk_gem->sg)
|
|
drm_prime_gem_destroy(obj, mtk_gem->sg);
|
|
else
|
|
dma_free_attrs(priv->dma_dev, obj->size, mtk_gem->cookie,
|
|
mtk_gem->dma_addr, mtk_gem->dma_attrs);
|
|
|
|
/* release file pointer to gem object. */
|
|
drm_gem_object_release(obj);
|
|
|
|
kfree(mtk_gem);
|
|
}
|
|
|
|
int mtk_drm_gem_dumb_create(struct drm_file *file_priv, struct drm_device *dev,
|
|
struct drm_mode_create_dumb *args)
|
|
{
|
|
struct mtk_drm_gem_obj *mtk_gem;
|
|
int ret;
|
|
|
|
args->pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
|
|
args->size = args->pitch * args->height;
|
|
|
|
mtk_gem = mtk_drm_gem_create(dev, args->size, false);
|
|
if (IS_ERR(mtk_gem))
|
|
return PTR_ERR(mtk_gem);
|
|
|
|
/*
|
|
* allocate a id of idr table where the obj is registered
|
|
* and handle has the id what user can see.
|
|
*/
|
|
ret = drm_gem_handle_create(file_priv, &mtk_gem->base, &args->handle);
|
|
if (ret)
|
|
goto err_handle_create;
|
|
|
|
/* drop reference from allocate - handle holds it now. */
|
|
drm_gem_object_unreference_unlocked(&mtk_gem->base);
|
|
|
|
return 0;
|
|
|
|
err_handle_create:
|
|
mtk_drm_gem_free_object(&mtk_gem->base);
|
|
return ret;
|
|
}
|
|
|
|
int mtk_drm_gem_dumb_map_offset(struct drm_file *file_priv,
|
|
struct drm_device *dev, uint32_t handle,
|
|
uint64_t *offset)
|
|
{
|
|
struct drm_gem_object *obj;
|
|
int ret;
|
|
|
|
obj = drm_gem_object_lookup(file_priv, handle);
|
|
if (!obj) {
|
|
DRM_ERROR("failed to lookup gem object.\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = drm_gem_create_mmap_offset(obj);
|
|
if (ret)
|
|
goto out;
|
|
|
|
*offset = drm_vma_node_offset_addr(&obj->vma_node);
|
|
DRM_DEBUG_KMS("offset = 0x%llx\n", *offset);
|
|
|
|
out:
|
|
drm_gem_object_unreference_unlocked(obj);
|
|
return ret;
|
|
}
|
|
|
|
static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj,
|
|
struct vm_area_struct *vma)
|
|
|
|
{
|
|
int ret;
|
|
struct mtk_drm_gem_obj *mtk_gem = to_mtk_gem_obj(obj);
|
|
struct mtk_drm_private *priv = obj->dev->dev_private;
|
|
|
|
/*
|
|
* dma_alloc_attrs() allocated a struct page table for mtk_gem, so clear
|
|
* VM_PFNMAP flag that was set by drm_gem_mmap_obj()/drm_gem_mmap().
|
|
*/
|
|
vma->vm_flags &= ~VM_PFNMAP;
|
|
vma->vm_pgoff = 0;
|
|
|
|
ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie,
|
|
mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs);
|
|
if (ret)
|
|
drm_gem_vm_close(vma);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int mtk_drm_gem_mmap_buf(struct drm_gem_object *obj, struct vm_area_struct *vma)
|
|
{
|
|
int ret;
|
|
|
|
ret = drm_gem_mmap_obj(obj, obj->size, vma);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return mtk_drm_gem_object_mmap(obj, vma);
|
|
}
|
|
|
|
int mtk_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
|
|
{
|
|
struct drm_gem_object *obj;
|
|
int ret;
|
|
|
|
ret = drm_gem_mmap(filp, vma);
|
|
if (ret)
|
|
return ret;
|
|
|
|
obj = vma->vm_private_data;
|
|
|
|
return mtk_drm_gem_object_mmap(obj, vma);
|
|
}
|
|
|
|
/*
|
|
* Allocate a sg_table for this GEM object.
|
|
* Note: Both the table's contents, and the sg_table itself must be freed by
|
|
* the caller.
|
|
* Returns a pointer to the newly allocated sg_table, or an ERR_PTR() error.
|
|
*/
|
|
struct sg_table *mtk_gem_prime_get_sg_table(struct drm_gem_object *obj)
|
|
{
|
|
struct mtk_drm_gem_obj *mtk_gem = to_mtk_gem_obj(obj);
|
|
struct mtk_drm_private *priv = obj->dev->dev_private;
|
|
struct sg_table *sgt;
|
|
int ret;
|
|
|
|
sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
|
|
if (!sgt)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ret = dma_get_sgtable_attrs(priv->dma_dev, sgt, mtk_gem->cookie,
|
|
mtk_gem->dma_addr, obj->size,
|
|
mtk_gem->dma_attrs);
|
|
if (ret) {
|
|
DRM_ERROR("failed to allocate sgt, %d\n", ret);
|
|
kfree(sgt);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
return sgt;
|
|
}
|
|
|
|
struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev,
|
|
struct dma_buf_attachment *attach, struct sg_table *sg)
|
|
{
|
|
struct mtk_drm_gem_obj *mtk_gem;
|
|
int ret;
|
|
struct scatterlist *s;
|
|
unsigned int i;
|
|
dma_addr_t expected;
|
|
|
|
mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size);
|
|
|
|
if (IS_ERR(mtk_gem))
|
|
return ERR_PTR(PTR_ERR(mtk_gem));
|
|
|
|
expected = sg_dma_address(sg->sgl);
|
|
for_each_sg(sg->sgl, s, sg->nents, i) {
|
|
if (sg_dma_address(s) != expected) {
|
|
DRM_ERROR("sg_table is not contiguous");
|
|
ret = -EINVAL;
|
|
goto err_gem_free;
|
|
}
|
|
expected = sg_dma_address(s) + sg_dma_len(s);
|
|
}
|
|
|
|
mtk_gem->dma_addr = sg_dma_address(sg->sgl);
|
|
mtk_gem->sg = sg;
|
|
|
|
return &mtk_gem->base;
|
|
|
|
err_gem_free:
|
|
kfree(mtk_gem);
|
|
return ERR_PTR(ret);
|
|
}
|