mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
b80328be53
Setting si_code to 0 results in a userspace seeing an si_code of 0.
This is the same si_code as SI_USER. Posix and common sense requires
that SI_USER not be a signal specific si_code. As such this use of 0
for the si_code is a pretty horribly broken ABI.
Further use of si_code == 0 guaranteed that copy_siginfo_to_user saw a
value of __SI_KILL and now sees a value of SIL_KILL with the result
hat uid and pid fields are copied and which might copying the si_addr
field by accident but certainly not by design. Making this a very
flakey implementation.
Utilizing FPE_FIXME siginfo_layout will now return SIL_FAULT and the
appropriate fields will reliably be copied.
Possible ABI fixes includee:
- Send the signal without siginfo
- Don't generate a signal
- Possibly assign and use an appropriate si_code
- Don't handle cases which can't happen
Cc: James Hogan <james.hogan@imgtec.com>
Cc: linux-metag@vger.kernel.org
Ref: ac919f0883 ("metag: Traps")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
16 lines
309 B
C
16 lines
309 B
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
#ifndef _METAG_SIGINFO_H
|
|
#define _METAG_SIGINFO_H
|
|
|
|
#define __ARCH_SI_TRAPNO
|
|
|
|
#include <asm-generic/siginfo.h>
|
|
|
|
/*
|
|
* SIGFPE si_codes
|
|
*/
|
|
#ifdef __KERNEL__
|
|
#define FPE_FIXME 0 /* Broken dup of SI_USER */
|
|
#endif /* __KERNEL__ */
|
|
|
|
#endif
|