linux-stable/drivers/s390
Steffen Maier e3c914631c scsi: zfcp: drop default switch case which might paper over missing case
[ Upstream commit 0c902936e5 ]

This was introduced with v4.18 commit 8c3d20aada ("scsi: zfcp: fix
missing REC trigger trace for all objects in ERP_FAILED") but would now
suppress helpful -Wswitch compiler warnings when building with W=1 such as
the following forced example:

drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_handle_failed':
drivers/s390/scsi/zfcp_erp.c:126:2: warning: enumeration value 'ZFCP_ERP_ACTION_REOPEN_PORT_FORCED' not handled in switch [-Wswitch]
  switch (want) {
  ^~~~~~

But then again, only with W=1 we would notice unhandled enum cases.
Without the default cases and a missed unhandled enum case, the code might
perform unforeseen things we might not want...

As of today, we never run through the removed default case, so removing it
is no functional change.  In the future, we never should run through a
default case but introduce the necessary specific case(s) to handle new
functionality.

Signed-off-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-12-17 20:37:53 +01:00
..
block s390/dasd: fix endless loop after read unit address configuration 2019-08-06 19:05:26 +02:00
char s390/3270: fix lockdep false positive on view->lock 2019-05-16 19:42:21 +02:00
cio s390/cio: exclude subchannels with no parent from pseudo check 2019-10-11 18:18:28 +02:00
crypto s390: zcrypt: initialize variables before_use 2019-05-31 06:47:28 -07:00
net s390/qeth: invoke softirqs after napi_schedule() 2019-11-20 18:00:04 +01:00
scsi scsi: zfcp: drop default switch case which might paper over missing case 2019-12-17 20:37:53 +01:00
virtio s390/virtio: handle find on invalid queue gracefully 2019-03-23 14:35:20 +01:00
Makefile