Xiaodong Xu 3bbb8eec91 xfrm: release device reference for invalid state ... [ Upstream commit 4944a4b107 ] An ESP packet could be decrypted in async mode if the input handler for this packet returns -EINPROGRESS in xfrm_input(). At this moment the device reference in skb is held. Later xfrm_input() will be invoked again to resume the processing. If the transform state is still valid it would continue to release the device reference and there won't be a problem; however if the transform state is not valid when async resumption happens, the packet will be dropped while the device reference is still being held. When the device is deleted for some reason and the reference to this device is not properly released, the kernel will keep logging like: unregister_netdevice: waiting for ppp2 to become free. Usage count = 1 The issue is observed when running IPsec traffic over a PPPoE device based on a bridge interface. By terminating the PPPoE connection on the server end for multiple times, the PPPoE device on the client side will eventually get stuck on the above warning message. This patch will check the async mode first and continue to release device reference in async resumption, before it is dropped due to invalid state. v2: Do not assign address family from outer_mode in the transform if the state is invalid v3: Release device reference in the error path instead of jumping to resume Fixes: 4ce3dbe397 ("xfrm: Fix xfrm_input() to verify state is valid when (encap_type < 0)") Signed-off-by: Xiaodong Xu <stid.smth@gmail.com> Reported-by: Bo Chen <chenborfc@163.com> Tested-by: Bo Chen <chenborfc@163.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-12-17 20:37:28 +01:00
..
Kconfig	ipsec: select crypto ciphers for xfrm_algo	2019-07-31 07:28:27 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_algo.c	xfrm: use IS_ENABLED() instead of checking for built-in or module	2016-09-10 21:19:11 -07:00
xfrm_device.c	xfrm: policy: remove pcpu policy cache	2019-08-25 10:50:29 +02:00
xfrm_hash.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_hash.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_input.c	xfrm: release device reference for invalid state	2019-12-17 20:37:28 +01:00
xfrm_ipcomp.c	net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()	2018-04-08 14:26:29 +02:00
xfrm_output.c	xfrm: Fix error return code in xfrm_output_one()	2019-01-13 10:00:57 +01:00
xfrm_policy.c	xfrm: policy: remove pcpu policy cache	2019-08-25 10:50:29 +02:00
xfrm_proc.c	proc: Reduce cache miss in xfrm_statistics_seq_show	2016-09-30 01:50:45 -04:00
xfrm_replay.c	xfrm: Fix ESN sequence number handling for IPsec GSO packets.	2018-05-30 07:52:08 +02:00
xfrm_state.c	xfrm: Fix memleak on xfrm state destroy	2019-12-05 15:38:10 +01:00
xfrm_sysctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_user.c	xfrm: clean up xfrm protocol checks	2019-09-16 08:20:44 +02:00