Chao Yu 0d2d6857db f2fs: fix to set/clear I_LINKABLE under i_lock ... [ Upstream commit 46085f37fc ] fsstress + fault injection test case reports a warning message as below: WARNING: CPU: 13 PID: 6226 at fs/inode.c:361 inc_nlink+0x32/0x40 Call Trace: f2fs_init_inode_metadata+0x25c/0x4a0 [f2fs] f2fs_add_inline_entry+0x153/0x3b0 [f2fs] f2fs_add_dentry+0x75/0x80 [f2fs] f2fs_do_add_link+0x108/0x160 [f2fs] f2fs_rename2+0x6ab/0x14f0 [f2fs] vfs_rename+0x70c/0x940 do_renameat2+0x4d8/0x4f0 __x64_sys_renameat2+0x4b/0x60 do_syscall_64+0x33/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Following race case can cause this: Thread A Kworker - f2fs_rename - f2fs_create_whiteout - __f2fs_tmpfile - f2fs_i_links_write - f2fs_mark_inode_dirty_sync - mark_inode_dirty_sync - writeback_single_inode - __writeback_single_inode - spin_lock(&inode->i_lock) - inode->i_state |= I_LINKABLE - inode->i_state &= ~dirty - spin_unlock(&inode->i_lock) - f2fs_add_link - f2fs_do_add_link - f2fs_add_dentry - f2fs_add_inline_entry - f2fs_init_inode_metadata - f2fs_i_links_write - inc_nlink - WARN_ON(!(inode->i_state & I_LINKABLE)) Fix to add i_lock to avoid i_state update race condition. Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-03-07 12:34:12 +01:00
..
acl.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
acl.h	f2fs: Use the correct style for SPDX License Identifier	2020-05-08 06:55:55 -07:00
checkpoint.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
compress.c	f2fs: compress: fix potential deadlock	2021-03-04 11:37:44 +01:00
data.c	f2fs: fix a wrong condition in __submit_bio	2021-03-04 11:37:46 +01:00
debug.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
dir.c	f2fs-for-5.10-rc1	2020-10-16 15:14:43 -07:00
extent_cache.c	f2fs: support 64-bits key in f2fs rb-tree node entry	2020-09-10 14:03:30 -07:00
f2fs.h	f2fs: compress: fix potential deadlock	2021-03-04 11:37:44 +01:00
file.c	f2fs: enforce the immutable flag on open files	2021-03-04 11:38:43 +01:00
gc.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
gc.h	f2fs: support age threshold based garbage collection	2020-09-11 11:11:15 -07:00
hash.c	f2fs-for-5.8-rc1	2020-06-09 11:28:59 -07:00
inline.c	f2fs: fix to avoid inconsistent quota data	2021-03-04 11:37:46 +01:00
inode.c	f2fs: fix to set SBI_NEED_FSCK flag for inconsistent inode	2020-10-09 10:29:31 -07:00
Kconfig	f2fs: compress: support lzo-rle compress algorithm	2020-05-11 20:36:46 -07:00
Makefile	f2fs: support data compression	2020-01-17 16:48:07 -08:00
namei.c	f2fs: fix to set/clear I_LINKABLE under i_lock	2021-03-07 12:34:12 +01:00
node.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
node.h	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
recovery.c	f2fs: fix error path in do_recover_data()	2020-07-08 10:11:19 -07:00
segment.c	f2fs: init dirty_secmap incorrectly	2020-12-26 16:02:42 +01:00
segment.h	f2fs: handle unallocated section and zone on pinned/atgc	2021-03-07 12:34:12 +01:00
shrinker.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
super.c	f2fs: flush data when enabling checkpoint back	2021-03-04 11:38:43 +01:00
sysfs.c	f2fs: wait for sysfs kobject removal before freeing f2fs_sb_info	2020-10-14 13:23:30 -07:00
trace.c	f2fs: do not use mutex lock in atomic context	2019-03-05 19:58:06 -08:00
trace.h	f2fs: Use the correct style for SPDX License Identifier	2020-05-08 06:55:55 -07:00
verity.c	mm/readahead: make page_cache_ra_unbounded take a readahead_control	2020-10-16 11:11:16 -07:00
xattr.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
xattr.h	f2fs: code cleanup by removing ifdef macro surrounding	2020-05-26 18:56:10 -07:00