mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 00:39:48 +00:00
d8914002a0
CRC enabled filesystems fail log recovery with 100% reliability on xfstests xfs/085 with the following failure: XFS (vdb): Mounting Filesystem XFS (vdb): Starting recovery (logdev: internal) XFS (vdb): Corruption detected. Unmount and run xfs_repair XFS (vdb): bad inode magic/vsn daddr 144 #0 (magic=0) XFS: Assertion failed: 0, file: fs/xfs/xfs_inode_buf.c, line: 95 The problem is that the inode buffer has not been recovered before the readahead on the inode buffer is issued. The checkpoint being recovered actually allocates the inode chunk we are doing readahead from, so what comes from disk during readahead is essentially random and the verifier barfs on it. This inode buffer readahead problem affects non-crc filesystems, too, but xfstests does not trigger it at all on such configurations.... Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Ben Myers <bpm@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
53 lines
1.8 KiB
C
53 lines
1.8 KiB
C
/*
|
|
* Copyright (c) 2000-2003,2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it would be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#ifndef __XFS_INODE_BUF_H__
|
|
#define __XFS_INODE_BUF_H__
|
|
|
|
struct xfs_inode;
|
|
struct xfs_dinode;
|
|
struct xfs_icdinode;
|
|
|
|
/*
|
|
* Inode location information. Stored in the inode and passed to
|
|
* xfs_imap_to_bp() to get a buffer and dinode for a given inode.
|
|
*/
|
|
struct xfs_imap {
|
|
xfs_daddr_t im_blkno; /* starting BB of inode chunk */
|
|
ushort im_len; /* length in BBs of inode chunk */
|
|
ushort im_boffset; /* inode offset in block in bytes */
|
|
};
|
|
|
|
int xfs_imap_to_bp(struct xfs_mount *, struct xfs_trans *,
|
|
struct xfs_imap *, struct xfs_dinode **,
|
|
struct xfs_buf **, uint, uint);
|
|
int xfs_iread(struct xfs_mount *, struct xfs_trans *,
|
|
struct xfs_inode *, uint);
|
|
void xfs_dinode_calc_crc(struct xfs_mount *, struct xfs_dinode *);
|
|
void xfs_dinode_to_disk(struct xfs_dinode *,
|
|
struct xfs_icdinode *);
|
|
|
|
#if defined(DEBUG)
|
|
void xfs_inobp_check(struct xfs_mount *, struct xfs_buf *);
|
|
#else
|
|
#define xfs_inobp_check(mp, bp)
|
|
#endif /* DEBUG */
|
|
|
|
extern const struct xfs_buf_ops xfs_inode_buf_ops;
|
|
extern const struct xfs_buf_ops xfs_inode_buf_ra_ops;
|
|
|
|
#endif /* __XFS_INODE_BUF_H__ */
|