mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
0bf048abeb
A change to the usb gadget core allowed certain API functions to be part of a loadable module, which breaks having emxx_udc built-in: drivers/staging/built-in.o: In function `nbu2ss_drv_probe': (.text+0x2428): undefined reference to `usb_ep_set_maxpacket_limit' The original patch already fixed tons of other cases that have the added dependency but apparently missed this one that now appears in an ARM allmodconfig build. This patch makes the symbol "tristate", which lets the Kconfig dependency tracking handle it correctly. To make the module actually usable, I also revert0af61e66ee
("drivers/staging: make emxx_udc.c explicitly non-modular"), which Paul Gortmaker added after noticing that the Kconfig symbol was 'bool'. Compared to the original version however, I leave out the '__exit' annotation on the remove callback, as Paul pointed out that this was incorrect. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes:5a8d651a2b
("usb: gadget: move gadget API functions to udc-core") Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 lines
434 B
Text
10 lines
434 B
Text
config USB_EMXX
|
|
tristate "EMXX USB Function Device Controller"
|
|
depends on USB_GADGET && (ARCH_SHMOBILE || (ARM && COMPILE_TEST))
|
|
help
|
|
The Emma Mobile series of SoCs from Renesas Electronics and
|
|
former NEC Electronics include USB Function hardware.
|
|
|
|
Say "y" to link the driver statically, or "m" to build a
|
|
dynamically linked module called "emxx_udc" and force all
|
|
gadget drivers to also be dynamically linked.
|