linux-stable/drivers/net/hyperv
Haiyang Zhang a8c1f2af77 hv_netvsc: Fix unwanted wakeup in netvsc_attach()
commit f6f13c125e upstream.

When netvsc_attach() is called by operations like changing MTU, etc.,
an extra wakeup may happen while netvsc_attach() calling
rndis_filter_device_add() which sends rndis messages when queue is
stopped in netvsc_detach(). The completion message will wake up queue 0.

We can reproduce the issue by changing MTU etc., then the wake_queue
counter from "ethtool -S" will increase beyond stop_queue counter:
     stop_queue: 0
     wake_queue: 1
The issue causes queue wake up, and counter increment, no other ill
effects in current code. So we didn't see any network problem for now.

To fix this, initialize tx_disable to true, and set it to false when
the NIC is ready to be attached or registered.

Fixes: 7b2ee50c0c ("hv_netvsc: common detach logic")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-03-05 16:42:19 +01:00
..
hyperv_net.h hv_netvsc: Fix offset usage in netvsc_send_table() 2020-01-27 14:51:20 +01:00
Kconfig hv_netvsc: drop common code until callback model fixed 2018-06-12 15:22:28 -07:00
Makefile
netvsc.c hv_netvsc: Fix unwanted wakeup in netvsc_attach() 2020-03-05 16:42:19 +01:00
netvsc_drv.c hv_netvsc: Fix unwanted wakeup in netvsc_attach() 2020-03-05 16:42:19 +01:00
netvsc_trace.c
netvsc_trace.h
rndis_filter.c hv_netvsc: Fix memory leak when removing rndis device 2020-01-23 08:21:34 +01:00