Giovanni Cabiddu 3dd998f78c crypto: qat - fix deadlock in backlog processing ... [ Upstream commit 203b01001c ] If a request has the flag CRYPTO_TFM_REQ_MAY_BACKLOG set, the function qat_alg_send_message_maybacklog(), enqueues it in a backlog list if either (1) there is already at least one request in the backlog list, or (2) the HW ring is nearly full or (3) the enqueue to the HW ring fails. If an interrupt occurs right before the lock in qat_alg_backlog_req() is taken and the backlog queue is being emptied, then there is no request in the HW queues that can trigger a subsequent interrupt that can clear the backlog queue. In addition subsequent requests are enqueued to the backlog list and not sent to the hardware. Fix it by holding the lock while taking the decision if the request needs to be included in the backlog queue or not. This synchronizes the flow with the interrupt handler that drains the backlog queue. For performance reasons, the logic has been changed to try to enqueue first without holding the lock. Fixes: 3868238397 ("crypto: qat - add backlog mechanism") Reported-by: Mikulas Patocka <mpatocka@redhat.com> Closes: https://lore.kernel.org/all/af9581e2-58f9-cc19-428f-6f18f1f83d54@redhat.com/T/ Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> Reviewed-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-11-20 11:52:07 +01:00
..
qat_4xxx	crypto: qat - fix error return code in adf_probe	2022-12-31 13:32:36 +01:00
qat_c3xxx	crypto: qat - fix ETR sources enabled by default on GEN2 devices	2022-04-15 16:34:26 +08:00
qat_c3xxxvf	crypto: qat - config VFs based on ring-to-svc mapping	2021-12-24 14:18:27 +11:00
qat_c62x	crypto: qat - fix ETR sources enabled by default on GEN2 devices	2022-04-15 16:34:26 +08:00
qat_c62xvf	crypto: qat - config VFs based on ring-to-svc mapping	2021-12-24 14:18:27 +11:00
qat_common	crypto: qat - fix deadlock in backlog processing	2023-11-20 11:52:07 +01:00
qat_dh895xcc	crypto: qat - replace disable_vf2pf_interrupts()	2022-04-15 16:34:27 +08:00
qat_dh895xccvf	crypto: qat - config VFs based on ring-to-svc mapping	2021-12-24 14:18:27 +11:00
Kconfig	crypto: qat - Removes the x86 dependency on the QAT drivers	2022-06-24 17:12:29 +08:00
Makefile	crypto: qat - add qat_4xxx driver	2020-11-20 14:45:34 +11:00