3a2ba42cbd
The bitops compile-time optimization series revealed one more
problem in olpc-xo1-sci.c:send_ebook_state(), resulted in GCC
warnings:
arch/x86/platform/olpc/olpc-xo1-sci.c: In function 'send_ebook_state':
arch/x86/platform/olpc/olpc-xo1-sci.c:83:63: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
83 | if (!!test_bit(SW_TABLET_MODE, ebook_switch_idev->sw) == state)
| ^~
arch/x86/platform/olpc/olpc-xo1-sci.c:83:13: note: add parentheses around left hand side expression to silence this warning
Despite this code working as intended, this redundant double
negation of boolean value, together with comparing to `char`
with no explicit conversion to bool, makes compilers think
the author made some unintentional logical mistakes here.
Make it the other way around and negate the char instead
to silence the warnings.
Fixes:
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| olpc-xo1-pm.c | ||
| olpc-xo1-rtc.c | ||
| olpc-xo1-sci.c | ||
| olpc-xo15-sci.c | ||
| olpc.c | ||
| olpc_dt.c | ||
| olpc_ofw.c | ||
| xo1-wakeup.S | ||