mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
![Christian Brauner](/assets/img/avatar_default.png)
Convert to struct mnt_idmap.
Last cycle we merged the necessary infrastructure in
256c8aed2b
("fs: introduce dedicated idmap type for mounts").
This is just the conversion to struct mnt_idmap.
Currently we still pass around the plain namespace that was attached to a
mount. This is in general pretty convenient but it makes it easy to
conflate namespaces that are relevant on the filesystem with namespaces
that are relevent on the mount level. Especially for non-vfs developers
without detailed knowledge in this area this can be a potential source for
bugs.
Once the conversion to struct mnt_idmap is done all helpers down to the
really low-level helpers will take a struct mnt_idmap argument instead of
two namespace arguments. This way it becomes impossible to conflate the two
eliminating the possibility of any bugs. All of the vfs and all filesystems
only operate on struct mnt_idmap.
Acked-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
153 lines
3 KiB
C
153 lines
3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* linux/fs/hfs/attr.c
|
|
*
|
|
* (C) 2003 Ardis Technologies <roman@ardistech.com>
|
|
*
|
|
* Export hfs data via xattr
|
|
*/
|
|
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/xattr.h>
|
|
|
|
#include "hfs_fs.h"
|
|
#include "btree.h"
|
|
|
|
enum hfs_xattr_type {
|
|
HFS_TYPE,
|
|
HFS_CREATOR,
|
|
};
|
|
|
|
static int __hfs_setxattr(struct inode *inode, enum hfs_xattr_type type,
|
|
const void *value, size_t size, int flags)
|
|
{
|
|
struct hfs_find_data fd;
|
|
hfs_cat_rec rec;
|
|
struct hfs_cat_file *file;
|
|
int res;
|
|
|
|
if (!S_ISREG(inode->i_mode) || HFS_IS_RSRC(inode))
|
|
return -EOPNOTSUPP;
|
|
|
|
res = hfs_find_init(HFS_SB(inode->i_sb)->cat_tree, &fd);
|
|
if (res)
|
|
return res;
|
|
fd.search_key->cat = HFS_I(inode)->cat_key;
|
|
res = hfs_brec_find(&fd);
|
|
if (res)
|
|
goto out;
|
|
hfs_bnode_read(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
file = &rec.file;
|
|
|
|
switch (type) {
|
|
case HFS_TYPE:
|
|
if (size == 4)
|
|
memcpy(&file->UsrWds.fdType, value, 4);
|
|
else
|
|
res = -ERANGE;
|
|
break;
|
|
|
|
case HFS_CREATOR:
|
|
if (size == 4)
|
|
memcpy(&file->UsrWds.fdCreator, value, 4);
|
|
else
|
|
res = -ERANGE;
|
|
break;
|
|
}
|
|
|
|
if (!res)
|
|
hfs_bnode_write(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
out:
|
|
hfs_find_exit(&fd);
|
|
return res;
|
|
}
|
|
|
|
static ssize_t __hfs_getxattr(struct inode *inode, enum hfs_xattr_type type,
|
|
void *value, size_t size)
|
|
{
|
|
struct hfs_find_data fd;
|
|
hfs_cat_rec rec;
|
|
struct hfs_cat_file *file;
|
|
ssize_t res = 0;
|
|
|
|
if (!S_ISREG(inode->i_mode) || HFS_IS_RSRC(inode))
|
|
return -EOPNOTSUPP;
|
|
|
|
if (size) {
|
|
res = hfs_find_init(HFS_SB(inode->i_sb)->cat_tree, &fd);
|
|
if (res)
|
|
return res;
|
|
fd.search_key->cat = HFS_I(inode)->cat_key;
|
|
res = hfs_brec_find(&fd);
|
|
if (res)
|
|
goto out;
|
|
hfs_bnode_read(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
}
|
|
file = &rec.file;
|
|
|
|
switch (type) {
|
|
case HFS_TYPE:
|
|
if (size >= 4) {
|
|
memcpy(value, &file->UsrWds.fdType, 4);
|
|
res = 4;
|
|
} else
|
|
res = size ? -ERANGE : 4;
|
|
break;
|
|
|
|
case HFS_CREATOR:
|
|
if (size >= 4) {
|
|
memcpy(value, &file->UsrWds.fdCreator, 4);
|
|
res = 4;
|
|
} else
|
|
res = size ? -ERANGE : 4;
|
|
break;
|
|
}
|
|
|
|
out:
|
|
if (size)
|
|
hfs_find_exit(&fd);
|
|
return res;
|
|
}
|
|
|
|
static int hfs_xattr_get(const struct xattr_handler *handler,
|
|
struct dentry *unused, struct inode *inode,
|
|
const char *name, void *value, size_t size)
|
|
{
|
|
return __hfs_getxattr(inode, handler->flags, value, size);
|
|
}
|
|
|
|
static int hfs_xattr_set(const struct xattr_handler *handler,
|
|
struct mnt_idmap *idmap,
|
|
struct dentry *unused, struct inode *inode,
|
|
const char *name, const void *value, size_t size,
|
|
int flags)
|
|
{
|
|
if (!value)
|
|
return -EOPNOTSUPP;
|
|
|
|
return __hfs_setxattr(inode, handler->flags, value, size, flags);
|
|
}
|
|
|
|
static const struct xattr_handler hfs_creator_handler = {
|
|
.name = "hfs.creator",
|
|
.flags = HFS_CREATOR,
|
|
.get = hfs_xattr_get,
|
|
.set = hfs_xattr_set,
|
|
};
|
|
|
|
static const struct xattr_handler hfs_type_handler = {
|
|
.name = "hfs.type",
|
|
.flags = HFS_TYPE,
|
|
.get = hfs_xattr_get,
|
|
.set = hfs_xattr_set,
|
|
};
|
|
|
|
const struct xattr_handler *hfs_xattr_handlers[] = {
|
|
&hfs_creator_handler,
|
|
&hfs_type_handler,
|
|
NULL
|
|
};
|