Tom Rix eb2c6ca2db mwifiex: remove function pointer check ... clang static analyzer reports this problem init.c:739:8: warning: Called function pointer is null (null dereference) ret = adapter->if_ops.check_fw_status( ... ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In mwifiex_dnld_fw, there is an earlier check for check_fw_status(), The check was introduced for usb support at the same time this check in _mwifiex_fw_dpc() was made if (adapter->if_ops.dnld_fw) { ret = adapter->if_ops.dnld_fw(adapter, &fw); } else { ret = mwifiex_dnld_fw(adapter, &fw); } And a dnld_fw function initialized as part the usb's mwifiex_if_ops. The other instances of mwifiex_if_ops for pci and sdio both set check_fw_status. So the first check is not needed and can be removed. Fixes: 4daffe3543 ("mwifiex: add support for Marvell USB8797 chipset") Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200906200548.18053-1-trix@redhat.com		2020-09-09 10:30:28 +03:00
..
libertas	libertas: Fix misnaming for function param 'device'	2020-09-01 12:06:19 +03:00
libertas_tf	libertas_tf: Remove unused macro QOS_CONTROL_LEN	2020-09-01 16:18:35 +03:00
mwifiex	mwifiex: remove function pointer check	2020-09-09 10:30:28 +03:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
mwl8k.c	mwl8k: convert tasklets to use new tasklet_setup() API	2020-08-27 16:22:10 +03:00