Phillip Potter 87f600af59 staging: r8188eu: fix potential uninitialised variable use in rtw_pwrctrl.c ... Set ret to 0 (success) before entering first if statement, thereby assuring that even if the device is not associated and further checks pass, we do not then end up returning the uninitialized value of ret. This assignment is deliberately now directly before the if statement, in order to keep it clear what is happening as opposed to having it as an initialization at the start of the function like it was originally. Also add a comment to make it clear this first if block is currently a success path. As a side note, smatch does not trigger warnings for this change, for me at least. Within core/rtw_pwrctrl.c in the rtw_pwr_wakeup function, I previously dropped the initialization of 'ret' (int ret = 0;) in favour of its assignment which happens inside the first if block directly before its corresponding goto. This was the cause of this bug, and was introduced by: commit f3a76018dd ("staging: r8188eu: remove initializer from ret in rtw_pwr_wakeup"). Fixes: f3a76018dd ("staging: r8188eu: remove initializer from ret in rtw_pwr_wakeup") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220730235910.1145-1-phil@philpotter.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-07-31 10:07:45 +02:00
..
core	staging: r8188eu: fix potential uninitialised variable use in rtw_pwrctrl.c	2022-07-31 10:07:45 +02:00
hal	staging: r8188eu: make dump_chip_info() static	2022-07-27 08:45:22 +02:00
include	staging: r8188eu: make dump_chip_info() static	2022-07-27 08:45:22 +02:00
os_dep	staging: r8188eu: convert rtw_pwr_wakeup to correct error code semantics	2022-07-27 08:45:32 +02:00
Kconfig
Makefile	staging: r8188eu: make power sequences static	2022-06-27 13:51:08 +02:00
TODO