mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
643a654540
With David Woodhouse <dwmw2@infradead.org> select() presently has a habit of increasing the value of the user's `timeout' argument on return. We were writing back a timeout larger than the original. We _deliberately_ round up, since we know we must wait at _least_ as long as the caller asks us to. The patch adds a couple of helper functions for magnitude comparison of timespecs and of timevals, and uses them to prevent the various poll and select functions from returning a timeout which is larger than the one which was passed in. The patch also fixes a bug in compat_sys_pselect7(): it was adding the new timeout value to the old one and was returning that. It should just return the new timeout value. (We have various handy timespec/timeval-to-from-nsec conversion functions in time.h. But this code open-codes it all). Cc: "David S. Miller" <davem@davemloft.net> Cc: Andi Kleen <ak@muc.de> Cc: Ulrich Drepper <drepper@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: george anzinger <george@mvista.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
185 lines
5.1 KiB
C
185 lines
5.1 KiB
C
#ifndef _LINUX_COMPAT_H
|
|
#define _LINUX_COMPAT_H
|
|
/*
|
|
* These are the type definitions for the architecture specific
|
|
* syscall compatibility layer.
|
|
*/
|
|
#include <linux/config.h>
|
|
|
|
#ifdef CONFIG_COMPAT
|
|
|
|
#include <linux/stat.h>
|
|
#include <linux/param.h> /* for HZ */
|
|
#include <linux/sem.h>
|
|
|
|
#include <asm/compat.h>
|
|
#include <asm/siginfo.h>
|
|
|
|
#define compat_jiffies_to_clock_t(x) \
|
|
(((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
|
|
|
|
typedef __compat_uid32_t compat_uid_t;
|
|
typedef __compat_gid32_t compat_gid_t;
|
|
|
|
struct rusage;
|
|
|
|
struct compat_itimerspec {
|
|
struct compat_timespec it_interval;
|
|
struct compat_timespec it_value;
|
|
};
|
|
|
|
struct compat_utimbuf {
|
|
compat_time_t actime;
|
|
compat_time_t modtime;
|
|
};
|
|
|
|
struct compat_itimerval {
|
|
struct compat_timeval it_interval;
|
|
struct compat_timeval it_value;
|
|
};
|
|
|
|
struct compat_tms {
|
|
compat_clock_t tms_utime;
|
|
compat_clock_t tms_stime;
|
|
compat_clock_t tms_cutime;
|
|
compat_clock_t tms_cstime;
|
|
};
|
|
|
|
#define _COMPAT_NSIG_WORDS (_COMPAT_NSIG / _COMPAT_NSIG_BPW)
|
|
|
|
typedef struct {
|
|
compat_sigset_word sig[_COMPAT_NSIG_WORDS];
|
|
} compat_sigset_t;
|
|
|
|
extern int cp_compat_stat(struct kstat *, struct compat_stat __user *);
|
|
extern int get_compat_timespec(struct timespec *, const struct compat_timespec __user *);
|
|
extern int put_compat_timespec(const struct timespec *, struct compat_timespec __user *);
|
|
|
|
struct compat_iovec {
|
|
compat_uptr_t iov_base;
|
|
compat_size_t iov_len;
|
|
};
|
|
|
|
struct compat_rlimit {
|
|
compat_ulong_t rlim_cur;
|
|
compat_ulong_t rlim_max;
|
|
};
|
|
|
|
struct compat_rusage {
|
|
struct compat_timeval ru_utime;
|
|
struct compat_timeval ru_stime;
|
|
compat_long_t ru_maxrss;
|
|
compat_long_t ru_ixrss;
|
|
compat_long_t ru_idrss;
|
|
compat_long_t ru_isrss;
|
|
compat_long_t ru_minflt;
|
|
compat_long_t ru_majflt;
|
|
compat_long_t ru_nswap;
|
|
compat_long_t ru_inblock;
|
|
compat_long_t ru_oublock;
|
|
compat_long_t ru_msgsnd;
|
|
compat_long_t ru_msgrcv;
|
|
compat_long_t ru_nsignals;
|
|
compat_long_t ru_nvcsw;
|
|
compat_long_t ru_nivcsw;
|
|
};
|
|
|
|
extern int put_compat_rusage(const struct rusage *, struct compat_rusage __user *);
|
|
|
|
struct compat_siginfo;
|
|
|
|
extern asmlinkage long compat_sys_waitid(int, compat_pid_t,
|
|
struct compat_siginfo __user *, int,
|
|
struct compat_rusage __user *);
|
|
|
|
struct compat_dirent {
|
|
u32 d_ino;
|
|
compat_off_t d_off;
|
|
u16 d_reclen;
|
|
char d_name[256];
|
|
};
|
|
|
|
typedef union compat_sigval {
|
|
compat_int_t sival_int;
|
|
compat_uptr_t sival_ptr;
|
|
} compat_sigval_t;
|
|
|
|
#define COMPAT_SIGEV_PAD_SIZE ((SIGEV_MAX_SIZE/sizeof(int)) - 3)
|
|
|
|
typedef struct compat_sigevent {
|
|
compat_sigval_t sigev_value;
|
|
compat_int_t sigev_signo;
|
|
compat_int_t sigev_notify;
|
|
union {
|
|
compat_int_t _pad[COMPAT_SIGEV_PAD_SIZE];
|
|
compat_int_t _tid;
|
|
|
|
struct {
|
|
compat_uptr_t _function;
|
|
compat_uptr_t _attribute;
|
|
} _sigev_thread;
|
|
} _sigev_un;
|
|
} compat_sigevent_t;
|
|
|
|
|
|
long compat_sys_semctl(int first, int second, int third, void __user *uptr);
|
|
long compat_sys_msgsnd(int first, int second, int third, void __user *uptr);
|
|
long compat_sys_msgrcv(int first, int second, int msgtyp, int third,
|
|
int version, void __user *uptr);
|
|
long compat_sys_msgctl(int first, int second, void __user *uptr);
|
|
long compat_sys_shmat(int first, int second, compat_uptr_t third, int version,
|
|
void __user *uptr);
|
|
long compat_sys_shmctl(int first, int second, void __user *uptr);
|
|
long compat_sys_semtimedop(int semid, struct sembuf __user *tsems,
|
|
unsigned nsems, const struct compat_timespec __user *timeout);
|
|
asmlinkage long compat_sys_keyctl(u32 option,
|
|
u32 arg2, u32 arg3, u32 arg4, u32 arg5);
|
|
|
|
asmlinkage ssize_t compat_sys_readv(unsigned long fd,
|
|
const struct compat_iovec __user *vec, unsigned long vlen);
|
|
asmlinkage ssize_t compat_sys_writev(unsigned long fd,
|
|
const struct compat_iovec __user *vec, unsigned long vlen);
|
|
|
|
int compat_do_execve(char * filename, compat_uptr_t __user *argv,
|
|
compat_uptr_t __user *envp, struct pt_regs * regs);
|
|
|
|
asmlinkage long compat_sys_select(int n, compat_ulong_t __user *inp,
|
|
compat_ulong_t __user *outp, compat_ulong_t __user *exp,
|
|
struct compat_timeval __user *tvp);
|
|
|
|
#define BITS_PER_COMPAT_LONG (8*sizeof(compat_long_t))
|
|
|
|
#define BITS_TO_COMPAT_LONGS(bits) \
|
|
(((bits)+BITS_PER_COMPAT_LONG-1)/BITS_PER_COMPAT_LONG)
|
|
|
|
long compat_get_bitmap(unsigned long *mask, compat_ulong_t __user *umask,
|
|
unsigned long bitmap_size);
|
|
long compat_put_bitmap(compat_ulong_t __user *umask, unsigned long *mask,
|
|
unsigned long bitmap_size);
|
|
int copy_siginfo_from_user32(siginfo_t *to, struct compat_siginfo __user *from);
|
|
int copy_siginfo_to_user32(struct compat_siginfo __user *to, siginfo_t *from);
|
|
int get_compat_sigevent(struct sigevent *event,
|
|
const struct compat_sigevent __user *u_event);
|
|
|
|
static inline int compat_timeval_compare(struct compat_timeval *lhs,
|
|
struct compat_timeval *rhs)
|
|
{
|
|
if (lhs->tv_sec < rhs->tv_sec)
|
|
return -1;
|
|
if (lhs->tv_sec > rhs->tv_sec)
|
|
return 1;
|
|
return lhs->tv_usec - rhs->tv_usec;
|
|
}
|
|
|
|
static inline int compat_timespec_compare(struct compat_timespec *lhs,
|
|
struct compat_timespec *rhs)
|
|
{
|
|
if (lhs->tv_sec < rhs->tv_sec)
|
|
return -1;
|
|
if (lhs->tv_sec > rhs->tv_sec)
|
|
return 1;
|
|
return lhs->tv_nsec - rhs->tv_nsec;
|
|
}
|
|
|
|
#endif /* CONFIG_COMPAT */
|
|
#endif /* _LINUX_COMPAT_H */
|