linux-stable/net/core
Ido Schimmel 88cfd542f4 rtnetlink: Fix regression in bridge VLAN configuration
[ Upstream commit d2e381c496 ]

Cited commit started returning errors when notification info is not
filled by the bridge driver, resulting in the following regression:

 # ip link add name br1 type bridge vlan_filtering 1
 # bridge vlan add dev br1 vid 555 self pvid untagged
 RTNETLINK answers: Invalid argument

As long as the bridge driver does not fill notification info for the
bridge device itself, an empty notification should not be considered as
an error. This is explained in commit 59ccaaaa49 ("bridge: dont send
notification when skb->len == 0 in rtnl_bridge_notify").

Fix by removing the error and add a comment to avoid future bugs.

Fixes: a8db57c1d2 ("rtnetlink: Fix missing error code in rtnl_bridge_notify()")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-06-30 08:48:49 -04:00
..
datagram.c net: use skb_queue_empty_lockless() in busy poll contexts 2019-11-10 11:25:35 +01:00
dev.c can: dev: Move device back to init netns on owning netns delete 2021-03-30 14:40:12 +02:00
dev_addr_lists.c
dev_ioctl.c
devlink.c devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill() 2020-11-24 13:05:36 +01:00
drop_monitor.c drop_monitor: work around gcc-10 stringop-overflow warning 2020-05-20 08:17:05 +02:00
dst.c
dst_cache.c
ethtool.c ethtool: reduce stack usage with clang 2020-01-17 19:45:40 +01:00
fib_notifier.c
fib_rules.c fib: Return the correct errno code 2021-06-30 08:48:47 -04:00
filter.c bpf: Set mac_len in bpf_skb_change_head 2021-06-03 08:36:24 +02:00
flow_dissector.c net: dsa: fix flow dissection on Tx path 2019-12-21 10:47:31 +01:00
gen_estimator.c net_sched: gen_estimator: support large ewma log 2021-02-07 14:47:40 +01:00
gen_stats.c
gro_cells.c
hwbm.c
link_watch.c
lwt_bpf.c
lwtunnel.c
Makefile
neighbour.c neighbour: Disregard DEAD dst in neigh_update 2021-04-28 12:08:40 +02:00
net-procfs.c
net-sysfs.c net-sysfs: take the rtnl lock when accessing xps_cpus_map and num_tc 2021-01-12 20:09:09 +01:00
net-sysfs.h
net-traces.c
net_namespace.c net/net_namespace: Check the return value of register_pernet_subsys() 2019-12-05 15:37:48 +01:00
netclassid_cgroup.c cgroup, netclassid: remove double cond_resched 2020-05-10 10:29:03 +02:00
netevent.c
netpoll.c net: Have netpoll bring-up DSA management interface 2020-11-24 13:05:39 +01:00
netprio_cgroup.c netprio_cgroup: Fix unlimited memory leak of v2 cgroups 2020-05-20 08:17:13 +02:00
pktgen.c pktgen: fix misuse of BUG_ON() in pktgen_thread_worker() 2021-03-07 11:27:44 +01:00
ptp_classifier.c
request_sock.c
rtnetlink.c rtnetlink: Fix regression in bridge VLAN configuration 2021-06-30 08:48:49 -04:00
scm.c
secure_seq.c
skbuff.c net: fix up truesize of cloned skb in skb_prepare_for_shift() 2021-03-07 11:27:43 +01:00
sock.c net/compat: Add missing sock updates for SCM_RIGHTS 2020-08-21 09:48:18 +02:00
sock_diag.c
sock_reuseport.c
stream.c tcp: make sure EPOLLOUT wont be missed 2019-09-06 10:20:50 +02:00
sysctl_net_core.c net, sysctl: Fix compiler warning when only cBPF is present 2020-01-04 13:59:59 +01:00
timestamping.c
tso.c
utils.c net: Fix skb->csum update in inet_proto_csum_replace16(). 2020-02-05 14:18:28 +00:00