linux-stable/drivers/net/ethernet/intel/igb
Vinicius Costa Gomes 900f1aee1b igb: Fix missing time sync events
[ Upstream commit ee14cc9ea1 ]

Fix "double" clearing of interrupts, which can cause external events
or timestamps to be missed.

The E1000_TSIRC Time Sync Interrupt Cause register can be cleared in two
ways, by either reading it or by writing '1' into the specific cause
bit. This is documented in section 8.16.1.

The following flow was used:
    1. read E1000_TSIRC into 'tsicr';
    2. handle the interrupts present into 'tsirc' and mark them in 'ack';
    3. write 'ack' into E1000_TSICR;

As both (1) and (3) will clear the interrupt cause, if the same
interrupt happens again between (1) and (3) it will be ignored,
causing events to be missed.

Remove the extra clear in (3).

Fixes: 00c65578b4 ("igb: enable internal PPS for the i210")
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-03-26 18:16:53 -04:00
..
e1000_82575.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_82575.h
e1000_defines.h igb: Remove duplicate defines 2022-06-09 10:05:31 -07:00
e1000_hw.h
e1000_i210.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_i210.h
e1000_mac.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_mac.h
e1000_mbx.c
e1000_mbx.h
e1000_nvm.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_nvm.h
e1000_phy.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_phy.h
e1000_regs.h igb: Remove duplicate defines 2022-06-09 10:05:31 -07:00
igb.h igb: Fix string truncation warnings in igb_set_fw_version 2024-02-14 09:43:09 -08:00
igb_ethtool.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
igb_hwmon.c
igb_main.c igb: Fix missing time sync events 2024-03-26 18:16:53 -04:00
igb_ptp.c igb: extend PTP timestamp adjustments to i211 2024-02-28 20:16:48 -08:00
Makefile