mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Stephen Boyd](/assets/img/avatar_default.png)
Let's introduce a common library file for the physmap show function duplicated between three different keyboard drivers. This largely copies the code from cros_ec_keyb.c which has the most recent version of the show function, while using the vivaldi_data struct from the hid-vivaldi driver. This saves a small amount of space in an allyesconfig build. $ ./scripts/bloat-o-meter vmlinux.before vmlinux.after add/remove: 3/0 grow/shrink: 2/3 up/down: 412/-720 (-308) Function old new delta vivaldi_function_row_physmap_show - 292 +292 _sub_I_65535_1 1057564 1057616 +52 _sub_D_65535_0 1057564 1057616 +52 e843419@49f2_00062737_9b04 - 8 +8 e843419@20f6_0002a34d_35bc - 8 +8 atkbd_parse_fwnode_data 480 472 -8 atkbd_do_show_function_row_physmap 316 76 -240 function_row_physmap_show 620 148 -472 Total: Before=285581925, After=285581617, chg -0.00% Signed-off-by: Stephen Boyd <swboyd@chromium.org> Tested-by: Stephen Boyd <swboyd@chromium.org> # coachz, wormdingler Link: https://lore.kernel.org/r/20220228075446.466016-3-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
39 lines
1,000 B
C
39 lines
1,000 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Helpers for ChromeOS Vivaldi keyboard function row mapping
|
|
*
|
|
* Copyright (C) 2022 Google, Inc
|
|
*/
|
|
|
|
#include <linux/export.h>
|
|
#include <linux/input/vivaldi-fmap.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/types.h>
|
|
|
|
/**
|
|
* vivaldi_function_row_physmap_show - Print vivaldi function row physmap attribute
|
|
* @data: The vivaldi function row map
|
|
* @buf: Buffer to print the function row phsymap to
|
|
*/
|
|
ssize_t vivaldi_function_row_physmap_show(const struct vivaldi_data *data,
|
|
char *buf)
|
|
{
|
|
ssize_t size = 0;
|
|
int i;
|
|
const u32 *physmap = data->function_row_physmap;
|
|
|
|
if (!data->num_function_row_keys)
|
|
return 0;
|
|
|
|
for (i = 0; i < data->num_function_row_keys; i++)
|
|
size += scnprintf(buf + size, PAGE_SIZE - size,
|
|
"%s%02X", size ? " " : "", physmap[i]);
|
|
if (size)
|
|
size += scnprintf(buf + size, PAGE_SIZE - size, "\n");
|
|
|
|
return size;
|
|
}
|
|
EXPORT_SYMBOL_GPL(vivaldi_function_row_physmap_show);
|
|
|
|
MODULE_LICENSE("GPL");
|