mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
![Bartosz Golaszewski](/assets/img/avatar_default.png)
rtc_register_device() is a managed interface but it doesn't use devres by itself - instead it marks an rtc_device as "registered" and the devres callback for devm_rtc_allocate_device() takes care of resource release. This doesn't correspond with the design behind devres where managed structures should not be aware of being managed. The correct solution here is to register a separate devres callback for unregistering the device. While at it: rename rtc_register_device() to devm_rtc_register_device() and add it to the list of managed interfaces in devres.rst. This way we can avoid any potential confusion of driver developers who may expect there to exist a corresponding unregister function. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl
60 lines
1.2 KiB
C
60 lines
1.2 KiB
C
/* rtc-starfire.c: Starfire platform RTC driver.
|
|
*
|
|
* Author: David S. Miller
|
|
* License: GPL
|
|
*
|
|
* Copyright (C) 2008 David S. Miller <davem@davemloft.net>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/rtc.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <asm/oplib.h>
|
|
|
|
static u32 starfire_get_time(void)
|
|
{
|
|
static char obp_gettod[32];
|
|
static u32 unix_tod;
|
|
|
|
sprintf(obp_gettod, "h# %08x unix-gettod",
|
|
(unsigned int) (long) &unix_tod);
|
|
prom_feval(obp_gettod);
|
|
|
|
return unix_tod;
|
|
}
|
|
|
|
static int starfire_read_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
rtc_time64_to_tm(starfire_get_time(), tm);
|
|
return 0;
|
|
}
|
|
|
|
static const struct rtc_class_ops starfire_rtc_ops = {
|
|
.read_time = starfire_read_time,
|
|
};
|
|
|
|
static int __init starfire_rtc_probe(struct platform_device *pdev)
|
|
{
|
|
struct rtc_device *rtc;
|
|
|
|
rtc = devm_rtc_allocate_device(&pdev->dev);
|
|
if (IS_ERR(rtc))
|
|
return PTR_ERR(rtc);
|
|
|
|
rtc->ops = &starfire_rtc_ops;
|
|
rtc->range_max = U32_MAX;
|
|
|
|
platform_set_drvdata(pdev, rtc);
|
|
|
|
return devm_rtc_register_device(rtc);
|
|
}
|
|
|
|
static struct platform_driver starfire_rtc_driver = {
|
|
.driver = {
|
|
.name = "rtc-starfire",
|
|
},
|
|
};
|
|
|
|
builtin_platform_driver_probe(starfire_rtc_driver, starfire_rtc_probe);
|