mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
c2b0718f78
PCI AU88x0 driver code contains a lot of assignments in if condition, which is a bad coding style that may confuse readers and occasionally lead to bugs. This patch is merely for coding-style fixes. A potential real fix is about the PCI AGP bridge management refcount in addition while spotted out during conversions. Link: https://lore.kernel.org/r/20210608140540.17885-36-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
45 lines
1.1 KiB
C
45 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Vortex Mixer support.
|
|
*
|
|
* There is much more than just the AC97 mixer...
|
|
*
|
|
*/
|
|
|
|
#include <linux/time.h>
|
|
#include <linux/init.h>
|
|
#include <sound/core.h>
|
|
#include "au88x0.h"
|
|
|
|
static int remove_ctl(struct snd_card *card, const char *name)
|
|
{
|
|
struct snd_ctl_elem_id id;
|
|
memset(&id, 0, sizeof(id));
|
|
strcpy(id.name, name);
|
|
id.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
|
|
return snd_ctl_remove_id(card, &id);
|
|
}
|
|
|
|
static int snd_vortex_mixer(vortex_t *vortex)
|
|
{
|
|
struct snd_ac97_bus *pbus;
|
|
struct snd_ac97_template ac97;
|
|
int err;
|
|
static const struct snd_ac97_bus_ops ops = {
|
|
.write = vortex_codec_write,
|
|
.read = vortex_codec_read,
|
|
};
|
|
|
|
err = snd_ac97_bus(vortex->card, 0, &ops, NULL, &pbus);
|
|
if (err < 0)
|
|
return err;
|
|
memset(&ac97, 0, sizeof(ac97));
|
|
// Initialize AC97 codec stuff.
|
|
ac97.private_data = vortex;
|
|
ac97.scaps = AC97_SCAP_NO_SPDIF;
|
|
err = snd_ac97_mixer(pbus, &ac97, &vortex->codec);
|
|
vortex->isquad = ((vortex->codec == NULL) ? 0 : (vortex->codec->ext_id&0x80));
|
|
remove_ctl(vortex->card, "Master Mono Playback Volume");
|
|
remove_ctl(vortex->card, "Master Mono Playback Switch");
|
|
return err;
|
|
}
|