Juergen Gross 36c9b5929b xen: fix usage of pmd_populate in mremap for pv guests ... Commit 0881ace292 ("mm/mremap: use pmd/pud_poplulate to update page table entries") introduced a regression when running as Xen PV guest. Today pmd_populate() for Xen PV assumes that the PFN inserted is referencing a not yet used page table. In case of move_normal_pmd() this is not true, resulting in WARN splats like: [34321.304270] ------------[ cut here ]------------ [34321.304277] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 [34321.304288] Modules linked in: [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted 5.14.1-20210906-doflr-mac80211debug+ #1 [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807d416398 [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefdeadf00d [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff888006160cc0 [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12: 0000000000000000 [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15: 0000000000000001 [34321.304320] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlGS:0000000000000000 [34321.304322] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 0000000000000660 [34321.304326] Call Trace: [34321.304331] xen_alloc_pte+0x294/0x320 [34321.304334] move_pgt_entry+0x165/0x4b0 [34321.304339] move_page_tables+0x6fa/0x8d0 [34321.304342] move_vma.isra.44+0x138/0x500 [34321.304345] __x64_sys_mremap+0x296/0x410 [34321.304348] do_syscall_64+0x3a/0x80 [34321.304352] entry_SYSCALL_64_after_hwframe+0x44/0xae [34321.304355] RIP: 0033:0x7f507196301a [34321.304358] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 [34321.304360] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 [34321.304362] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507196301a [34321.304363] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506dc56000 [34321.304364] RBP: 0000000001a00000 R08: 0000000000000010 R09: 0000000000000004 [34321.304365] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506dc56060 [34321.304367] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205f950f30 [34321.304368] ---[ end trace a19885b78fe8f33e ]--- [34321.304370] 1 of 2 multicall(s) failed: cpu 0 [34321.304371] call 2: op=12297829382473034410 arg=[aaaaaaaaaaaaaaaa] result=-22 Fix that by modifying xen_alloc_ptpage() to only pin the page table in case it wasn't pinned already. Fixes: 0881ace292 ("mm/mremap: use pmd/pud_poplulate to update page table entries") Cc: <stable@vger.kernel.org> Reported-by: Sander Eikelenboom <linux@eikelenboom.it> Tested-by: Sander Eikelenboom <linux@eikelenboom.it> Signed-off-by: Juergen Gross <jgross@suse.com> Link: https://lore.kernel.org/r/20210908073640.11299-1-jgross@suse.com Signed-off-by: Juergen Gross <jgross@suse.com>		2021-09-15 08:42:04 +02:00
..
apic.c	x86/apic: Cleanup destination mode	2020-10-28 20:26:25 +01:00
debugfs.c	x86: xen: no need to check return value of debugfs_create functions	2019-06-03 15:49:07 +02:00
debugfs.h
efi.c	efi: x86/xen: switch to efi_get_secureboot_mode helper	2020-11-17 15:09:32 +01:00
enlighten.c	kernel.h: split out panic and oops helpers	2021-07-01 11:06:04 -07:00
enlighten_hvm.c	x86/xen: Don't register Xen IPIs when they aren't going to be used	2021-01-13 16:12:07 +01:00
enlighten_pv.c	xen: reset legacy rtc flag for PV domU	2021-09-15 08:42:03 +02:00
enlighten_pvh.c	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
grant-table.c	x86/xen: open code alloc_vm_area in arch_gnttab_valloc	2020-10-18 09:27:10 -07:00
irq.c	x86/pv: Rework arch_local_irq_restore() to not use popf	2021-02-10 12:36:45 +01:00
Kconfig	xen: Kconfig: remove X86_64 depends from XEN_512GB	2020-12-19 07:27:37 +01:00
Makefile	x86/xen: Support objtool validation in xen-asm.S	2021-01-26 11:33:01 -06:00
mmu.c	x86/xen: Add SPDX identifier in arch/x86/xen files	2018-09-03 16:50:33 +02:00
mmu.h	mm: update ptep_modify_prot_start/commit to take vm_area_struct as arg	2019-03-05 21:07:18 -08:00
mmu_hvm.c	x86/paravirt: Use a single ops structure	2018-09-03 16:50:35 +02:00
mmu_pv.c	xen: fix usage of pmd_populate in mremap for pv guests	2021-09-15 08:42:04 +02:00
multicalls.c	treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively	2019-04-09 14:19:06 +02:00
multicalls.h
p2m.c	xen: fix setting of max_pfn in shared_info	2021-08-30 11:55:36 +02:00
pci-swiotlb-xen.c	xen-swiotlb: split xen_swiotlb_init	2021-03-17 00:40:54 +00:00
platform-pci-unplug.c	x86: xen: platform-pci-unplug: use pr_err() and pr_warn() instead of raw printk()	2021-08-30 12:09:54 +02:00
pmu.c	Merge branch 'x86-cpu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 16:16:40 +01:00
pmu.h
setup.c	Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"	2021-03-24 18:33:36 -05:00
smp.c	xen/events: only register debug interrupt for 2-level events	2020-10-23 05:41:25 -05:00
smp.h
smp_hvm.c	x86/xen: fix 'nopvspin' build error	2021-01-18 07:22:20 +01:00
smp_pv.c	xen: remove stray preempt_disable() from PV AP startup code	2021-09-01 10:39:27 +02:00
spinlock.c	x86/xen: don't unbind uninitialized lock_kicker_irq	2020-11-09 07:43:45 -06:00
suspend.c	x86/xen: Zero MSR_IA32_SPEC_CTRL before suspend	2018-02-28 16:03:19 +01:00
suspend_hvm.c	xen: Move xen_setup_callback_vector() definition to include/xen/hvm.h	2020-06-11 15:15:19 +02:00
suspend_pv.c	locking/seqlock, headers: Untangle the spaghetti monster	2020-08-06 16:13:13 +02:00
time.c	x86/paravirt: Switch time pvops functions to use static_call()	2021-03-11 16:17:52 +01:00
trace.c
vga.c
xen-asm.S	objtool updates:	2021-02-23 09:56:13 -08:00
xen-head.S	x86/xen: Support objtool vmlinux.o validation in xen-head.S	2021-01-26 11:33:02 -06:00
xen-ops.h	x86/pv: Rework arch_local_irq_restore() to not use popf	2021-02-10 12:36:45 +01:00