mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Tadeusz Struk](/assets/img/avatar_default.png)
Syzbot reported slab-out-of-bounds read in exfat_clear_bitmap.
This was triggered by reproducer calling truncute with size 0,
which causes the following trace:
BUG: KASAN: slab-out-of-bounds in exfat_clear_bitmap+0x147/0x490 fs/exfat/balloc.c:174
Read of size 8 at addr ffff888115aa9508 by task syz-executor251/365
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack_lvl+0x1e2/0x24b lib/dump_stack.c:118
print_address_description+0x81/0x3c0 mm/kasan/report.c:233
__kasan_report mm/kasan/report.c:419 [inline]
kasan_report+0x1a4/0x1f0 mm/kasan/report.c:436
__asan_report_load8_noabort+0x14/0x20 mm/kasan/report_generic.c:309
exfat_clear_bitmap+0x147/0x490 fs/exfat/balloc.c:174
exfat_free_cluster+0x25a/0x4a0 fs/exfat/fatent.c:181
__exfat_truncate+0x99e/0xe00 fs/exfat/file.c:217
exfat_truncate+0x11b/0x4f0 fs/exfat/file.c:243
exfat_setattr+0xa03/0xd40 fs/exfat/file.c:339
notify_change+0xb76/0xe10 fs/attr.c:336
do_truncate+0x1ea/0x2d0 fs/open.c:65
Move the is_valid_cluster() helper from fatent.c to a common
header to make it reusable in other *.c files. And add is_valid_cluster()
to validate if cluster number is within valid range in exfat_clear_bitmap()
and exfat_set_bitmap().
Link: https://syzkaller.appspot.com/bug?id=50381fc73821ecae743b8cf24b4c9a04776f767c
Reported-by: syzbot+a4087e40b9c13aad7892@syzkaller.appspotmail.com
Fixes: 1e49a94cf7
("exfat: add bitmap operations")
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
350 lines
9.7 KiB
C
350 lines
9.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Copyright (C) 2012-2013 Samsung Electronics Co., Ltd.
|
|
*/
|
|
|
|
#include <linux/blkdev.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/buffer_head.h>
|
|
|
|
#include "exfat_raw.h"
|
|
#include "exfat_fs.h"
|
|
|
|
static const unsigned char free_bit[] = {
|
|
0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 4, 0, 1, 0, 2,/* 0 ~ 19*/
|
|
0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 5, 0, 1, 0, 2, 0, 1, 0, 3,/* 20 ~ 39*/
|
|
0, 1, 0, 2, 0, 1, 0, 4, 0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2,/* 40 ~ 59*/
|
|
0, 1, 0, 6, 0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 4,/* 60 ~ 79*/
|
|
0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 5, 0, 1, 0, 2,/* 80 ~ 99*/
|
|
0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 4, 0, 1, 0, 2, 0, 1, 0, 3,/*100 ~ 119*/
|
|
0, 1, 0, 2, 0, 1, 0, 7, 0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2,/*120 ~ 139*/
|
|
0, 1, 0, 4, 0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 5,/*140 ~ 159*/
|
|
0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 4, 0, 1, 0, 2,/*160 ~ 179*/
|
|
0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 6, 0, 1, 0, 2, 0, 1, 0, 3,/*180 ~ 199*/
|
|
0, 1, 0, 2, 0, 1, 0, 4, 0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2,/*200 ~ 219*/
|
|
0, 1, 0, 5, 0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0, 4,/*220 ~ 239*/
|
|
0, 1, 0, 2, 0, 1, 0, 3, 0, 1, 0, 2, 0, 1, 0 /*240 ~ 254*/
|
|
};
|
|
|
|
static const unsigned char used_bit[] = {
|
|
0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4, 1, 2, 2, 3,/* 0 ~ 19*/
|
|
2, 3, 3, 4, 2, 3, 3, 4, 3, 4, 4, 5, 1, 2, 2, 3, 2, 3, 3, 4,/* 20 ~ 39*/
|
|
2, 3, 3, 4, 3, 4, 4, 5, 2, 3, 3, 4, 3, 4, 4, 5, 3, 4, 4, 5,/* 40 ~ 59*/
|
|
4, 5, 5, 6, 1, 2, 2, 3, 2, 3, 3, 4, 2, 3, 3, 4, 3, 4, 4, 5,/* 60 ~ 79*/
|
|
2, 3, 3, 4, 3, 4, 4, 5, 3, 4, 4, 5, 4, 5, 5, 6, 2, 3, 3, 4,/* 80 ~ 99*/
|
|
3, 4, 4, 5, 3, 4, 4, 5, 4, 5, 5, 6, 3, 4, 4, 5, 4, 5, 5, 6,/*100 ~ 119*/
|
|
4, 5, 5, 6, 5, 6, 6, 7, 1, 2, 2, 3, 2, 3, 3, 4, 2, 3, 3, 4,/*120 ~ 139*/
|
|
3, 4, 4, 5, 2, 3, 3, 4, 3, 4, 4, 5, 3, 4, 4, 5, 4, 5, 5, 6,/*140 ~ 159*/
|
|
2, 3, 3, 4, 3, 4, 4, 5, 3, 4, 4, 5, 4, 5, 5, 6, 3, 4, 4, 5,/*160 ~ 179*/
|
|
4, 5, 5, 6, 4, 5, 5, 6, 5, 6, 6, 7, 2, 3, 3, 4, 3, 4, 4, 5,/*180 ~ 199*/
|
|
3, 4, 4, 5, 4, 5, 5, 6, 3, 4, 4, 5, 4, 5, 5, 6, 4, 5, 5, 6,/*200 ~ 219*/
|
|
5, 6, 6, 7, 3, 4, 4, 5, 4, 5, 5, 6, 4, 5, 5, 6, 5, 6, 6, 7,/*220 ~ 239*/
|
|
4, 5, 5, 6, 5, 6, 6, 7, 5, 6, 6, 7, 6, 7, 7, 8 /*240 ~ 255*/
|
|
};
|
|
|
|
/*
|
|
* Allocation Bitmap Management Functions
|
|
*/
|
|
static int exfat_allocate_bitmap(struct super_block *sb,
|
|
struct exfat_dentry *ep)
|
|
{
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
long long map_size;
|
|
unsigned int i, need_map_size;
|
|
sector_t sector;
|
|
|
|
sbi->map_clu = le32_to_cpu(ep->dentry.bitmap.start_clu);
|
|
map_size = le64_to_cpu(ep->dentry.bitmap.size);
|
|
need_map_size = ((EXFAT_DATA_CLUSTER_COUNT(sbi) - 1) / BITS_PER_BYTE)
|
|
+ 1;
|
|
if (need_map_size != map_size) {
|
|
exfat_err(sb, "bogus allocation bitmap size(need : %u, cur : %lld)",
|
|
need_map_size, map_size);
|
|
/*
|
|
* Only allowed when bogus allocation
|
|
* bitmap size is large
|
|
*/
|
|
if (need_map_size > map_size)
|
|
return -EIO;
|
|
}
|
|
sbi->map_sectors = ((need_map_size - 1) >>
|
|
(sb->s_blocksize_bits)) + 1;
|
|
sbi->vol_amap = kmalloc_array(sbi->map_sectors,
|
|
sizeof(struct buffer_head *), GFP_KERNEL);
|
|
if (!sbi->vol_amap)
|
|
return -ENOMEM;
|
|
|
|
sector = exfat_cluster_to_sector(sbi, sbi->map_clu);
|
|
for (i = 0; i < sbi->map_sectors; i++) {
|
|
sbi->vol_amap[i] = sb_bread(sb, sector + i);
|
|
if (!sbi->vol_amap[i]) {
|
|
/* release all buffers and free vol_amap */
|
|
int j = 0;
|
|
|
|
while (j < i)
|
|
brelse(sbi->vol_amap[j++]);
|
|
|
|
kfree(sbi->vol_amap);
|
|
sbi->vol_amap = NULL;
|
|
return -EIO;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int exfat_load_bitmap(struct super_block *sb)
|
|
{
|
|
unsigned int i, type;
|
|
struct exfat_chain clu;
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
|
|
exfat_chain_set(&clu, sbi->root_dir, 0, ALLOC_FAT_CHAIN);
|
|
while (clu.dir != EXFAT_EOF_CLUSTER) {
|
|
for (i = 0; i < sbi->dentries_per_clu; i++) {
|
|
struct exfat_dentry *ep;
|
|
struct buffer_head *bh;
|
|
|
|
ep = exfat_get_dentry(sb, &clu, i, &bh);
|
|
if (!ep)
|
|
return -EIO;
|
|
|
|
type = exfat_get_entry_type(ep);
|
|
if (type == TYPE_UNUSED)
|
|
break;
|
|
if (type != TYPE_BITMAP)
|
|
continue;
|
|
if (ep->dentry.bitmap.flags == 0x0) {
|
|
int err;
|
|
|
|
err = exfat_allocate_bitmap(sb, ep);
|
|
brelse(bh);
|
|
return err;
|
|
}
|
|
brelse(bh);
|
|
}
|
|
|
|
if (exfat_get_next_cluster(sb, &clu.dir))
|
|
return -EIO;
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
void exfat_free_bitmap(struct exfat_sb_info *sbi)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < sbi->map_sectors; i++)
|
|
__brelse(sbi->vol_amap[i]);
|
|
|
|
kfree(sbi->vol_amap);
|
|
}
|
|
|
|
int exfat_set_bitmap(struct inode *inode, unsigned int clu, bool sync)
|
|
{
|
|
int i, b;
|
|
unsigned int ent_idx;
|
|
struct super_block *sb = inode->i_sb;
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
|
|
if (!is_valid_cluster(sbi, clu))
|
|
return -EINVAL;
|
|
|
|
ent_idx = CLUSTER_TO_BITMAP_ENT(clu);
|
|
i = BITMAP_OFFSET_SECTOR_INDEX(sb, ent_idx);
|
|
b = BITMAP_OFFSET_BIT_IN_SECTOR(sb, ent_idx);
|
|
|
|
set_bit_le(b, sbi->vol_amap[i]->b_data);
|
|
exfat_update_bh(sbi->vol_amap[i], sync);
|
|
return 0;
|
|
}
|
|
|
|
void exfat_clear_bitmap(struct inode *inode, unsigned int clu, bool sync)
|
|
{
|
|
int i, b;
|
|
unsigned int ent_idx;
|
|
struct super_block *sb = inode->i_sb;
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
struct exfat_mount_options *opts = &sbi->options;
|
|
|
|
if (!is_valid_cluster(sbi, clu))
|
|
return;
|
|
|
|
ent_idx = CLUSTER_TO_BITMAP_ENT(clu);
|
|
i = BITMAP_OFFSET_SECTOR_INDEX(sb, ent_idx);
|
|
b = BITMAP_OFFSET_BIT_IN_SECTOR(sb, ent_idx);
|
|
|
|
clear_bit_le(b, sbi->vol_amap[i]->b_data);
|
|
exfat_update_bh(sbi->vol_amap[i], sync);
|
|
|
|
if (opts->discard) {
|
|
int ret_discard;
|
|
|
|
ret_discard = sb_issue_discard(sb,
|
|
exfat_cluster_to_sector(sbi, clu),
|
|
(1 << sbi->sect_per_clus_bits), GFP_NOFS, 0);
|
|
|
|
if (ret_discard == -EOPNOTSUPP) {
|
|
exfat_err(sb, "discard not supported by device, disabling");
|
|
opts->discard = 0;
|
|
}
|
|
}
|
|
}
|
|
|
|
/*
|
|
* If the value of "clu" is 0, it means cluster 2 which is the first cluster of
|
|
* the cluster heap.
|
|
*/
|
|
unsigned int exfat_find_free_bitmap(struct super_block *sb, unsigned int clu)
|
|
{
|
|
unsigned int i, map_i, map_b, ent_idx;
|
|
unsigned int clu_base, clu_free;
|
|
unsigned char k, clu_mask;
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
|
|
WARN_ON(clu < EXFAT_FIRST_CLUSTER);
|
|
ent_idx = CLUSTER_TO_BITMAP_ENT(clu);
|
|
clu_base = BITMAP_ENT_TO_CLUSTER(ent_idx & ~(BITS_PER_BYTE_MASK));
|
|
clu_mask = IGNORED_BITS_REMAINED(clu, clu_base);
|
|
|
|
map_i = BITMAP_OFFSET_SECTOR_INDEX(sb, ent_idx);
|
|
map_b = BITMAP_OFFSET_BYTE_IN_SECTOR(sb, ent_idx);
|
|
|
|
for (i = EXFAT_FIRST_CLUSTER; i < sbi->num_clusters;
|
|
i += BITS_PER_BYTE) {
|
|
k = *(sbi->vol_amap[map_i]->b_data + map_b);
|
|
if (clu_mask > 0) {
|
|
k |= clu_mask;
|
|
clu_mask = 0;
|
|
}
|
|
if (k < 0xFF) {
|
|
clu_free = clu_base + free_bit[k];
|
|
if (clu_free < sbi->num_clusters)
|
|
return clu_free;
|
|
}
|
|
clu_base += BITS_PER_BYTE;
|
|
|
|
if (++map_b >= sb->s_blocksize ||
|
|
clu_base >= sbi->num_clusters) {
|
|
if (++map_i >= sbi->map_sectors) {
|
|
clu_base = EXFAT_FIRST_CLUSTER;
|
|
map_i = 0;
|
|
}
|
|
map_b = 0;
|
|
}
|
|
}
|
|
|
|
return EXFAT_EOF_CLUSTER;
|
|
}
|
|
|
|
int exfat_count_used_clusters(struct super_block *sb, unsigned int *ret_count)
|
|
{
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
unsigned int count = 0;
|
|
unsigned int i, map_i = 0, map_b = 0;
|
|
unsigned int total_clus = EXFAT_DATA_CLUSTER_COUNT(sbi);
|
|
unsigned int last_mask = total_clus & BITS_PER_BYTE_MASK;
|
|
unsigned char clu_bits;
|
|
const unsigned char last_bit_mask[] = {0, 0b00000001, 0b00000011,
|
|
0b00000111, 0b00001111, 0b00011111, 0b00111111, 0b01111111};
|
|
|
|
total_clus &= ~last_mask;
|
|
for (i = 0; i < total_clus; i += BITS_PER_BYTE) {
|
|
clu_bits = *(sbi->vol_amap[map_i]->b_data + map_b);
|
|
count += used_bit[clu_bits];
|
|
if (++map_b >= (unsigned int)sb->s_blocksize) {
|
|
map_i++;
|
|
map_b = 0;
|
|
}
|
|
}
|
|
|
|
if (last_mask) {
|
|
clu_bits = *(sbi->vol_amap[map_i]->b_data + map_b);
|
|
clu_bits &= last_bit_mask[last_mask];
|
|
count += used_bit[clu_bits];
|
|
}
|
|
|
|
*ret_count = count;
|
|
return 0;
|
|
}
|
|
|
|
int exfat_trim_fs(struct inode *inode, struct fstrim_range *range)
|
|
{
|
|
unsigned int trim_begin, trim_end, count, next_free_clu;
|
|
u64 clu_start, clu_end, trim_minlen, trimmed_total = 0;
|
|
struct super_block *sb = inode->i_sb;
|
|
struct exfat_sb_info *sbi = EXFAT_SB(sb);
|
|
int err = 0;
|
|
|
|
clu_start = max_t(u64, range->start >> sbi->cluster_size_bits,
|
|
EXFAT_FIRST_CLUSTER);
|
|
clu_end = clu_start + (range->len >> sbi->cluster_size_bits) - 1;
|
|
trim_minlen = range->minlen >> sbi->cluster_size_bits;
|
|
|
|
if (clu_start >= sbi->num_clusters || range->len < sbi->cluster_size)
|
|
return -EINVAL;
|
|
|
|
if (clu_end >= sbi->num_clusters)
|
|
clu_end = sbi->num_clusters - 1;
|
|
|
|
mutex_lock(&sbi->bitmap_lock);
|
|
|
|
trim_begin = trim_end = exfat_find_free_bitmap(sb, clu_start);
|
|
if (trim_begin == EXFAT_EOF_CLUSTER)
|
|
goto unlock;
|
|
|
|
next_free_clu = exfat_find_free_bitmap(sb, trim_end + 1);
|
|
if (next_free_clu == EXFAT_EOF_CLUSTER)
|
|
goto unlock;
|
|
|
|
do {
|
|
if (next_free_clu == trim_end + 1) {
|
|
/* extend trim range for continuous free cluster */
|
|
trim_end++;
|
|
} else {
|
|
/* trim current range if it's larger than trim_minlen */
|
|
count = trim_end - trim_begin + 1;
|
|
if (count >= trim_minlen) {
|
|
err = sb_issue_discard(sb,
|
|
exfat_cluster_to_sector(sbi, trim_begin),
|
|
count * sbi->sect_per_clus, GFP_NOFS, 0);
|
|
if (err)
|
|
goto unlock;
|
|
|
|
trimmed_total += count;
|
|
}
|
|
|
|
/* set next start point of the free hole */
|
|
trim_begin = trim_end = next_free_clu;
|
|
}
|
|
|
|
if (next_free_clu >= clu_end)
|
|
break;
|
|
|
|
if (fatal_signal_pending(current)) {
|
|
err = -ERESTARTSYS;
|
|
goto unlock;
|
|
}
|
|
|
|
next_free_clu = exfat_find_free_bitmap(sb, next_free_clu + 1);
|
|
} while (next_free_clu != EXFAT_EOF_CLUSTER &&
|
|
next_free_clu > trim_end);
|
|
|
|
/* try to trim remainder */
|
|
count = trim_end - trim_begin + 1;
|
|
if (count >= trim_minlen) {
|
|
err = sb_issue_discard(sb, exfat_cluster_to_sector(sbi, trim_begin),
|
|
count * sbi->sect_per_clus, GFP_NOFS, 0);
|
|
if (err)
|
|
goto unlock;
|
|
|
|
trimmed_total += count;
|
|
}
|
|
|
|
unlock:
|
|
mutex_unlock(&sbi->bitmap_lock);
|
|
range->len = trimmed_total << sbi->cluster_size_bits;
|
|
|
|
return err;
|
|
}
|