mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Randy Dunlap](/assets/img/avatar_default.png)
Fix kernel-doc warnings. Many of these are about a function's return value, so use the kernel-doc Return: format to fix those Use % prefix on numeric constant values. dir.c: fix typos/spellos file.c fix typo: s/taret/target/ Fix all of these kernel-doc warnings: dir.c:305: warning: missing initial short description on line: * kernfs_name_hash dir.c:137: warning: No description found for return value of 'kernfs_path_from_node_locked' dir.c:196: warning: No description found for return value of 'kernfs_name' dir.c:224: warning: No description found for return value of 'kernfs_path_from_node' dir.c:292: warning: No description found for return value of 'kernfs_get_parent' dir.c:312: warning: No description found for return value of 'kernfs_name_hash' dir.c:404: warning: No description found for return value of 'kernfs_unlink_sibling' dir.c:588: warning: No description found for return value of 'kernfs_node_from_dentry' dir.c:806: warning: No description found for return value of 'kernfs_find_ns' dir.c:879: warning: No description found for return value of 'kernfs_find_and_get_ns' dir.c:904: warning: No description found for return value of 'kernfs_walk_and_get_ns' dir.c:927: warning: No description found for return value of 'kernfs_create_root' dir.c:996: warning: No description found for return value of 'kernfs_root_to_node' dir.c:1016: warning: No description found for return value of 'kernfs_create_dir_ns' dir.c:1048: warning: No description found for return value of 'kernfs_create_empty_dir' dir.c:1306: warning: No description found for return value of 'kernfs_next_descendant_post' dir.c:1568: warning: No description found for return value of 'kernfs_remove_self' dir.c:1630: warning: No description found for return value of 'kernfs_remove_by_name_ns' dir.c:1667: warning: No description found for return value of 'kernfs_rename_ns' file.c:66: warning: No description found for return value of 'of_on' file.c:88: warning: No description found for return value of 'kernfs_deref_open_node_locked' file.c:1036: warning: No description found for return value of '__kernfs_create_file' inode.c💯 warning: No description found for return value of 'kernfs_setattr' mount.c:160: warning: No description found for return value of 'kernfs_root_from_sb' mount.c:198: warning: No description found for return value of 'kernfs_node_dentry' mount.c:302: warning: No description found for return value of 'kernfs_super_ns' mount.c:318: warning: No description found for return value of 'kernfs_get_tree' symlink.c:28: warning: No description found for return value of 'kernfs_create_link' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Tejun Heo <tj@kernel.org> Acked-by: Tejun Heo <tj@kernel.org> Link: https://lore.kernel.org/r/20221112031456.22980-1-rdunlap@infradead.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
153 lines
3.3 KiB
C
153 lines
3.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* fs/kernfs/symlink.c - kernfs symlink implementation
|
|
*
|
|
* Copyright (c) 2001-3 Patrick Mochel
|
|
* Copyright (c) 2007 SUSE Linux Products GmbH
|
|
* Copyright (c) 2007, 2013 Tejun Heo <tj@kernel.org>
|
|
*/
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/gfp.h>
|
|
#include <linux/namei.h>
|
|
|
|
#include "kernfs-internal.h"
|
|
|
|
/**
|
|
* kernfs_create_link - create a symlink
|
|
* @parent: directory to create the symlink in
|
|
* @name: name of the symlink
|
|
* @target: target node for the symlink to point to
|
|
*
|
|
* Return: the created node on success, ERR_PTR() value on error.
|
|
* Ownership of the link matches ownership of the target.
|
|
*/
|
|
struct kernfs_node *kernfs_create_link(struct kernfs_node *parent,
|
|
const char *name,
|
|
struct kernfs_node *target)
|
|
{
|
|
struct kernfs_node *kn;
|
|
int error;
|
|
kuid_t uid = GLOBAL_ROOT_UID;
|
|
kgid_t gid = GLOBAL_ROOT_GID;
|
|
|
|
if (target->iattr) {
|
|
uid = target->iattr->ia_uid;
|
|
gid = target->iattr->ia_gid;
|
|
}
|
|
|
|
kn = kernfs_new_node(parent, name, S_IFLNK|0777, uid, gid, KERNFS_LINK);
|
|
if (!kn)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
if (kernfs_ns_enabled(parent))
|
|
kn->ns = target->ns;
|
|
kn->symlink.target_kn = target;
|
|
kernfs_get(target); /* ref owned by symlink */
|
|
|
|
error = kernfs_add_one(kn);
|
|
if (!error)
|
|
return kn;
|
|
|
|
kernfs_put(kn);
|
|
return ERR_PTR(error);
|
|
}
|
|
|
|
static int kernfs_get_target_path(struct kernfs_node *parent,
|
|
struct kernfs_node *target, char *path)
|
|
{
|
|
struct kernfs_node *base, *kn;
|
|
char *s = path;
|
|
int len = 0;
|
|
|
|
/* go up to the root, stop at the base */
|
|
base = parent;
|
|
while (base->parent) {
|
|
kn = target->parent;
|
|
while (kn->parent && base != kn)
|
|
kn = kn->parent;
|
|
|
|
if (base == kn)
|
|
break;
|
|
|
|
if ((s - path) + 3 >= PATH_MAX)
|
|
return -ENAMETOOLONG;
|
|
|
|
strcpy(s, "../");
|
|
s += 3;
|
|
base = base->parent;
|
|
}
|
|
|
|
/* determine end of target string for reverse fillup */
|
|
kn = target;
|
|
while (kn->parent && kn != base) {
|
|
len += strlen(kn->name) + 1;
|
|
kn = kn->parent;
|
|
}
|
|
|
|
/* check limits */
|
|
if (len < 2)
|
|
return -EINVAL;
|
|
len--;
|
|
if ((s - path) + len >= PATH_MAX)
|
|
return -ENAMETOOLONG;
|
|
|
|
/* reverse fillup of target string from target to base */
|
|
kn = target;
|
|
while (kn->parent && kn != base) {
|
|
int slen = strlen(kn->name);
|
|
|
|
len -= slen;
|
|
memcpy(s + len, kn->name, slen);
|
|
if (len)
|
|
s[--len] = '/';
|
|
|
|
kn = kn->parent;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int kernfs_getlink(struct inode *inode, char *path)
|
|
{
|
|
struct kernfs_node *kn = inode->i_private;
|
|
struct kernfs_node *parent = kn->parent;
|
|
struct kernfs_node *target = kn->symlink.target_kn;
|
|
struct kernfs_root *root = kernfs_root(parent);
|
|
int error;
|
|
|
|
down_read(&root->kernfs_rwsem);
|
|
error = kernfs_get_target_path(parent, target, path);
|
|
up_read(&root->kernfs_rwsem);
|
|
|
|
return error;
|
|
}
|
|
|
|
static const char *kernfs_iop_get_link(struct dentry *dentry,
|
|
struct inode *inode,
|
|
struct delayed_call *done)
|
|
{
|
|
char *body;
|
|
int error;
|
|
|
|
if (!dentry)
|
|
return ERR_PTR(-ECHILD);
|
|
body = kzalloc(PAGE_SIZE, GFP_KERNEL);
|
|
if (!body)
|
|
return ERR_PTR(-ENOMEM);
|
|
error = kernfs_getlink(inode, body);
|
|
if (unlikely(error < 0)) {
|
|
kfree(body);
|
|
return ERR_PTR(error);
|
|
}
|
|
set_delayed_call(done, kfree_link, body);
|
|
return body;
|
|
}
|
|
|
|
const struct inode_operations kernfs_symlink_iops = {
|
|
.listxattr = kernfs_iop_listxattr,
|
|
.get_link = kernfs_iop_get_link,
|
|
.setattr = kernfs_iop_setattr,
|
|
.getattr = kernfs_iop_getattr,
|
|
.permission = kernfs_iop_permission,
|
|
};
|