Nicolas Dichtel f04f067aaa xfrm interface: avoid corruption on changelink ... commit e9e7e85d75 upstream. The new parameters must not be stored in the netdev_priv() before validation, it may corrupt the interface. Note also that if data is NULL, only a memset() is done. $ ip link add xfrm1 type xfrm dev lo if_id 1 $ ip link add xfrm2 type xfrm dev lo if_id 2 $ ip link set xfrm1 type xfrm dev lo if_id 2 RTNETLINK answers: File exists $ ip -d link list dev xfrm1 5: xfrm1@lo: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/none 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 minmtu 68 maxmtu 1500 xfrm if_id 0x2 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 => "if_id 0x2" Fixes: f203b76d78 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Tested-by: Julien Floret <julien.floret@6wind.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-12-13 08:52:41 +01:00
..
Kconfig	ipsec: select crypto ciphers for xfrm_algo	2019-07-26 09:14:10 +02:00
Makefile	xfrm: Add virtual xfrm interfaces	2018-06-23 16:07:25 +02:00
xfrm_algo.c	xfrm: use IS_ENABLED() instead of checking for built-in or module	2016-09-10 21:19:11 -07:00
xfrm_device.c	xfrm: don't check offload_handle for nonzero	2018-07-19 10:18:04 +02:00
xfrm_hash.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_hash.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_input.c	xfrm: release device reference for invalid state	2019-12-13 08:51:03 +01:00
xfrm_interface.c	xfrm interface: avoid corruption on changelink	2019-12-13 08:52:41 +01:00
xfrm_ipcomp.c	net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()	2018-03-13 07:46:37 +01:00
xfrm_output.c	xfrm: Fix error return code in xfrm_output_one()	2019-01-13 09:50:57 +01:00
xfrm_policy.c	xfrm: Honor original L3 slave device in xfrmi policy lookup	2019-05-25 18:23:41 +02:00
xfrm_proc.c	proc: introduce proc_create_net_single	2018-05-16 07:24:30 +02:00
xfrm_replay.c	xfrm: Fix ESN sequence number handling for IPsec GSO packets.	2018-03-01 08:14:50 +01:00
xfrm_state.c	xfrm: Fix memleak on xfrm state destroy	2019-12-05 09:21:27 +01:00
xfrm_sysctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm_user.c	xfrm: fix sa selector validation	2019-07-26 09:14:08 +02:00