Qu Wenruo 3c198fe064 btrfs: rework the order of btrfs_ordered_extent::flags ... [BUG] There is a long existing bug in the last parameter of btrfs_add_ordered_extent(), in commit 771ed689d2 ("Btrfs: Optimize compressed writeback and reads") back to 2008. In that ancient commit btrfs_add_ordered_extent() expects the @type parameter to be one of the following: - BTRFS_ORDERED_REGULAR - BTRFS_ORDERED_NOCOW - BTRFS_ORDERED_PREALLOC - BTRFS_ORDERED_COMPRESSED But we pass 0 in cow_file_range(), which means BTRFS_ORDERED_IO_DONE. Ironically extra check in __btrfs_add_ordered_extent() won't set the bit if we see (type == IO_DONE || type == IO_COMPLETE), and avoid any obvious bug. But this still leads to regular COW ordered extent having no bit to indicate its type in various trace events, rendering REGULAR bit useless. [FIX] Change the following aspects to avoid such problem: - Reorder btrfs_ordered_extent::flags Now the type bits go first (REGULAR/NOCOW/PREALLCO/COMPRESSED), then DIRECT bit, finally extra status bits like IO_DONE/COMPLETE/IOERR. - Add extra ASSERT() for btrfs_add_ordered_extent_*() - Remove @type parameter for btrfs_add_ordered_extent_compress() As the only valid @type here is BTRFS_ORDERED_COMPRESSED. - Remove the unnecessary special check for IO_DONE/COMPLETE in __btrfs_add_ordered_extent() This is just to make the code work, with extra ASSERT(), there are limited values can be passed in. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2021-02-08 22:58:52 +01:00
..
acpi	More power management updates for 5.11-rc1	2020-12-22 14:12:10 -08:00
asm-generic	arm64: make atomic helpers __always_inline	2021-01-13 15:09:06 +00:00
clocksource
crypto
drm	drm/dp/mst: Export drm_dp_get_vc_payload_bw()	2021-02-02 17:31:37 +02:00
dt-bindings	ASoC: dt-bindings: lpass: Fix and common up lpass dai ids	2021-01-20 16:46:44 +00:00
keys
kunit
kvm	KVM: arm64: Replace KVM_ARM_PMU with HW_PERF_EVENTS	2021-01-04 16:50:16 +00:00
linux	- Prevent device managed IRQ allocation helpers from returning IRQ 0.	2021-02-07 10:25:01 -08:00
math-emu
media	media: v4l: common: Fix naming of v4l2_get_link_rate	2021-01-07 15:47:52 +01:00
memory
misc
net	udp: ipv4: manipulate network header of NATed UDP GRO fraglist	2021-02-01 20:02:16 -08:00
pcmcia
ras
rdma	RDMA 5.11 pull request	2020-12-16 13:42:26 -08:00
scsi	SCSI misc on 20201216	2020-12-16 13:34:31 -08:00
soc	include/soc: remove headers for EZChip NPS	2021-01-05 12:59:41 -08:00
sound	ALSA: pcm: One more dependency for hw constraints	2021-01-23 16:59:24 +01:00
target
trace	btrfs: rework the order of btrfs_ordered_extent::flags	2021-02-08 22:58:52 +01:00
uapi	- For syscall user dispatch, separate ptctl operation from syscall	2021-02-07 10:16:24 -08:00
vdso
video
xen	xen: Fix event channel callback via INTX/GSI	2021-01-13 16:12:00 +01:00