Vladimir Oltean e80f40cbe4 net: dsa: tag_8021q: replace dsa_8021q_remove_header with __skb_vlan_pop ... Not only did this wheel did not need reinventing, but there is also an issue with it: It doesn't remove the VLAN header in a way that preserves the L2 payload checksum when that is being provided by the DSA master hw. It should recalculate checksum both for the push, before removing the header, and for the pull afterwards. But the current implementation is quite dizzying, with pulls followed immediately afterwards by pushes, the memmove is done before the push, etc. This makes a DSA master with RX checksumming offload to print stack traces with the infamous 'hw csum failure' message. So remove the dsa_8021q_remove_header function and replace it with something that actually works with inet checksumming. Fixes: d461933638 ("net: dsa: tag_8021q: Create helper function for removing VLAN header") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-03-24 16:19:01 -07:00
..
8021q.h	net: dsa: tag_8021q: replace dsa_8021q_remove_header with __skb_vlan_pop	2020-03-24 16:19:01 -07:00
lan9303.h	net: dsa: lan9303: phy_addr_sel_strap rename and retype	2018-01-04 13:35:07 -05:00
sja1105.h	net: dsa: Make deferred_xmit private to sja1105	2020-01-05 15:13:13 -08:00