NeilBrown f16857e62b NFS: unlink/rmdir shouldn't call d_delete() twice on ENOENT ... nfs_unlink() calls d_delete() twice if it receives ENOENT from the server - once in nfs_dentry_handle_enoent() from nfs_safe_remove and once in nfs_dentry_remove_handle_error(). nfs_rmddir() also calls it twice - the nfs_dentry_handle_enoent() call is direct and inside a region locked with ->rmdir_sem It is safe to call d_delete() twice if the refcount > 1 as the dentry is simply unhashed. If the refcount is 1, the first call sets d_inode to NULL and the second call crashes. This patch guards the d_delete() call from nfs_dentry_handle_enoent() leaving the one under ->remdir_sem in case that is important. In mainline it would be safe to remove the d_delete() call. However in older kernels to which this might be backported, that would change the behaviour of nfs_unlink(). nfs_unlink() used to unhash the dentry which resulted in nfs_dentry_handle_enoent() not calling d_delete(). So in older kernels we need the d_delete() in nfs_dentry_remove_handle_error() when called from nfs_unlink() but not when called from nfs_rmdir(). To make the code work correctly for old and new kernels, and from both nfs_unlink() and nfs_rmdir(), we protect the d_delete() call with simple_positive(). This ensures it is never called in a circumstance where it could crash. Fixes: 3c59366c20 ("NFS: don't unhash dentry during unlink/rename") Fixes: 9019fb391d ("NFS: Label the dentry with a verifier in nfs_rmdir() and nfs_unlink()") Signed-off-by: NeilBrown <neilb@suse.de> Tested-by: Olga Kornievskaia <aglo@umich.edu> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>		2022-08-19 20:31:36 -04:00
..
9p	9p: fix EBADF errors in cached mode	2022-06-17 06:03:30 +09:00
adfs
affs
afs	afs: Fix dynamic root getattr	2022-06-21 11:47:30 -05:00
autofs
befs
bfs
btrfs	for-5.19-rc3-tag	2022-06-26 10:11:36 -07:00
cachefiles	cachefiles: narrow the scope of flushed requests when releasing fd	2022-07-05 16:12:21 +01:00
ceph	ceph: wait on async create before checking caps for syncfs	2022-06-29 18:02:57 +02:00
cifs	cifs: update cifs_ses::ip_addr after failover	2022-06-24 13:34:28 -05:00
coda
configfs
cramfs
crypto	fscrypt: add new helper functions for test_dummy_encryption	2022-05-09 16:18:54 -07:00
debugfs
devpts
dlm
ecryptfs
efivarfs
efs
erofs	Changes since last update:	2022-06-01 11:54:29 -07:00
exfat	exfat: use updated exfat_chain directly during renaming	2022-06-09 21:26:32 +09:00
exportfs
ext2	ext2: fix fs corruption when trying to remove a non-empty directory with IO error	2022-06-16 10:55:45 +02:00
ext4	ext4: fix a doubled word "need" in a comment	2022-06-18 19:36:20 -04:00
f2fs	f2fs: do not count ENOENT for error case	2022-06-21 08:29:56 -07:00
fat	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
freevxfs	SPDX changes for 5.19-rc1	2022-06-03 10:34:34 -07:00
fscache	fscache: Fix invalidation/lookup race	2022-07-05 16:12:55 +01:00
fuse	libnvdimm for 5.19	2022-05-27 15:49:30 -07:00
gfs2	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
hfs	fs: Change try_to_free_buffers() to take a folio	2022-05-09 23:12:34 -04:00
hfsplus	fs: Change try_to_free_buffers() to take a folio	2022-05-09 23:12:34 -04:00
hostfs
hpfs
hugetlbfs	hugetlbfs: zero partial pages during fallocate hole punch	2022-06-16 19:11:32 -07:00
iomap	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
isofs
jbd2	fs: fix jbd2_journal_try_to_free_buffers() kernel-doc comment	2022-06-16 10:36:09 -04:00
jffs2	This pull request contains fixes for JFFS2, UBI and UBIFS	2022-06-03 14:42:24 -07:00
jfs	JFS: One bug fix and some code cleanup	2022-05-27 15:59:21 -07:00
kernfs	kernfs: Separate kernfs_pr_cont_buf and rename_lock.	2022-05-19 19:37:06 +02:00
ksmbd	vfs: fix copy_file_range() regression in cross-fs copies	2022-06-30 15:16:38 -07:00
lockd
minix
netfs	netfs: Rename the netfs_io_request cleanup op and give it an op pointer	2022-06-10 20:55:21 +01:00
nfs	NFS: unlink/rmdir shouldn't call d_delete() twice on ENOENT	2022-08-19 20:31:36 -04:00
nfs_common
nfsd	Notable regression fixes:	2022-07-02 11:20:56 -07:00
nilfs2	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
nls
notify	fanotify: refine the validation checks on non-dir inode mask	2022-06-28 11:18:13 +02:00
ntfs	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
ntfs3	Ntfs3 for 5.19	2022-06-03 16:57:16 -07:00
ocfs2	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
omfs
openpromfs
orangefs	orangefs: Convert to free_folio	2022-05-09 23:12:53 -04:00
overlayfs	overlayfs update for 5.19	2022-05-30 11:19:16 -07:00
proc	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
pstore
qnx4
qnx6
quota	quota: Prevent memory allocation recursion while holding dq_lock	2022-06-06 10:08:10 +02:00
ramfs
reiserfs	fs: Change try_to_free_buffers() to take a folio	2022-05-09 23:12:34 -04:00
romfs
smbfs_common	Add various fsctl structs	2022-05-23 20:24:12 -05:00
squashfs	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
sysfs
sysv	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
tracefs	tracefs: Fix syntax errors in comments	2022-06-17 19:01:28 -04:00
ubifs	This pull request contains fixes for JFFS2, UBI and UBIFS	2022-06-03 14:42:24 -07:00
udf	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
ufs
unicode
vboxsf	vboxsf: Convert vboxsf to read_folio	2022-05-09 16:21:46 -04:00
verity	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
xfs	xfs: prevent a UAF when log IO errors race with unmount	2022-07-01 09:09:52 -07:00
zonefs	zonefs: fix zonefs_iomap_begin() for reads	2022-06-08 19:13:55 +09:00
aio.c
anon_inodes.c
attr.c	fs: account for group membership	2022-06-14 12:18:47 +02:00
bad_inode.c
binfmt_aout.c
binfmt_elf.c
binfmt_elf_fdpic.c
binfmt_elf_test.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c
buffer.c	fs: Convert drop_buffers() to use a folio	2022-05-09 23:12:34 -04:00
char_dev.c
compat_binfmt_elf.c
coredump.c
d_path.c
dax.c	libnvdimm for 5.19	2022-05-27 15:49:30 -07:00
dcache.c
direct-io.c
drop_caches.c
eventfd.c
eventpoll.c
exec.c	This set of changes updates init and user mode helper tasks to be	2022-06-03 16:03:05 -07:00
fcntl.c	VFS: add FMODE_CAN_ODIRECT file flag	2022-05-09 18:20:49 -07:00
fhandle.c
file.c	fix the breakage in close_fd_get_file() calling conventions change	2022-06-05 15:03:03 -04:00
file_table.c	Descriptor handling cleanups	2022-06-04 18:52:00 -07:00
filesystems.c
fs-writeback.c	writeback: Fix inode->i_io_list not be protected by inode->i_lock error	2022-06-06 09:54:30 +02:00
fs_context.c
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c	uninline may_mount() and don't opencode it in fspick(2)/fsopen(2)	2022-05-19 23:25:10 -04:00
init.c
inode.c	writeback: Fix inode->i_io_list not be protected by inode->i_lock error	2022-06-06 09:54:30 +02:00
internal.h	Cleanups (and one fix) around struct mount handling.	2022-06-04 19:00:05 -07:00
io-wq.c
io-wq.h
io_uring.c	io_uring: check that we have a file table when allocating update slots	2022-07-09 07:02:10 -06:00
ioctl.c
Kconfig
Kconfig.binfmt	m68knommu: changes for linux 5.19	2022-05-30 10:56:18 -07:00
kernel_read_file.c
libfs.c
locks.c	fs/lock: add 2 callbacks to lock_manager_operations to resolve conflict	2022-05-19 12:25:39 -04:00
Makefile
mbcache.c
mount.h
mpage.c	fs: Change try_to_free_buffers() to take a folio	2022-05-09 23:12:34 -04:00
namei.c	Several cleanups in fs/namei.c.	2022-06-04 19:07:15 -07:00
namespace.c	Cleanups (and one fix) around struct mount handling.	2022-06-04 19:00:05 -07:00
no-block.c
nsfs.c
open.c	RISC-V Patches for the 5.19 Merge Window, Part 1	2022-05-31 14:10:54 -07:00
pipe.c	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	vfs: fix copy_file_range() regression in cross-fs copies	2022-06-30 15:16:38 -07:00
readdir.c
remap_range.c
select.c
seq_file.c	rxrpc: Fix locking issue	2022-05-22 21:03:01 +01:00
signalfd.c
splice.c
stack.c
stat.c	RISC-V Patches for the 5.19 Merge Window, Part 1	2022-05-31 14:10:54 -07:00
statfs.c
super.c
sync.c
sysctls.c
timerfd.c
userfaultfd.c	mm/uffd: enable write protection for shmem & hugetlbfs	2022-05-13 07:20:11 -07:00
utimes.c
xattr.c