Eric Dumazet f190a4aa03 net/sched: act_skbmod: prevent kernel-infoleak ... commit d313eb8b77 upstream. syzbot found that tcf_skbmod_dump() was copying four bytes from kernel stack to user space [1]. The issue here is that 'struct tc_skbmod' has a four bytes hole. We need to clear the structure before filling fields. [1] BUG: KMSAN: kernel-infoleak in instrument_copy_to_user include/linux/instrumented.h:114 [inline] BUG: KMSAN: kernel-infoleak in copy_to_user_iter lib/iov_iter.c:24 [inline] BUG: KMSAN: kernel-infoleak in iterate_ubuf include/linux/iov_iter.h:29 [inline] BUG: KMSAN: kernel-infoleak in iterate_and_advance2 include/linux/iov_iter.h:245 [inline] BUG: KMSAN: kernel-infoleak in iterate_and_advance include/linux/iov_iter.h:271 [inline] BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x366/0x2520 lib/iov_iter.c:185 instrument_copy_to_user include/linux/instrumented.h:114 [inline] copy_to_user_iter lib/iov_iter.c:24 [inline] iterate_ubuf include/linux/iov_iter.h:29 [inline] iterate_and_advance2 include/linux/iov_iter.h:245 [inline] iterate_and_advance include/linux/iov_iter.h:271 [inline] _copy_to_iter+0x366/0x2520 lib/iov_iter.c:185 copy_to_iter include/linux/uio.h:196 [inline] simple_copy_to_iter net/core/datagram.c:532 [inline] __skb_datagram_iter+0x185/0x1000 net/core/datagram.c:420 skb_copy_datagram_iter+0x5c/0x200 net/core/datagram.c:546 skb_copy_datagram_msg include/linux/skbuff.h:4050 [inline] netlink_recvmsg+0x432/0x1610 net/netlink/af_netlink.c:1962 sock_recvmsg_nosec net/socket.c:1046 [inline] sock_recvmsg+0x2c4/0x340 net/socket.c:1068 __sys_recvfrom+0x35a/0x5f0 net/socket.c:2242 __do_sys_recvfrom net/socket.c:2260 [inline] __se_sys_recvfrom net/socket.c:2256 [inline] __x64_sys_recvfrom+0x126/0x1d0 net/socket.c:2256 do_syscall_64+0xd5/0x1f0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 Uninit was stored to memory at: pskb_expand_head+0x30f/0x19d0 net/core/skbuff.c:2253 netlink_trim+0x2c2/0x330 net/netlink/af_netlink.c:1317 netlink_unicast+0x9f/0x1260 net/netlink/af_netlink.c:1351 nlmsg_unicast include/net/netlink.h:1144 [inline] nlmsg_notify+0x21d/0x2f0 net/netlink/af_netlink.c:2610 rtnetlink_send+0x73/0x90 net/core/rtnetlink.c:741 rtnetlink_maybe_send include/linux/rtnetlink.h:17 [inline] tcf_add_notify net/sched/act_api.c:2048 [inline] tcf_action_add net/sched/act_api.c:2071 [inline] tc_ctl_action+0x146e/0x19d0 net/sched/act_api.c:2119 rtnetlink_rcv_msg+0x1737/0x1900 net/core/rtnetlink.c:6595 netlink_rcv_skb+0x375/0x650 net/netlink/af_netlink.c:2559 rtnetlink_rcv+0x34/0x40 net/core/rtnetlink.c:6613 netlink_unicast_kernel net/netlink/af_netlink.c:1335 [inline] netlink_unicast+0xf4c/0x1260 net/netlink/af_netlink.c:1361 netlink_sendmsg+0x10df/0x11f0 net/netlink/af_netlink.c:1905 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 ____sys_sendmsg+0x877/0xb60 net/socket.c:2584 ___sys_sendmsg+0x28d/0x3c0 net/socket.c:2638 __sys_sendmsg net/socket.c:2667 [inline] __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __x64_sys_sendmsg+0x307/0x4a0 net/socket.c:2674 do_syscall_64+0xd5/0x1f0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 Uninit was stored to memory at: __nla_put lib/nlattr.c:1041 [inline] nla_put+0x1c6/0x230 lib/nlattr.c:1099 tcf_skbmod_dump+0x23f/0xc20 net/sched/act_skbmod.c:256 tcf_action_dump_old net/sched/act_api.c:1191 [inline] tcf_action_dump_1+0x85e/0x970 net/sched/act_api.c:1227 tcf_action_dump+0x1fd/0x460 net/sched/act_api.c:1251 tca_get_fill+0x519/0x7a0 net/sched/act_api.c:1628 tcf_add_notify_msg net/sched/act_api.c:2023 [inline] tcf_add_notify net/sched/act_api.c:2042 [inline] tcf_action_add net/sched/act_api.c:2071 [inline] tc_ctl_action+0x1365/0x19d0 net/sched/act_api.c:2119 rtnetlink_rcv_msg+0x1737/0x1900 net/core/rtnetlink.c:6595 netlink_rcv_skb+0x375/0x650 net/netlink/af_netlink.c:2559 rtnetlink_rcv+0x34/0x40 net/core/rtnetlink.c:6613 netlink_unicast_kernel net/netlink/af_netlink.c:1335 [inline] netlink_unicast+0xf4c/0x1260 net/netlink/af_netlink.c:1361 netlink_sendmsg+0x10df/0x11f0 net/netlink/af_netlink.c:1905 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 ____sys_sendmsg+0x877/0xb60 net/socket.c:2584 ___sys_sendmsg+0x28d/0x3c0 net/socket.c:2638 __sys_sendmsg net/socket.c:2667 [inline] __do_sys_sendmsg net/socket.c:2676 [inline] __se_sys_sendmsg net/socket.c:2674 [inline] __x64_sys_sendmsg+0x307/0x4a0 net/socket.c:2674 do_syscall_64+0xd5/0x1f0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 Local variable opt created at: tcf_skbmod_dump+0x9d/0xc20 net/sched/act_skbmod.c:244 tcf_action_dump_old net/sched/act_api.c:1191 [inline] tcf_action_dump_1+0x85e/0x970 net/sched/act_api.c:1227 Bytes 188-191 of 248 are uninitialized Memory access of size 248 starts at ffff888117697680 Data copied to user address 00007ffe56d855f0 Fixes: 86da71b573 ("net_sched: Introduce skbmod action") Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Link: https://lore.kernel.org/r/20240403130908.93421-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-04-13 12:50:12 +02:00
..
6lowpan
9p	net: 9p: avoid freeing uninit memory in p9pdu_vreadf	2024-01-08 11:27:36 +01:00
802	mrp: introduce active flags to prevent UAF when applicant uninit	2023-01-18 11:30:36 +01:00
8021q	vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING	2024-02-23 08:12:41 +01:00
appletalk	appletalk: Fix Use-After-Free in atalk_ioctl	2023-12-20 15:38:01 +01:00
atm	atm: Fix Use-After-Free in do_vcc_ioctl	2023-12-20 15:38:00 +01:00
ax25
batman-adv	batman-adv: Fix batadv_v_ogm_aggr_send memory leak	2023-08-30 16:31:55 +02:00
bluetooth	Bluetooth: Fix TOCTOU in HCI debugfs implementation	2024-04-13 12:50:12 +02:00
bpf
bpfilter
bridge	net: bridge: use DEV_STATS_INC()	2023-10-10 21:44:57 +02:00
caif	net: caif: Fix use-after-free in cfusbl_device_notify()	2023-03-17 08:31:44 +01:00
can	can: bcm: Fix UAF in bcm_proc_show()	2023-08-11 11:45:24 +02:00
ceph	libceph: use kernel_connect()	2023-10-25 11:16:51 +02:00
core	mptcp: add sk_stop_timer_sync helper	2024-04-13 12:50:12 +02:00
dcb
dccp	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-20 10:29:21 +01:00
decnet	Remove DECnet support from kernel	2023-06-21 15:39:57 +02:00
dns_resolver
dsa
ethernet
hsr	hsr: Handle failures in module init	2024-03-26 18:22:42 -04:00
ieee802154
ife	net: sched: ife: fix potential use-after-free	2024-01-08 11:27:34 +01:00
ipv4	tcp: properly terminate timers for kernel sockets	2024-04-13 12:50:12 +02:00
ipv6	ipv6: fib6_rules: flush route cache when rule is changed	2024-03-26 18:22:36 -04:00
iucv	net/iucv: fix the allocation size of iucv_path_table array	2024-03-26 18:22:33 -04:00
kcm	net: kcm: fix incorrect parameter validation in the kcm_getsockopt) function	2024-03-26 18:22:36 -04:00
key	net: af_key: fix sadb_x_filter validation	2023-08-30 16:31:48 +02:00
l2tp	l2tp: fix incorrect parameter validation in the pppol2tp_getsockopt() function	2024-03-26 18:22:36 -04:00
l3mdev
lapb
llc	llc: call sock_orphan() at release time	2024-02-23 08:12:52 +01:00
mac80211	wifi: mac80211: check/clear fast rx for non-4addr sta VLAN changes	2024-04-13 12:50:09 +02:00
mac802154
mpls	net: mpls: fix stale pointer if allocation fails during device rename	2023-02-22 12:47:21 +01:00
ncsi	net/ncsi: Fix netlink major/minor version numbers	2024-01-25 14:33:33 -08:00
netfilter	netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()	2024-04-13 12:50:12 +02:00
netlabel	calipso: fix memory leak in netlbl_calipso_add_pass()	2024-01-25 14:33:32 -08:00
netlink	netlink: Fix kernel-infoleak-after-free in __skb_datagram_iter	2024-03-06 14:35:22 +00:00
netrom	netrom: Fix data-races around sysctl_net_busy_read	2024-03-15 10:48:16 -04:00
nfc	nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet	2024-04-13 12:50:11 +02:00
nsh	net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()	2023-05-30 12:42:11 +01:00
openvswitch	net: openvswitch: fix flow memory leak in ovs_flow_cmd_new	2023-02-22 12:47:12 +01:00
packet	packet: move from strlcpy with unused retval to strscpy	2024-03-01 13:06:11 +01:00
phonet
psample	psample: Require 'CAP_NET_ADMIN' when joining "packets" group	2023-12-13 17:42:20 +01:00
qrtr
rds	net/rds: fix possible cp null dereference	2024-04-13 12:50:12 +02:00
rfkill	net: rfkill: gpio: set GPIO direction	2024-01-08 11:27:36 +01:00
rose	net/rose: fix races in rose_kill_by_device()	2024-01-08 11:27:34 +01:00
rxrpc	rxrpc: Fix response to PING RESPONSE ACKs to a dead call	2024-02-23 08:12:54 +01:00
sched	net/sched: act_skbmod: prevent kernel-infoleak	2024-04-13 12:50:12 +02:00
sctp	sctp: update hb timer immediately after users change hb_interval	2023-10-10 21:45:01 +02:00
smc	net/smc: fix illegal rmb_desc access in SMC-D connection dump	2024-02-23 08:12:41 +01:00
strparser
sunrpc	net: sunrpc: Fix an off by one in rpc_sockaddr2uaddr()	2024-03-26 18:22:42 -04:00
switchdev
tipc	tipc: Check the bearer type before calling tipc_udp_nl_bearer_add()	2024-02-23 08:12:54 +01:00
tls
unix	af_unix: Annotate data-race of gc_in_progress in wait_for_unix_gc().	2024-03-26 18:22:35 -04:00
vmw_vsock	vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space()	2023-12-20 15:38:01 +01:00
wimax
wireless	wifi: nl80211: reject iftype change with mesh ID change	2024-03-06 14:35:23 +00:00
x25	net/x25: fix incorrect parameter validation in the x25_getsockopt() function	2024-03-26 18:22:37 -04:00
xdp
xfrm	xfrm: Avoid clang fortify warning in copy_to_user_tmpl()	2024-04-13 12:50:08 +02:00
compat.c
Kconfig	Remove DECnet support from kernel	2023-06-21 15:39:57 +02:00
Makefile	Remove DECnet support from kernel	2023-06-21 15:39:57 +02:00
socket.c	net: Save and restore msg_namelen in sock_sendmsg	2024-01-15 18:23:42 +01:00
sysctl_net.c