mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 00:48:50 +00:00
2754f6157d
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Link: https://lore.kernel.org/r/20231109202830.4124591-11-u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
54 lines
1.2 KiB
C
54 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* TI PWM Subsystem driver
|
|
*
|
|
* Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/io.h>
|
|
#include <linux/err.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/of_platform.h>
|
|
|
|
static const struct of_device_id pwmss_of_match[] = {
|
|
{ .compatible = "ti,am33xx-pwmss" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, pwmss_of_match);
|
|
|
|
static int pwmss_probe(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct device_node *node = pdev->dev.of_node;
|
|
|
|
pm_runtime_enable(&pdev->dev);
|
|
|
|
/* Populate all the child nodes here... */
|
|
ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
|
|
if (ret)
|
|
dev_err(&pdev->dev, "no child node found\n");
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void pwmss_remove(struct platform_device *pdev)
|
|
{
|
|
pm_runtime_disable(&pdev->dev);
|
|
}
|
|
|
|
static struct platform_driver pwmss_driver = {
|
|
.driver = {
|
|
.name = "pwmss",
|
|
.of_match_table = pwmss_of_match,
|
|
},
|
|
.probe = pwmss_probe,
|
|
.remove_new = pwmss_remove,
|
|
};
|
|
|
|
module_platform_driver(pwmss_driver);
|
|
|
|
MODULE_DESCRIPTION("PWM Subsystem driver");
|
|
MODULE_AUTHOR("Texas Instruments");
|
|
MODULE_LICENSE("GPL");
|