Lorenz Bauer f58423aeab bpf, sockmap: Add locking annotations to iterator ... The sparse checker currently outputs the following warnings: include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_hash_seq_start' - wrong count at exit include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_map_seq_start' - wrong count at exit Add the necessary __acquires and __release annotations to make the iterator locking schema palatable to sparse. Also add __must_hold for good measure. The kernel codebase uses both __acquires(rcu) and __acquires(RCU). I couldn't find any guidance which one is preferred, so I used what is easier to type out. Fixes: 0365351524 ("net: Allow iterating sockmap and sockhash") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Jakub Sitnicki <jakub@cloudflare.com> Link: https://lore.kernel.org/bpf/20201012091850.67452-1-lmb@cloudflare.com		2020-10-15 20:49:56 +02:00
..
bpf_sk_storage.c	bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON	2020-09-25 13:58:01 -07:00
datagram.c	net: zerocopy: combine pages in zerocopy_sg_from_iter()	2020-08-20 16:12:50 -07:00
datagram.h
dev.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-10-12 16:16:50 -07:00
dev_addr_lists.c	net: core: add nested_level variable in net_device	2020-09-28 15:00:15 -07:00
dev_ioctl.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
devlink.c	devlink: Add enable_remote_dev_reset generic parameter	2020-10-09 12:06:53 -07:00
drop_monitor.c	genetlink: move to smaller ops wherever possible	2020-10-02 19:11:11 -07:00
dst.c	net: Correct the comment of dst_dev_put()	2020-09-10 13:28:57 -07:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
failover.c
fib_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_rules.c	fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m	2020-09-08 20:09:08 -07:00
filter.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-10-12 16:16:50 -07:00
flow_dissector.c	net: flow_dissector: avoid indirect call to DSA .flow_dissect for generic case	2020-09-26 14:17:59 -07:00
flow_offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-07-25 17:49:04 -07:00
gen_estimator.c	net_sched: gen_estimator: extend packet counter to 64bit	2019-11-06 21:51:36 -08:00
gen_stats.c	docs: networking: convert gen_stats.txt to ReST	2020-04-28 14:39:46 -07:00
gro_cells.c
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: Add IF_OPER_TESTING	2020-04-20 12:43:24 -07:00
lwt_bpf.c	net: add net available in build_state	2020-03-29 22:30:57 -07:00
lwtunnel.c	net: ipv6: add rpl sr tunnel	2020-03-29 22:30:57 -07:00
Makefile	ethtool: move to its own directory	2019-12-12 17:07:05 -08:00
neighbour.c	net: neighbor: add fdb extended attribute	2020-06-24 14:36:33 -07:00
net-procfs.c	net-sysfs: add backlog len and CPU id to softnet data	2020-09-21 13:56:37 -07:00
net-sysfs.c	net-sysfs: Fix inconsistent of format with argument type in net-sysfs.c	2020-10-01 18:45:23 -07:00
net-sysfs.h	net-sysfs: add netdev_change_owner()	2020-02-26 20:07:25 -08:00
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
net_namespace.c	bpf, net: Rework cookie generator as per-cpu one	2020-09-30 11:50:35 -07:00
netclassid_cgroup.c	cgroup, netclassid: remove double cond_resched	2020-04-21 15:44:30 -07:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: make sure napi_list is safe for RCU traversal	2020-09-10 13:08:46 -07:00
netprio_cgroup.c	netprio_cgroup: Fix unlimited memory leak of v2 cgroups	2020-05-09 20:59:21 -07:00
page_pool.c	net: page pool: allow to pass zero flags to page_pool_init()	2020-03-29 21:49:20 -07:00
pktgen.c	pktgen: Fix inconsistent of format with argument type in pktgen.c	2020-10-01 18:45:23 -07:00
ptp_classifier.c	ptp: Add generic ptp v2 header parsing function	2020-08-19 16:07:49 -07:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-08-03 18:27:40 -07:00
scm.c	fs: Add receive_fd() wrapper for __receive_fd()	2020-07-13 11:03:44 -07:00
secure_seq.c	crypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h	2020-05-08 15:32:17 +10:00
skbuff.c	net: always dump full packets with skb_dump	2020-10-06 06:14:02 -07:00
skmsg.c	bpf, sockmap: Allow skipping sk_skb parser program	2020-10-11 18:09:44 -07:00
sock.c	mptcp: add sk_stop_timer_sync helper	2020-09-24 19:58:34 -07:00
sock_diag.c	bpf, net: Rework cookie generator as per-cpu one	2020-09-30 11:50:35 -07:00
sock_map.c	bpf, sockmap: Add locking annotations to iterator	2020-10-15 20:49:56 +02:00
sock_reuseport.c	udp: Copy has_conns in reuseport_grow().	2020-07-21 15:31:02 -07:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	net: add option to not create fall-back tunnels in root-ns as well	2020-08-28 06:52:44 -07:00
timestamping.c	net: Introduce a new MII time stamping interface.	2019-12-25 19:51:33 -08:00
tso.c	net: tso: add UDP segmentation support	2020-06-18 20:46:23 -07:00
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-01-24 20:54:30 +01:00
xdp.c	bpf, xdp: Remove XDP_QUERY_PROG and XDP_QUERY_PROG_HW XDP commands	2020-07-25 20:37:02 -07:00