mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
324 lines
7.9 KiB
C
324 lines
7.9 KiB
C
/*
|
|
* Copyright (C) 2007-2009 ST-Ericsson AB
|
|
* License terms: GNU General Public License (GPL) version 2
|
|
* Real Time Clock interface for ST-Ericsson AB COH 901 331 RTC.
|
|
* Author: Linus Walleij <linus.walleij@stericsson.com>
|
|
* Based on rtc-pl031.c by Deepak Saxena <dsaxena@plexity.net>
|
|
* Copyright 2006 (c) MontaVista Software, Inc.
|
|
*/
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/rtc.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/pm.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/io.h>
|
|
#include <linux/slab.h>
|
|
|
|
/*
|
|
* Registers in the COH 901 331
|
|
*/
|
|
/* Alarm value 32bit (R/W) */
|
|
#define COH901331_ALARM 0x00U
|
|
/* Used to set current time 32bit (R/W) */
|
|
#define COH901331_SET_TIME 0x04U
|
|
/* Indication if current time is valid 32bit (R/-) */
|
|
#define COH901331_VALID 0x08U
|
|
/* Read the current time 32bit (R/-) */
|
|
#define COH901331_CUR_TIME 0x0cU
|
|
/* Event register for the "alarm" interrupt */
|
|
#define COH901331_IRQ_EVENT 0x10U
|
|
/* Mask register for the "alarm" interrupt */
|
|
#define COH901331_IRQ_MASK 0x14U
|
|
/* Force register for the "alarm" interrupt */
|
|
#define COH901331_IRQ_FORCE 0x18U
|
|
|
|
/*
|
|
* Reference to RTC block clock
|
|
* Notice that the frequent clk_enable()/clk_disable() on this
|
|
* clock is mainly to be able to turn on/off other clocks in the
|
|
* hierarchy as needed, the RTC clock is always on anyway.
|
|
*/
|
|
struct coh901331_port {
|
|
struct rtc_device *rtc;
|
|
struct clk *clk;
|
|
u32 phybase;
|
|
u32 physize;
|
|
void __iomem *virtbase;
|
|
int irq;
|
|
#ifdef CONFIG_PM
|
|
u32 irqmaskstore;
|
|
#endif
|
|
};
|
|
|
|
static irqreturn_t coh901331_interrupt(int irq, void *data)
|
|
{
|
|
struct coh901331_port *rtap = data;
|
|
|
|
clk_enable(rtap->clk);
|
|
/* Ack IRQ */
|
|
writel(1, rtap->virtbase + COH901331_IRQ_EVENT);
|
|
/*
|
|
* Disable the interrupt. This is necessary because
|
|
* the RTC lives on a lower-clocked line and will
|
|
* not release the IRQ line until after a few (slower)
|
|
* clock cycles. The interrupt will be re-enabled when
|
|
* a new alarm is set anyway.
|
|
*/
|
|
writel(0, rtap->virtbase + COH901331_IRQ_MASK);
|
|
clk_disable(rtap->clk);
|
|
|
|
/* Set alarm flag */
|
|
rtc_update_irq(rtap->rtc, 1, RTC_AF);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int coh901331_read_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(dev);
|
|
|
|
clk_enable(rtap->clk);
|
|
/* Check if the time is valid */
|
|
if (readl(rtap->virtbase + COH901331_VALID)) {
|
|
rtc_time_to_tm(readl(rtap->virtbase + COH901331_CUR_TIME), tm);
|
|
clk_disable(rtap->clk);
|
|
return rtc_valid_tm(tm);
|
|
}
|
|
clk_disable(rtap->clk);
|
|
return -EINVAL;
|
|
}
|
|
|
|
static int coh901331_set_mmss(struct device *dev, unsigned long secs)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(dev);
|
|
|
|
clk_enable(rtap->clk);
|
|
writel(secs, rtap->virtbase + COH901331_SET_TIME);
|
|
clk_disable(rtap->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int coh901331_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(dev);
|
|
|
|
clk_enable(rtap->clk);
|
|
rtc_time_to_tm(readl(rtap->virtbase + COH901331_ALARM), &alarm->time);
|
|
alarm->pending = readl(rtap->virtbase + COH901331_IRQ_EVENT) & 1U;
|
|
alarm->enabled = readl(rtap->virtbase + COH901331_IRQ_MASK) & 1U;
|
|
clk_disable(rtap->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int coh901331_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(dev);
|
|
unsigned long time;
|
|
|
|
rtc_tm_to_time(&alarm->time, &time);
|
|
clk_enable(rtap->clk);
|
|
writel(time, rtap->virtbase + COH901331_ALARM);
|
|
writel(alarm->enabled, rtap->virtbase + COH901331_IRQ_MASK);
|
|
clk_disable(rtap->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int coh901331_alarm_irq_enable(struct device *dev, unsigned int enabled)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(dev);
|
|
|
|
clk_enable(rtap->clk);
|
|
if (enabled)
|
|
writel(1, rtap->virtbase + COH901331_IRQ_MASK);
|
|
else
|
|
writel(0, rtap->virtbase + COH901331_IRQ_MASK);
|
|
clk_disable(rtap->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct rtc_class_ops coh901331_ops = {
|
|
.read_time = coh901331_read_time,
|
|
.set_mmss = coh901331_set_mmss,
|
|
.read_alarm = coh901331_read_alarm,
|
|
.set_alarm = coh901331_set_alarm,
|
|
.alarm_irq_enable = coh901331_alarm_irq_enable,
|
|
};
|
|
|
|
static int __exit coh901331_remove(struct platform_device *pdev)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
|
|
|
|
if (rtap) {
|
|
free_irq(rtap->irq, rtap);
|
|
rtc_device_unregister(rtap->rtc);
|
|
clk_put(rtap->clk);
|
|
iounmap(rtap->virtbase);
|
|
release_mem_region(rtap->phybase, rtap->physize);
|
|
platform_set_drvdata(pdev, NULL);
|
|
kfree(rtap);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
static int __init coh901331_probe(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct coh901331_port *rtap;
|
|
struct resource *res;
|
|
|
|
rtap = kzalloc(sizeof(struct coh901331_port), GFP_KERNEL);
|
|
if (!rtap)
|
|
return -ENOMEM;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res) {
|
|
ret = -ENOENT;
|
|
goto out_no_resource;
|
|
}
|
|
rtap->phybase = res->start;
|
|
rtap->physize = resource_size(res);
|
|
|
|
if (request_mem_region(rtap->phybase, rtap->physize,
|
|
"rtc-coh901331") == NULL) {
|
|
ret = -EBUSY;
|
|
goto out_no_memregion;
|
|
}
|
|
|
|
rtap->virtbase = ioremap(rtap->phybase, rtap->physize);
|
|
if (!rtap->virtbase) {
|
|
ret = -ENOMEM;
|
|
goto out_no_remap;
|
|
}
|
|
|
|
rtap->irq = platform_get_irq(pdev, 0);
|
|
if (request_irq(rtap->irq, coh901331_interrupt, IRQF_DISABLED,
|
|
"RTC COH 901 331 Alarm", rtap)) {
|
|
ret = -EIO;
|
|
goto out_no_irq;
|
|
}
|
|
|
|
rtap->clk = clk_get(&pdev->dev, NULL);
|
|
if (IS_ERR(rtap->clk)) {
|
|
ret = PTR_ERR(rtap->clk);
|
|
dev_err(&pdev->dev, "could not get clock\n");
|
|
goto out_no_clk;
|
|
}
|
|
|
|
/* We enable/disable the clock only to assure it works */
|
|
ret = clk_enable(rtap->clk);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "could not enable clock\n");
|
|
goto out_no_clk_enable;
|
|
}
|
|
clk_disable(rtap->clk);
|
|
|
|
rtap->rtc = rtc_device_register("coh901331", &pdev->dev, &coh901331_ops,
|
|
THIS_MODULE);
|
|
if (IS_ERR(rtap->rtc)) {
|
|
ret = PTR_ERR(rtap->rtc);
|
|
goto out_no_rtc;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, rtap);
|
|
|
|
return 0;
|
|
|
|
out_no_rtc:
|
|
out_no_clk_enable:
|
|
clk_put(rtap->clk);
|
|
out_no_clk:
|
|
free_irq(rtap->irq, rtap);
|
|
out_no_irq:
|
|
iounmap(rtap->virtbase);
|
|
out_no_remap:
|
|
platform_set_drvdata(pdev, NULL);
|
|
out_no_memregion:
|
|
release_mem_region(rtap->phybase, SZ_4K);
|
|
out_no_resource:
|
|
kfree(rtap);
|
|
return ret;
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int coh901331_suspend(struct platform_device *pdev, pm_message_t state)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
|
|
|
|
/*
|
|
* If this RTC alarm will be used for waking the system up,
|
|
* don't disable it of course. Else we just disable the alarm
|
|
* and await suspension.
|
|
*/
|
|
if (device_may_wakeup(&pdev->dev)) {
|
|
enable_irq_wake(rtap->irq);
|
|
} else {
|
|
clk_enable(rtap->clk);
|
|
rtap->irqmaskstore = readl(rtap->virtbase + COH901331_IRQ_MASK);
|
|
writel(0, rtap->virtbase + COH901331_IRQ_MASK);
|
|
clk_disable(rtap->clk);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int coh901331_resume(struct platform_device *pdev)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
|
|
|
|
if (device_may_wakeup(&pdev->dev)) {
|
|
disable_irq_wake(rtap->irq);
|
|
} else {
|
|
clk_enable(rtap->clk);
|
|
writel(rtap->irqmaskstore, rtap->virtbase + COH901331_IRQ_MASK);
|
|
clk_disable(rtap->clk);
|
|
}
|
|
return 0;
|
|
}
|
|
#else
|
|
#define coh901331_suspend NULL
|
|
#define coh901331_resume NULL
|
|
#endif
|
|
|
|
static void coh901331_shutdown(struct platform_device *pdev)
|
|
{
|
|
struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
|
|
|
|
clk_enable(rtap->clk);
|
|
writel(0, rtap->virtbase + COH901331_IRQ_MASK);
|
|
clk_disable(rtap->clk);
|
|
}
|
|
|
|
static struct platform_driver coh901331_driver = {
|
|
.driver = {
|
|
.name = "rtc-coh901331",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
.remove = __exit_p(coh901331_remove),
|
|
.suspend = coh901331_suspend,
|
|
.resume = coh901331_resume,
|
|
.shutdown = coh901331_shutdown,
|
|
};
|
|
|
|
static int __init coh901331_init(void)
|
|
{
|
|
return platform_driver_probe(&coh901331_driver, coh901331_probe);
|
|
}
|
|
|
|
static void __exit coh901331_exit(void)
|
|
{
|
|
platform_driver_unregister(&coh901331_driver);
|
|
}
|
|
|
|
module_init(coh901331_init);
|
|
module_exit(coh901331_exit);
|
|
|
|
MODULE_AUTHOR("Linus Walleij <linus.walleij@stericsson.com>");
|
|
MODULE_DESCRIPTION("ST-Ericsson AB COH 901 331 RTC Driver");
|
|
MODULE_LICENSE("GPL");
|