mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
6c0eb5ba35
For bus-based driver, device removal is implemented as:
1 device_remove()->
2 bus->remove()->
3 driver->remove()
Driver core needs no inform from callee(bus driver) about the
result of remove callback. In that case, commit fc7a6209d5
("bus: Make remove callback return void") forces bus_type::remove
be void-returned.
Now we have the situation that both 1 & 2 of calling chain are
void-returned, so it does not make much sense for 3(driver->remove)
to return non-void to its caller.
So the basic idea behind this change is making remove() callback of
any bus-based driver to be void-returned.
This change, for itself, is for device drivers based on acpi-bus.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Lee Jones <lee@kernel.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for drivers/platform/surface/*
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
78 lines
1.9 KiB
C
78 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* ACPI Hardware Error Device (PNP0C33) Driver
|
|
*
|
|
* Copyright (C) 2010, Intel Corp.
|
|
* Author: Huang Ying <ying.huang@intel.com>
|
|
*
|
|
* ACPI Hardware Error Device is used to report some hardware errors
|
|
* notified via SCI, mainly the corrected errors.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/acpi.h>
|
|
#include <acpi/hed.h>
|
|
|
|
static const struct acpi_device_id acpi_hed_ids[] = {
|
|
{"PNP0C33", 0},
|
|
{"", 0},
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, acpi_hed_ids);
|
|
|
|
static acpi_handle hed_handle;
|
|
|
|
static BLOCKING_NOTIFIER_HEAD(acpi_hed_notify_list);
|
|
|
|
int register_acpi_hed_notifier(struct notifier_block *nb)
|
|
{
|
|
return blocking_notifier_chain_register(&acpi_hed_notify_list, nb);
|
|
}
|
|
EXPORT_SYMBOL_GPL(register_acpi_hed_notifier);
|
|
|
|
void unregister_acpi_hed_notifier(struct notifier_block *nb)
|
|
{
|
|
blocking_notifier_chain_unregister(&acpi_hed_notify_list, nb);
|
|
}
|
|
EXPORT_SYMBOL_GPL(unregister_acpi_hed_notifier);
|
|
|
|
/*
|
|
* SCI to report hardware error is forwarded to the listeners of HED,
|
|
* it is used by HEST Generic Hardware Error Source with notify type
|
|
* SCI.
|
|
*/
|
|
static void acpi_hed_notify(struct acpi_device *device, u32 event)
|
|
{
|
|
blocking_notifier_call_chain(&acpi_hed_notify_list, 0, NULL);
|
|
}
|
|
|
|
static int acpi_hed_add(struct acpi_device *device)
|
|
{
|
|
/* Only one hardware error device */
|
|
if (hed_handle)
|
|
return -EINVAL;
|
|
hed_handle = device->handle;
|
|
return 0;
|
|
}
|
|
|
|
static void acpi_hed_remove(struct acpi_device *device)
|
|
{
|
|
hed_handle = NULL;
|
|
}
|
|
|
|
static struct acpi_driver acpi_hed_driver = {
|
|
.name = "hardware_error_device",
|
|
.class = "hardware_error",
|
|
.ids = acpi_hed_ids,
|
|
.ops = {
|
|
.add = acpi_hed_add,
|
|
.remove = acpi_hed_remove,
|
|
.notify = acpi_hed_notify,
|
|
},
|
|
};
|
|
module_acpi_driver(acpi_hed_driver);
|
|
|
|
MODULE_AUTHOR("Huang Ying");
|
|
MODULE_DESCRIPTION("ACPI Hardware Error Device Driver");
|
|
MODULE_LICENSE("GPL");
|