mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Uwe Kleine-König](/assets/img/avatar_default.png)
The driver core ignores the return value of struct device_driver::remove because there is only little that can be done. To simplify the quest to make this function return void, let struct sunxi_rsb_driver::remove return void, too. All users already unconditionally return 0, this commit makes this obvious and ensures future users don't behave differently. To simplify even further, make axp20x_device_remove() return void instead of returning 0 unconditionally, too. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
81 lines
2.2 KiB
C
81 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* RSB driver for the X-Powers' Power Management ICs
|
|
*
|
|
* AXP20x typically comprises an adaptive USB-Compatible PWM charger, BUCK DC-DC
|
|
* converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature
|
|
* as well as configurable GPIOs.
|
|
*
|
|
* This driver supports the RSB variants.
|
|
*
|
|
* Copyright (C) 2015 Chen-Yu Tsai
|
|
*
|
|
* Author: Chen-Yu Tsai <wens@csie.org>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/err.h>
|
|
#include <linux/mfd/axp20x.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sunxi-rsb.h>
|
|
|
|
static int axp20x_rsb_probe(struct sunxi_rsb_device *rdev)
|
|
{
|
|
struct axp20x_dev *axp20x;
|
|
int ret;
|
|
|
|
axp20x = devm_kzalloc(&rdev->dev, sizeof(*axp20x), GFP_KERNEL);
|
|
if (!axp20x)
|
|
return -ENOMEM;
|
|
|
|
axp20x->dev = &rdev->dev;
|
|
axp20x->irq = rdev->irq;
|
|
dev_set_drvdata(&rdev->dev, axp20x);
|
|
|
|
ret = axp20x_match_device(axp20x);
|
|
if (ret)
|
|
return ret;
|
|
|
|
axp20x->regmap = devm_regmap_init_sunxi_rsb(rdev, axp20x->regmap_cfg);
|
|
if (IS_ERR(axp20x->regmap)) {
|
|
ret = PTR_ERR(axp20x->regmap);
|
|
dev_err(&rdev->dev, "regmap init failed: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return axp20x_device_probe(axp20x);
|
|
}
|
|
|
|
static void axp20x_rsb_remove(struct sunxi_rsb_device *rdev)
|
|
{
|
|
struct axp20x_dev *axp20x = sunxi_rsb_device_get_drvdata(rdev);
|
|
|
|
axp20x_device_remove(axp20x);
|
|
}
|
|
|
|
static const struct of_device_id axp20x_rsb_of_match[] = {
|
|
{ .compatible = "x-powers,axp223", .data = (void *)AXP223_ID },
|
|
{ .compatible = "x-powers,axp803", .data = (void *)AXP803_ID },
|
|
{ .compatible = "x-powers,axp806", .data = (void *)AXP806_ID },
|
|
{ .compatible = "x-powers,axp809", .data = (void *)AXP809_ID },
|
|
{ .compatible = "x-powers,axp813", .data = (void *)AXP813_ID },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, axp20x_rsb_of_match);
|
|
|
|
static struct sunxi_rsb_driver axp20x_rsb_driver = {
|
|
.driver = {
|
|
.name = "axp20x-rsb",
|
|
.of_match_table = of_match_ptr(axp20x_rsb_of_match),
|
|
},
|
|
.probe = axp20x_rsb_probe,
|
|
.remove = axp20x_rsb_remove,
|
|
};
|
|
module_sunxi_rsb_driver(axp20x_rsb_driver);
|
|
|
|
MODULE_DESCRIPTION("PMIC MFD sunXi RSB driver for AXP20X");
|
|
MODULE_AUTHOR("Chen-Yu Tsai <wens@csie.org>");
|
|
MODULE_LICENSE("GPL v2");
|