mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
118 lines
2.6 KiB
C
118 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Driver for the Analog Devices digital potentiometers (I2C bus)
|
|
*
|
|
* Copyright (C) 2010-2011 Michael Hennerich, Analog Devices Inc.
|
|
*/
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "ad525x_dpot.h"
|
|
|
|
/* I2C bus functions */
|
|
static int write_d8(void *client, u8 val)
|
|
{
|
|
return i2c_smbus_write_byte(client, val);
|
|
}
|
|
|
|
static int write_r8d8(void *client, u8 reg, u8 val)
|
|
{
|
|
return i2c_smbus_write_byte_data(client, reg, val);
|
|
}
|
|
|
|
static int write_r8d16(void *client, u8 reg, u16 val)
|
|
{
|
|
return i2c_smbus_write_word_data(client, reg, val);
|
|
}
|
|
|
|
static int read_d8(void *client)
|
|
{
|
|
return i2c_smbus_read_byte(client);
|
|
}
|
|
|
|
static int read_r8d8(void *client, u8 reg)
|
|
{
|
|
return i2c_smbus_read_byte_data(client, reg);
|
|
}
|
|
|
|
static int read_r8d16(void *client, u8 reg)
|
|
{
|
|
return i2c_smbus_read_word_data(client, reg);
|
|
}
|
|
|
|
static const struct ad_dpot_bus_ops bops = {
|
|
.read_d8 = read_d8,
|
|
.read_r8d8 = read_r8d8,
|
|
.read_r8d16 = read_r8d16,
|
|
.write_d8 = write_d8,
|
|
.write_r8d8 = write_r8d8,
|
|
.write_r8d16 = write_r8d16,
|
|
};
|
|
|
|
static int ad_dpot_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct ad_dpot_bus_data bdata = {
|
|
.client = client,
|
|
.bops = &bops,
|
|
};
|
|
|
|
if (!i2c_check_functionality(client->adapter,
|
|
I2C_FUNC_SMBUS_WORD_DATA)) {
|
|
dev_err(&client->dev, "SMBUS Word Data not Supported\n");
|
|
return -EIO;
|
|
}
|
|
|
|
return ad_dpot_probe(&client->dev, &bdata, id->driver_data, id->name);
|
|
}
|
|
|
|
static void ad_dpot_i2c_remove(struct i2c_client *client)
|
|
{
|
|
ad_dpot_remove(&client->dev);
|
|
}
|
|
|
|
static const struct i2c_device_id ad_dpot_id[] = {
|
|
{"ad5258", AD5258_ID},
|
|
{"ad5259", AD5259_ID},
|
|
{"ad5251", AD5251_ID},
|
|
{"ad5252", AD5252_ID},
|
|
{"ad5253", AD5253_ID},
|
|
{"ad5254", AD5254_ID},
|
|
{"ad5255", AD5255_ID},
|
|
{"ad5241", AD5241_ID},
|
|
{"ad5242", AD5242_ID},
|
|
{"ad5243", AD5243_ID},
|
|
{"ad5245", AD5245_ID},
|
|
{"ad5246", AD5246_ID},
|
|
{"ad5247", AD5247_ID},
|
|
{"ad5248", AD5248_ID},
|
|
{"ad5280", AD5280_ID},
|
|
{"ad5282", AD5282_ID},
|
|
{"adn2860", ADN2860_ID},
|
|
{"ad5273", AD5273_ID},
|
|
{"ad5161", AD5161_ID},
|
|
{"ad5171", AD5171_ID},
|
|
{"ad5170", AD5170_ID},
|
|
{"ad5172", AD5172_ID},
|
|
{"ad5173", AD5173_ID},
|
|
{"ad5272", AD5272_ID},
|
|
{"ad5274", AD5274_ID},
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, ad_dpot_id);
|
|
|
|
static struct i2c_driver ad_dpot_i2c_driver = {
|
|
.driver = {
|
|
.name = "ad_dpot",
|
|
},
|
|
.probe = ad_dpot_i2c_probe,
|
|
.remove = ad_dpot_i2c_remove,
|
|
.id_table = ad_dpot_id,
|
|
};
|
|
|
|
module_i2c_driver(ad_dpot_i2c_driver);
|
|
|
|
MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
|
|
MODULE_DESCRIPTION("digital potentiometer I2C bus driver");
|
|
MODULE_LICENSE("GPL");
|