Linus Torvalds f6f3732162 Revert "mm: replace p??_write with pte_access_permitted in fault + gup paths" ... This reverts commits 5c9d2d5c26, c7da82b894, and e7fe7b5cae. We'll probably need to revisit this, but basically we should not complicate the get_user_pages_fast() case, and checking the actual page table protection key bits will require more care anyway, since the protection keys depend on the exact state of the VM in question. Particularly when doing a "remote" page lookup (ie in somebody elses VM, not your own), you need to be much more careful than this was. Dave Hansen says: "So, the underlying bug here is that we now a get_user_pages_remote() and then go ahead and do the p*_access_permitted() checks against the current PKRU. This was introduced recently with the addition of the new p??_access_permitted() calls. We have checks in the VMA path for the "remote" gups and we avoid consulting PKRU for them. This got missed in the pkeys selftests because I did a ptrace read, but not a *write*. I also didn't explicitly test it against something where a COW needed to be done" It's also not entirely clear that it makes sense to check the protection key bits at this level at all. But one possible eventual solution is to make the get_user_pages_fast() case just abort if it sees protection key bits set, which makes us fall back to the regular get_user_pages() case, which then has a vma and can do the check there if we want to. We'll see. Somewhat related to this all: what we _do_ want to do some day is to check the PAGE_USER bit - it should obviously always be set for user pages, but it would be a good check to have back. Because we have no generic way to test for it, we lost it as part of moving over from the architecture-specific x86 GUP implementation to the generic one in commit e585513b76 ("x86/mm/gup: Switch GUP to the generic get_user_page_fast() implementation"). Cc: Peter Zijlstra <peterz@infradead.org> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2017-12-15 18:53:22 -08:00
..
9p	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
adfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
affs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
afs	afs: Properly reset afs_vnode (inode) fields	2017-12-01 11:51:24 +00:00
autofs4	autofs: fix careless error in recent commit	2017-12-14 16:00:48 -08:00
befs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
bfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
btrfs	for-4.15-rc3-tag	2017-12-10 08:30:04 -08:00
cachefiles	mm: remove __GFP_COLD	2017-11-15 18:21:06 -08:00
ceph	ceph: drop negative child dentries before try pruning inode's alias	2017-12-08 11:07:12 +01:00
cifs	CIFS: don't log STATUS_NOT_FOUND errors for DFS	2017-12-06 12:48:01 -06:00
coda	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
configfs
cramfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
crypto	fscrypt: lots of cleanups, mostly courtesy by Eric Biggers	2017-11-14 11:35:15 -08:00
debugfs	debugfs: Remove redundant license text	2017-11-07 20:25:03 +01:00
devpts
dlm	A couple of configfs cleanups:	2017-11-14 14:44:04 -08:00
ecryptfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
efivarfs
efs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
exofs
exportfs
ext2	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
ext4	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
f2fs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
fat	fs/fat/inode.c: fix sb_rdonly() change	2017-11-29 18:40:43 -08:00
freevxfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
fscache	AFS development	2017-11-16 11:41:22 -08:00
fuse	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
gfs2	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
hfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
hfsplus	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
hostfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hpfs	hpfs: don't bother with the i_version counter or f_version	2017-12-10 12:58:18 -08:00
hugetlbfs	fs/hugetlbfs/inode.c: change put_page/unlock_page order in hugetlbfs_fallocate()	2017-11-29 18:40:43 -08:00
isofs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
jbd2	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
jffs2	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
jfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
kernfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
lockd	nlm_shutdown_hosts_net() cleanup	2017-11-27 16:45:11 -05:00
minix	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
ncpfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
nfs	NFS client fixes for Linux 4.15-rc2	2017-12-01 20:04:20 -05:00
nfs_common	lockd: fix "list_add double add" caused by legacy signal interface	2017-11-27 16:45:11 -05:00
nfsd	kernel: make groups_sort calling a responsibility group_info allocators	2017-12-14 16:00:49 -08:00
nilfs2	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
nls	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
notify	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
ntfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
ocfs2	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
omfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
openpromfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
orangefs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
overlayfs	ovl: fix overlay: warning prefix	2017-12-14 11:14:52 +01:00
proc	proc: show si_ptr in /proc/<pid>/timers without hashing	2017-12-06 18:23:27 -08:00
pstore	treewide: Switch DEFINE_TIMER callbacks to struct timer_list *	2017-11-21 15:57:05 -08:00
qnx4	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
qnx6	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
quota	quota: Check for register_shrinker() failure.	2017-11-29 16:46:48 +01:00
ramfs
reiserfs	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2017-11-30 18:38:47 -05:00
romfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
squashfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
sysfs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
sysv	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
tracefs
ubifs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
udf	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
ufs	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
xfs	Changes since last update:	2017-12-13 20:15:49 -08:00
aio.c	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
anon_inodes.c
attr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bad_inode.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_aout.c
binfmt_elf.c	Merge branch 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm	2017-11-16 12:50:35 -08:00
binfmt_elf_fdpic.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:54:01 -08:00
binfmt_em86.c
binfmt_flat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_misc.c
binfmt_script.c
block_dev.c	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
buffer.c	mm, pagevec: remove cold parameter for pagevecs	2017-11-15 18:21:06 -08:00
char_dev.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:54:01 -08:00
coredump.c	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
dax.c	Revert "mm: replace p??_write with pte_access_permitted in fault + gup paths"	2017-12-15 18:53:22 -08:00
dcache.c	kmemcheck: remove annotations	2017-11-15 18:21:04 -08:00
dcookies.c
direct-io.c	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
drop_caches.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
eventfd.c
eventpoll.c	Merge branch 'akpm' (patches from Andrew)	2017-11-17 16:56:17 -08:00
exec.c	exec: avoid gcc-8 warning for get_task_comm	2017-12-14 16:00:48 -08:00
fcntl.c	fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall	2017-11-15 08:08:36 -05:00
fhandle.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:54:01 -08:00
file.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:54:01 -08:00
file_table.c	fs, mm: account filp cache to kmemcg	2017-11-15 18:21:04 -08:00
filesystems.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs-writeback.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
fs_pin.c	Merge branch 'linus' into locking/core, to resolve conflicts	2017-11-07 10:32:44 +01:00
fs_struct.c
inode.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
internal.h	fs: expose do_unlinkat for built-in callers	2017-11-10 08:48:46 -05:00
ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iomap.c	Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:08:18 -08:00
Kconfig
Kconfig.binfmt
libfs.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
locks.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mbcache.c	fs/mbcache.c: make count_objects() more robust	2017-11-29 18:40:43 -08:00
mount.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mpage.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
namei.c	autofs: revert "autofs: fix AT_NO_AUTOMOUNT not being honored"	2017-11-29 18:40:43 -08:00
namespace.c	vfs: fix mounting a filesystem with i_version	2017-11-08 15:16:36 -05:00
no-block.c
nsfs.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
open.c
pipe.c	pipe: add proc_dopipe_max_size() to safely assign pipe_max_size	2017-11-17 16:10:03 -08:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
read_write.c	Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:08:18 -08:00
readdir.c	Merge branch 'linus' into locking/core, to resolve conflicts	2017-11-07 10:32:44 +01:00
select.c	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
seq_file.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
signalfd.c	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
splice.c
stack.c
stat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
statfs.c	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
super.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:54:01 -08:00
sync.c	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
timerfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
userfaultfd.c	userfaultfd: use mmgrab instead of open-coded increment of mm_count	2017-11-15 18:21:05 -08:00
utimes.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xattr.c