John Fastabend f87e62d45e net/tls: remove close callback sock unlock/lock around TX work flush ... The tls close() callback currently drops the sock lock, makes a cancel_delayed_work_sync() call, and then relocks the sock. By restructuring the code we can avoid droping lock and then reclaiming it. To simplify this we do the following, tls_sk_proto_close set_bit(CLOSING) set_bit(SCHEDULE) cancel_delay_work_sync() <- cancel workqueue lock_sock(sk) ... release_sock(sk) strp_done() Setting the CLOSING bit prevents the SCHEDULE bit from being cleared by any workqueue items e.g. if one happens to be scheduled and run between when we set SCHEDULE bit and cancel work. Then because SCHEDULE bit is set now no new work will be scheduled. Tested with net selftests and bpf selftests. Signed-off-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>		2019-07-22 16:04:16 +02:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
tls_device.c	net/tls: don't arm strparser immediately in tls_set_sw_offload()	2019-07-22 16:04:16 +02:00
tls_device_fallback.c	net/tls: fix socket wmem accounting on fallback with netem	2019-07-08 20:21:10 -07:00
tls_main.c	net/tls: remove close callback sock unlock/lock around TX work flush	2019-07-22 16:04:16 +02:00
tls_sw.c	net/tls: remove close callback sock unlock/lock around TX work flush	2019-07-22 16:04:16 +02:00