mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Stephen Boyd](/assets/img/avatar_default.png)
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
130 lines
3.2 KiB
C
130 lines
3.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) ST-Ericsson SA 2010
|
|
*
|
|
* Author: Sundar Iyer <sundar.iyer@stericsson.com> for ST-Ericsson
|
|
*
|
|
* AB8500 Power-On Key handler
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/input.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/mfd/abx500/ab8500.h>
|
|
#include <linux/of.h>
|
|
#include <linux/slab.h>
|
|
|
|
/**
|
|
* struct ab8500_ponkey - ab8500 ponkey information
|
|
* @input_dev: pointer to input device
|
|
* @ab8500: ab8500 parent
|
|
* @irq_dbf: irq number for falling transition
|
|
* @irq_dbr: irq number for rising transition
|
|
*/
|
|
struct ab8500_ponkey {
|
|
struct input_dev *idev;
|
|
struct ab8500 *ab8500;
|
|
int irq_dbf;
|
|
int irq_dbr;
|
|
};
|
|
|
|
/* AB8500 gives us an interrupt when ONKEY is held */
|
|
static irqreturn_t ab8500_ponkey_handler(int irq, void *data)
|
|
{
|
|
struct ab8500_ponkey *ponkey = data;
|
|
|
|
if (irq == ponkey->irq_dbf)
|
|
input_report_key(ponkey->idev, KEY_POWER, true);
|
|
else if (irq == ponkey->irq_dbr)
|
|
input_report_key(ponkey->idev, KEY_POWER, false);
|
|
|
|
input_sync(ponkey->idev);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int ab8500_ponkey_probe(struct platform_device *pdev)
|
|
{
|
|
struct ab8500 *ab8500 = dev_get_drvdata(pdev->dev.parent);
|
|
struct ab8500_ponkey *ponkey;
|
|
struct input_dev *input;
|
|
int irq_dbf, irq_dbr;
|
|
int error;
|
|
|
|
irq_dbf = platform_get_irq_byname(pdev, "ONKEY_DBF");
|
|
if (irq_dbf < 0)
|
|
return irq_dbf;
|
|
|
|
irq_dbr = platform_get_irq_byname(pdev, "ONKEY_DBR");
|
|
if (irq_dbr < 0)
|
|
return irq_dbr;
|
|
|
|
ponkey = devm_kzalloc(&pdev->dev, sizeof(struct ab8500_ponkey),
|
|
GFP_KERNEL);
|
|
if (!ponkey)
|
|
return -ENOMEM;
|
|
|
|
input = devm_input_allocate_device(&pdev->dev);
|
|
if (!input)
|
|
return -ENOMEM;
|
|
|
|
ponkey->idev = input;
|
|
ponkey->ab8500 = ab8500;
|
|
ponkey->irq_dbf = irq_dbf;
|
|
ponkey->irq_dbr = irq_dbr;
|
|
|
|
input->name = "AB8500 POn(PowerOn) Key";
|
|
input->dev.parent = &pdev->dev;
|
|
|
|
input_set_capability(input, EV_KEY, KEY_POWER);
|
|
|
|
error = devm_request_any_context_irq(&pdev->dev, ponkey->irq_dbf,
|
|
ab8500_ponkey_handler, 0,
|
|
"ab8500-ponkey-dbf", ponkey);
|
|
if (error < 0) {
|
|
dev_err(ab8500->dev, "Failed to request dbf IRQ#%d: %d\n",
|
|
ponkey->irq_dbf, error);
|
|
return error;
|
|
}
|
|
|
|
error = devm_request_any_context_irq(&pdev->dev, ponkey->irq_dbr,
|
|
ab8500_ponkey_handler, 0,
|
|
"ab8500-ponkey-dbr", ponkey);
|
|
if (error < 0) {
|
|
dev_err(ab8500->dev, "Failed to request dbr IRQ#%d: %d\n",
|
|
ponkey->irq_dbr, error);
|
|
return error;
|
|
}
|
|
|
|
error = input_register_device(ponkey->idev);
|
|
if (error) {
|
|
dev_err(ab8500->dev, "Can't register input device: %d\n", error);
|
|
return error;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id ab8500_ponkey_match[] = {
|
|
{ .compatible = "stericsson,ab8500-ponkey", },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ab8500_ponkey_match);
|
|
#endif
|
|
|
|
static struct platform_driver ab8500_ponkey_driver = {
|
|
.driver = {
|
|
.name = "ab8500-poweron-key",
|
|
.of_match_table = of_match_ptr(ab8500_ponkey_match),
|
|
},
|
|
.probe = ab8500_ponkey_probe,
|
|
};
|
|
module_platform_driver(ab8500_ponkey_driver);
|
|
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_AUTHOR("Sundar Iyer <sundar.iyer@stericsson.com>");
|
|
MODULE_DESCRIPTION("ST-Ericsson AB8500 Power-ON(Pon) Key driver");
|