mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
![David Howells](/assets/img/avatar_default.png)
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead of passing regs around manually through all ~1800 interrupt handlers in the Linux kernel. The regs pointer is used in few places, but it potentially costs both stack space and code to pass it around. On the FRV arch, removing the regs parameter from all the genirq function results in a 20% speed up of the IRQ exit path (ie: from leaving timer_interrupt() to leaving do_IRQ()). Where appropriate, an arch may override the generic storage facility and do something different with the variable. On FRV, for instance, the address is maintained in GR28 at all times inside the kernel as part of general exception handling. Having looked over the code, it appears that the parameter may be handed down through up to twenty or so layers of functions. Consider a USB character device attached to a USB hub, attached to a USB controller that posts its interrupts through a cascaded auxiliary interrupt controller. A character device driver may want to pass regs to the sysrq handler through the input layer which adds another few layers of parameter passing. I've build this code with allyesconfig for x86_64 and i386. I've runtested the main part of the code on FRV and i386, though I can't test most of the drivers. I've also done partial conversion for powerpc and MIPS - these at least compile with minimal configurations. This will affect all archs. Mostly the changes should be relatively easy. Take do_IRQ(), store the regs pointer at the beginning, saving the old one: struct pt_regs *old_regs = set_irq_regs(regs); And put the old one back at the end: set_irq_regs(old_regs); Don't pass regs through to generic_handle_irq() or __do_IRQ(). In timer_interrupt(), this sort of change will be necessary: - update_process_times(user_mode(regs)); - profile_tick(CPU_PROFILING, regs); + update_process_times(user_mode(get_irq_regs())); + profile_tick(CPU_PROFILING); I'd like to move update_process_times()'s use of get_irq_regs() into itself, except that i386, alone of the archs, uses something other than user_mode(). Some notes on the interrupt handling in the drivers: (*) input_dev() is now gone entirely. The regs pointer is no longer stored in the input_dev struct. (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does something different depending on whether it's been supplied with a regs pointer or not. (*) Various IRQ handler function pointers have been moved to type irq_handler_t. Signed-Off-By: David Howells <dhowells@redhat.com> (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
47 lines
1.5 KiB
C
47 lines
1.5 KiB
C
/*
|
|
* drivers/parisc/gsc.h
|
|
* Declarations for functions in gsc.c
|
|
* Copyright (c) 2000-2002 Helge Deller, Matthew Wilcox
|
|
*
|
|
* Distributed under the terms of the GPL, version 2
|
|
*/
|
|
|
|
#include <linux/interrupt.h>
|
|
#include <asm/hardware.h>
|
|
#include <asm/parisc-device.h>
|
|
|
|
#define OFFSET_IRR 0x0000 /* Interrupt request register */
|
|
#define OFFSET_IMR 0x0004 /* Interrupt mask register */
|
|
#define OFFSET_IPR 0x0008 /* Interrupt pending register */
|
|
#define OFFSET_ICR 0x000C /* Interrupt control register */
|
|
#define OFFSET_IAR 0x0010 /* Interrupt address register */
|
|
|
|
/* PA I/O Architected devices support at least 5 bits in the EIM register. */
|
|
#define GSC_EIM_WIDTH 5
|
|
|
|
struct gsc_irq {
|
|
unsigned long txn_addr; /* IRQ "target" */
|
|
int txn_data; /* HW "IRQ" */
|
|
int irq; /* virtual IRQ */
|
|
};
|
|
|
|
struct gsc_asic {
|
|
struct parisc_device *gsc;
|
|
unsigned long hpa;
|
|
char *name;
|
|
int version;
|
|
int type;
|
|
int eim;
|
|
int global_irq[32];
|
|
};
|
|
|
|
int gsc_common_setup(struct parisc_device *parent, struct gsc_asic *gsc_asic);
|
|
int gsc_alloc_irq(struct gsc_irq *dev); /* dev needs an irq */
|
|
int gsc_claim_irq(struct gsc_irq *dev, int irq); /* dev needs this irq */
|
|
int gsc_assign_irq(struct hw_interrupt_type *type, void *data);
|
|
int gsc_find_local_irq(unsigned int irq, int *global_irq, int limit);
|
|
void gsc_fixup_irqs(struct parisc_device *parent, void *ctrl,
|
|
void (*choose)(struct parisc_device *child, void *ctrl));
|
|
void gsc_asic_assign_irq(struct gsc_asic *asic, int local_irq, int *irqp);
|
|
|
|
irqreturn_t gsc_asic_intr(int irq, void *dev);
|