mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Hans de Goede](/assets/img/avatar_default.png)
Most PMIC-s use only a single i2c-address, so after verifying the i2c-address matches, we can simply pass the call to regmap_update_bits. This commit adds support for this and hooks this up for the xpower AXP288 PMIC by setting the new pmic_i2c_address field. This fixes the following errors on display on / off on a Jumper Ezpad mini 3 and an Onda V80 plus tablet, both of which use the AXP288: intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x34 reg-addr ... [drm:mipi_exec_pmic [i915]] *ERROR* mipi_exec_pmic failed, error: -95 Instead of these errors on both devices we now correctly turn on / off DLDO3 (through direct register manipulation). On the Onda V80 plus this fixes an issue with the backlight being brighter around the borders after an off / on cycle. This should also help to save some power when the display is off. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190107111556.4510-4-hdegoede@redhat.com
30 lines
1.1 KiB
C
30 lines
1.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __INTEL_PMIC_H
|
|
#define __INTEL_PMIC_H
|
|
|
|
struct pmic_table {
|
|
int address; /* operation region address */
|
|
int reg; /* corresponding thermal register */
|
|
int bit; /* control bit for power */
|
|
};
|
|
|
|
struct intel_pmic_opregion_data {
|
|
int (*get_power)(struct regmap *r, int reg, int bit, u64 *value);
|
|
int (*update_power)(struct regmap *r, int reg, int bit, bool on);
|
|
int (*get_raw_temp)(struct regmap *r, int reg);
|
|
int (*update_aux)(struct regmap *r, int reg, int raw_temp);
|
|
int (*get_policy)(struct regmap *r, int reg, int bit, u64 *value);
|
|
int (*update_policy)(struct regmap *r, int reg, int bit, int enable);
|
|
int (*exec_mipi_pmic_seq_element)(struct regmap *r, u16 i2c_address,
|
|
u32 reg_address, u32 value, u32 mask);
|
|
struct pmic_table *power_table;
|
|
int power_table_count;
|
|
struct pmic_table *thermal_table;
|
|
int thermal_table_count;
|
|
/* For generic exec_mipi_pmic_seq_element handling */
|
|
int pmic_i2c_address;
|
|
};
|
|
|
|
int intel_pmic_install_opregion_handler(struct device *dev, acpi_handle handle, struct regmap *regmap, struct intel_pmic_opregion_data *d);
|
|
|
|
#endif
|