mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity
linux-stable/drivers/char/ipmi
History
Yi Yang cbb7d8a4b4 ipmi_si: fix a memleak in try_smi_init() 
commit 6cf1a126de upstream.

Kmemleak reported the following leak info in try_smi_init():

unreferenced object 0xffff00018ecf9400 (size 1024):
  comm "modprobe", pid 2707763, jiffies 4300851415 (age 773.308s)
  backtrace:
    [<000000004ca5b312>] __kmalloc+0x4b8/0x7b0
    [<00000000953b1072>] try_smi_init+0x148/0x5dc [ipmi_si]
    [<000000006460d325>] 0xffff800081b10148
    [<0000000039206ea5>] do_one_initcall+0x64/0x2a4
    [<00000000601399ce>] do_init_module+0x50/0x300
    [<000000003c12ba3c>] load_module+0x7a8/0x9e0
    [<00000000c246fffe>] __se_sys_init_module+0x104/0x180
    [<00000000eea99093>] __arm64_sys_init_module+0x24/0x30
    [<0000000021b1ef87>] el0_svc_common.constprop.0+0x94/0x250
    [<0000000070f4f8b7>] do_el0_svc+0x48/0xe0
    [<000000005a05337f>] el0_svc+0x24/0x3c
    [<000000005eb248d6>] el0_sync_handler+0x160/0x164
    [<0000000030a59039>] el0_sync+0x160/0x180

The problem was that when an error occurred before handlers registration
and after allocating `new_smi->si_sm`, the variable wouldn't be freed in
the error handling afterwards since `shutdown_smi()` hadn't been
registered yet. Fix it by adding a `kfree()` in the error handling path
in `try_smi_init()`.

Cc: stable@vger.kernel.org # 4.19+
Fixes: 7960f18a56 ("ipmi_si: Convert over to a shutdown handler")
Signed-off-by: Yi Yang <yiyang13@huawei.com>
Co-developed-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
Message-Id: <20230629123328.2402075-1-gongruiqi@huaweicloud.com>
Signed-off-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2023-09-19 12:22:50 +02:00
..
Kconfig ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it 2023-05-11 23:00:31 +09:00
Makefile
…
bt-bmc.c
…
ipmb_dev_int.c
…
ipmi_bt_sm.c
…
ipmi_devintf.c
…
ipmi_dmi.c
…
ipmi_dmi.h
…
ipmi_kcs_sm.c
…
ipmi_msghandler.c ipmi: fix use after free in _ipmi_destroy_user() 2023-01-12 11:58:57 +01:00
ipmi_plat_data.c
…
ipmi_plat_data.h
…
ipmi_powernv.c
…
ipmi_poweroff.c
…
ipmi_si.h parisc: Make struct parisc_driver::remove() return void 2021-08-30 10:18:25 +02:00
ipmi_si_hardcode.c
…
ipmi_si_hotmod.c
…
ipmi_si_intf.c ipmi_si: fix a memleak in try_smi_init() 2023-09-19 12:22:50 +02:00
ipmi_si_mem_io.c
…
ipmi_si_parisc.c parisc: Make struct parisc_driver::remove() return void 2021-08-30 10:18:25 +02:00
ipmi_si_pci.c
…
ipmi_si_platform.c parisc: Make struct parisc_driver::remove() return void 2021-08-30 10:18:25 +02:00
ipmi_si_port_io.c
…
ipmi_si_sm.h
…
ipmi_smic_sm.c
…
ipmi_ssif.c ipmi:ssif: Fix a memory leak when scanning for an adapter 2023-09-19 12:22:40 +02:00
ipmi_watchdog.c ipmi: Disable some operations during a panic 2021-11-18 19:16:13 +01:00
kcs_bmc.c
…
kcs_bmc.h
…
kcs_bmc_aspeed.c ipmi: kcs: Poll OBF briefly to reduce OBE latency 2022-12-31 13:14:06 +01:00
kcs_bmc_cdev_ipmi.c
…
kcs_bmc_client.h
…
kcs_bmc_device.h
…
kcs_bmc_npcm7xx.c
…
kcs_bmc_serio.c ipmi: kcs_bmc: Fix a memory leak in the error handling path of 'kcs_bmc_serio_add_device()' 2021-11-18 19:16:44 +01:00