Oliver Hartkopp 3cb476cf83 can: isotp: fix tx state handling for echo tx processing ... commit 866337865f upstream. In commit 4b7fe92c06 ("can: isotp: add local echo tx processing for consecutive frames") the data flow for consecutive frames (CF) has been reworked to improve the reliability of long data transfers. This rework did not touch the transmission and the tx state changes of single frame (SF) transfers which likely led to the WARN in the isotp_tx_timer_handler() catching a wrong tx state. This patch makes use of the improved frame processing for SF frames and sets the ISOTP_SENDING state in isotp_sendmsg() within the cmpxchg() condition handling. A review of the state machine and the timer handling additionally revealed a missing echo timeout handling in the case of the burst mode in isotp_rcv_echo() and removes a potential timer configuration uncertainty in isotp_rcv_fc() when the receiver requests consecutive frames. Fixes: 4b7fe92c06 ("can: isotp: add local echo tx processing for consecutive frames") Link: https://lore.kernel.org/linux-can/CAO4mrfe3dG7cMP1V5FLUkw7s+50c9vichigUMQwsxX4M=45QEw@mail.gmail.com/T/#u Reported-by: Wei Chen <harperchen1110@gmail.com> Cc: stable@vger.kernel.org # v6.0 Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net> Link: https://lore.kernel.org/all/20221104142551.16924-1-socketcan@hartkopp.net Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-11-16 10:04:10 +01:00
..
j1939	can: j1939: j1939_send_one(): fix missing CAN header initialization	2022-11-16 10:04:10 +01:00
af_can.c	can: af_can: fix NULL pointer dereference in can_rx_register()	2022-11-16 10:03:56 +01:00
af_can.h	can: introduce CAN midlayer private and allocate it automatically	2019-09-04 13:29:14 +02:00
bcm.c	can: bcm: check the result of can_send() in bcm_can_tx()	2022-10-21 12:39:10 +02:00
gw.c	can: gw: use call_rcu() instead of costly synchronize_rcu()	2022-02-24 08:26:03 +01:00
isotp.c	can: isotp: fix tx state handling for echo tx processing	2022-11-16 10:04:10 +01:00
Kconfig	net: Kconfig: move the CAN device menu to the "Device Drivers" section	2022-06-11 17:11:02 +02:00
Makefile	can: add ISO 15765-2:2016 transport protocol	2020-10-07 23:18:33 +02:00
proc.c	proc: remove PDE_DATA() completely	2022-01-22 08:33:37 +02:00
raw.c	can: raw: add support for SO_TXTIME/SCM_TXTIME	2022-05-16 22:03:45 +02:00