Baokun Li 18881d7e51 ext4: fix race condition between ext4_write and ext4_convert_inline_data ... commit f87c7a4b08 upstream. Hulk Robot reported a BUG_ON: ================================================================== EXT4-fs error (device loop3): ext4_mb_generate_buddy:805: group 0, block bitmap and bg descriptor inconsistent: 25 vs 31513 free clusters kernel BUG at fs/ext4/ext4_jbd2.c:53! invalid opcode: 0000 [#1] SMP KASAN PTI CPU: 0 PID: 25371 Comm: syz-executor.3 Not tainted 5.10.0+ #1 RIP: 0010:ext4_put_nojournal fs/ext4/ext4_jbd2.c:53 [inline] RIP: 0010:__ext4_journal_stop+0x10e/0x110 fs/ext4/ext4_jbd2.c:116 [...] Call Trace: ext4_write_inline_data_end+0x59a/0x730 fs/ext4/inline.c:795 generic_perform_write+0x279/0x3c0 mm/filemap.c:3344 ext4_buffered_write_iter+0x2e3/0x3d0 fs/ext4/file.c:270 ext4_file_write_iter+0x30a/0x11c0 fs/ext4/file.c:520 do_iter_readv_writev+0x339/0x3c0 fs/read_write.c:732 do_iter_write+0x107/0x430 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x1e5/0x380 fs/read_write.c:1031 [...] ================================================================== Above issue may happen as follows: cpu1 cpu2 __________________________|__________________________ do_pwritev vfs_writev do_iter_write ext4_file_write_iter ext4_buffered_write_iter generic_perform_write ext4_da_write_begin vfs_fallocate ext4_fallocate ext4_convert_inline_data ext4_convert_inline_data_nolock ext4_destroy_inline_data_nolock clear EXT4_STATE_MAY_INLINE_DATA ext4_map_blocks ext4_ext_map_blocks ext4_mb_new_blocks ext4_mb_regular_allocator ext4_mb_good_group_nolock ext4_mb_init_group ext4_mb_init_cache ext4_mb_generate_buddy --> error ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA) ext4_restore_inline_data set EXT4_STATE_MAY_INLINE_DATA ext4_block_write_begin ext4_da_write_end ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA) ext4_write_inline_data_end handle=NULL ext4_journal_stop(handle) __ext4_journal_stop ext4_put_nojournal(handle) ref_cnt = (unsigned long)handle BUG_ON(ref_cnt == 0) ---> BUG_ON The lock held by ext4_convert_inline_data is xattr_sem, but the lock held by generic_perform_write is i_rwsem. Therefore, the two locks can be concurrent. To solve above issue, we add inode_lock() for ext4_convert_inline_data(). At the same time, move ext4_convert_inline_data() in front of ext4_punch_hole(), remove similar handling from ext4_punch_hole(). Fixes: 0c8d414f16 ("ext4: let fallocate handle inline data correctly") Cc: stable@vger.kernel.org Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Baokun Li <libaokun1@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20220428134031.4153381-1-libaokun1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-07-21 20:59:18 +02:00
..
acl.c
acl.h
balloc.c	ext4: shrink race window in ext4_should_retry_alloc()	2021-04-07 14:47:38 +02:00
bitmap.c
block_validity.c	ext4: correctly restore system zone info when remount fails	2020-09-03 11:26:57 +02:00
dir.c	ext4: fix potential infinite loop in ext4_dx_readdir()	2021-10-06 15:42:37 +02:00
ext4.h	ext4: fix use-after-free in ext4_search_dir	2022-04-27 13:50:50 +02:00
ext4_extents.h	ext4: fix EXT_MAX_EXTENT/INDEX to check for zeroed eh_max	2020-06-22 09:31:15 +02:00
ext4_jbd2.c
ext4_jbd2.h	ext4: use jbd2_inode dirty range scoping	2019-06-20 17:26:26 -04:00
extents.c	ext4: fix race condition between ext4_write and ext4_convert_inline_data	2022-07-21 20:59:18 +02:00
extents_status.c	ext4: remove check for zero nr_to_scan in ext4_es_scan()	2021-07-14 16:53:03 +02:00
extents_status.h	ext4: use percpu_counters for extent_status cache hits/misses	2019-08-28 11:19:23 -04:00
file.c	ext4: don't leak old mountpoint samples	2021-01-19 18:26:13 +01:00
fsmap.c	ext4: limit entries returned when counting fsmap records	2020-10-29 09:57:55 +01:00
fsmap.h
fsync.c	ext4: fix race between ext4_sync_parent() and rename()	2020-06-22 09:31:16 +02:00
hash.c	ext4: fix kernel oops caused by spurious casefold flag	2019-09-03 01:43:17 -04:00
ialloc.c	ext4: fix avefreec in find_group_orlov	2021-07-14 16:53:03 +02:00
indirect.c	ext4: clean up kerneldoc warnigns when building with W=1	2019-06-19 16:30:03 -04:00
inline.c	ext4: fix bug_on in ext4_writepages	2022-06-14 18:11:45 +02:00
inode.c	ext4: fix race condition between ext4_write and ext4_convert_inline_data	2022-07-21 20:59:18 +02:00
ioctl.c	ext4: avoid trim error on fs with small groups	2022-01-27 09:19:37 +01:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	ext4: add basic fs-verity support	2019-08-12 19:33:50 -07:00
mballoc.c	ext4: fix bug_on ext4_mb_use_inode_pa	2022-06-22 14:11:23 +02:00
mballoc.h
migrate.c	ext4: don't use the orphan list when migrating an inode	2022-01-27 09:19:51 +01:00
mmp.c	ext4: don't assume that mmp_nodename/bdevname have NUL	2020-02-19 19:52:58 +01:00
move_extent.c	ext4: use jbd2_inode dirty range scoping	2019-06-20 17:26:26 -04:00
namei.c	ext4: make variable "count" signed	2022-06-22 14:11:23 +02:00
page-io.c	ext4: fix symlink file size not match to file content	2022-04-27 13:50:50 +02:00
readpage.c	ext4: fix deadlock allocating bio_post_read_ctx from mempool	2020-02-24 08:36:29 +01:00
resize.c	ext4: add reserved GDT blocks check	2022-06-22 14:11:23 +02:00
super.c	ext4: reject the 'commit' option on ext2 filesystems	2022-06-14 18:11:38 +02:00
symlink.c	ext4: report correct st_size for encrypted symlinks	2021-09-12 08:56:38 +02:00
sysfs.c	ext4: shrink race window in ext4_should_retry_alloc()	2021-04-07 14:47:38 +02:00
truncate.h
verity.c	ext4: fix error handling in ext4_end_enable_verity()	2021-05-26 12:05:21 +02:00
xattr.c	ext4: add reclaim checks to xattr code	2021-03-30 14:35:29 +02:00
xattr.h
xattr_security.c
xattr_trusted.c
xattr_user.c