mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-14 06:35:12 +00:00
ed43ffea78
The iSCSI target login thread might get stuck with the following stack: cat /proc/`pidof iscsi_np`/stack [<0>] down_interruptible+0x42/0x50 [<0>] iscsit_access_np+0xe3/0x167 [<0>] iscsi_target_locate_portal+0x695/0x8ac [<0>] __iscsi_target_login_thread+0x855/0xb82 [<0>] iscsi_target_login_thread+0x2f/0x5a [<0>] kthread+0xfa/0x130 [<0>] ret_from_fork+0x1f/0x30 This can be reproduced via the following steps: 1. Initiator A tries to log in to iqn1-tpg1 on port 3260. After finishing PDU exchange in the login thread and before the negotiation is finished the the network link goes down. At this point A has not finished login and tpg->np_login_sem is held. 2. Initiator B tries to log in to iqn2-tpg1 on port 3260. After finishing PDU exchange in the login thread the target expects to process remaining login PDUs in workqueue context. 3. Initiator A' tries to log in to iqn1-tpg1 on port 3260 from a new socket. A' will wait for tpg->np_login_sem with np->np_login_timer loaded to wait for at most 15 seconds. The lock is held by A so A' eventually times out. 4. Before A' got timeout initiator B gets negotiation failed and calls iscsi_target_login_drop()->iscsi_target_login_sess_out(). The np->np_login_timer is canceled and initiator A' will hang forever. Because A' is now in the login thread, no new login requests can be serviced. Fix this by moving iscsi_stop_login_thread_timer() out of iscsi_target_login_sess_out(). Also remove iscsi_np parameter from iscsi_target_login_sess_out(). Link: https://lore.kernel.org/r/20200729130343.24976-1-houpu@bytedance.com Cc: stable@vger.kernel.org Reviewed-by: Mike Christie <michael.christie@oracle.com> Signed-off-by: Hou Pu <houpu@bytedance.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
29 lines
1.2 KiB
C
29 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef ISCSI_TARGET_LOGIN_H
|
|
#define ISCSI_TARGET_LOGIN_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct iscsi_conn;
|
|
struct iscsi_login;
|
|
struct iscsi_np;
|
|
struct sockaddr_storage;
|
|
|
|
extern int iscsi_login_setup_crypto(struct iscsi_conn *);
|
|
extern int iscsi_check_for_session_reinstatement(struct iscsi_conn *);
|
|
extern int iscsi_login_post_auth_non_zero_tsih(struct iscsi_conn *, u16, u32);
|
|
extern int iscsit_setup_np(struct iscsi_np *,
|
|
struct sockaddr_storage *);
|
|
extern int iscsi_target_setup_login_socket(struct iscsi_np *,
|
|
struct sockaddr_storage *);
|
|
extern int iscsit_accept_np(struct iscsi_np *, struct iscsi_conn *);
|
|
extern int iscsit_get_login_rx(struct iscsi_conn *, struct iscsi_login *);
|
|
extern int iscsit_put_login_tx(struct iscsi_conn *, struct iscsi_login *, u32);
|
|
extern void iscsit_free_conn(struct iscsi_conn *);
|
|
extern int iscsit_start_kthreads(struct iscsi_conn *);
|
|
extern void iscsi_post_login_handler(struct iscsi_np *, struct iscsi_conn *, u8);
|
|
extern void iscsi_target_login_sess_out(struct iscsi_conn *, bool, bool);
|
|
extern int iscsi_target_login_thread(void *);
|
|
extern void iscsi_handle_login_thread_timeout(struct timer_list *t);
|
|
|
|
#endif /*** ISCSI_TARGET_LOGIN_H ***/
|