mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
![Takashi Iwai](/assets/img/avatar_default.png)
For sysfs outputs, it's safer to use a new helper, sysfs_emit(), instead of the raw sprintf() & co. This patch replaces such sprintf() calls with sysfs_emit() while simplifying the open code in modalias_show(); as modalias[] is a NUL-terminated string, we can pass it straightly to a printf() argument. Link: https://lore.kernel.org/r/20220801165639.26030-3-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
48 lines
1.2 KiB
C
48 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/kernel.h>
|
|
#include <linux/of.h>
|
|
#include <linux/stat.h>
|
|
/* FIX UP */
|
|
#include "soundbus.h"
|
|
|
|
static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct soundbus_dev *sdev = to_soundbus_device(dev);
|
|
struct platform_device *of = &sdev->ofdev;
|
|
|
|
if (*sdev->modalias)
|
|
return sysfs_emit(buf, "%s\n", sdev->modalias);
|
|
else
|
|
return sysfs_emit(buf, "of:N%pOFn%c%s\n",
|
|
of->dev.of_node, 'T',
|
|
of_node_get_device_type(of->dev.of_node));
|
|
}
|
|
static DEVICE_ATTR_RO(modalias);
|
|
|
|
static ssize_t name_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct soundbus_dev *sdev = to_soundbus_device(dev);
|
|
struct platform_device *of = &sdev->ofdev;
|
|
|
|
return sysfs_emit(buf, "%pOFn\n", of->dev.of_node);
|
|
}
|
|
static DEVICE_ATTR_RO(name);
|
|
|
|
static ssize_t type_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct soundbus_dev *sdev = to_soundbus_device(dev);
|
|
struct platform_device *of = &sdev->ofdev;
|
|
|
|
return sysfs_emit(buf, "%s\n", of_node_get_device_type(of->dev.of_node));
|
|
}
|
|
static DEVICE_ATTR_RO(type);
|
|
|
|
struct attribute *soundbus_dev_attrs[] = {
|
|
&dev_attr_name.attr,
|
|
&dev_attr_type.attr,
|
|
&dev_attr_modalias.attr,
|
|
NULL,
|
|
};
|