mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 02:09:42 +00:00
357b41caf9
Without this modification and if CRYPTO is not selected, we have this
warning:
WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- MPTCP [=y] && NET [=y] && INET [=y]
MPTCP selects CRYPTO_LIB_SHA256 which seems to depend on CRYPTO. CRYPTO
is now selected to avoid this issue.
Even though the config system prints that warning, it looks like
sha256.c is compiled and linked even without CONFIG_CRYPTO. Since MPTCP
will end up needing CONFIG_CRYPTO anyway in future commits -- currently
in preparation for net-next -- we propose to add it now to fix the
warning.
The dependency in the config system comes from the fact that
CRYPTO_LIB_SHA256 is defined in "lib/crypto/Kconfig" which is sourced
from "crypto/Kconfig" only if CRYPTO is selected.
Fixes: 65492c5a6a (mptcp: move from sha1 (v0) to sha256 (v1))
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
29 lines
658 B
Text
29 lines
658 B
Text
|
|
config MPTCP
|
|
bool "MPTCP: Multipath TCP"
|
|
depends on INET
|
|
select SKB_EXTENSIONS
|
|
select CRYPTO_LIB_SHA256
|
|
select CRYPTO
|
|
help
|
|
Multipath TCP (MPTCP) connections send and receive data over multiple
|
|
subflows in order to utilize multiple network paths. Each subflow
|
|
uses the TCP protocol, and TCP options carry header information for
|
|
MPTCP.
|
|
|
|
if MPTCP
|
|
|
|
config MPTCP_IPV6
|
|
bool "MPTCP: IPv6 support for Multipath TCP"
|
|
select IPV6
|
|
default y
|
|
|
|
config MPTCP_HMAC_TEST
|
|
bool "Tests for MPTCP HMAC implementation"
|
|
help
|
|
This option enable boot time self-test for the HMAC implementation
|
|
used by the MPTCP code
|
|
|
|
Say N if you are unsure.
|
|
|
|
endif
|